[HOLD for payment 2024-05-22] [LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features

[tgolen]

• Held on [HOLD for payment 2023-12-20] [DISTANCE] LOW: PHASE 1: Wave 5 CLEANUP Refactor navigation among screens related to money request features #26538

In #26538 Most of the changes were made by adding new components. This eliminated a lot of conflicting headaches from people working on existing components.

Phase 2 is all about removing the original components and any of the duplicated efforts. The tasks that need to be done as part of this issue are:

• Remove iou/ReceiptSelector and copy any changes since Nov 27 into IOURequestStepScan/
• Remove WaypointEditor.js and copy any changes since Nov 27 into IOURequestStepWaypoint.js
• [HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js #34606
• [HOLD for payment 2024-04-25] [$250] Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #34607
• [$250] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js #34608
• [HOLD for payment 2024-02-19] [$250] Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js #34609
• [Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610
• [HOLD for payment 2024-02-26] [$250] Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js #34611
• [HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js #34612
• [HOLD for payment 2024-03-26] [$250] Remove MoneyRequestSelectorPage.js and copy any changes since Nov 27 into IOURequestStartPage.js #34613
• [HOLD for payment 2024-04-15] [$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js #34614
• [HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js #34615
• [$250] Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #34616
• Remove MoneyRequestParticipantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector #34617
• [HOLD for payment 2024-05-02] [$250] Remove MoneyRequestConfirmationList.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestConfirmationList.js #39559
• HOLD Edit ROUTES.ts and remove MONEY_REQUEST_* routes, remove "create" from the front of the routes
• HOLD Edit linkgingConfig.js and remove Money_Request* screens
• HOLD Edit ModalStackNavigators.js remove old Money_Request* components
• HOLD Edit IOU.js and remove _temporaryForRefactor from the name of any methods
• HOLD Edit IOU.js and remove startMoneyRequest() method and rename startMoneeRequest() to startMoneyRequest()
• HOLD Edit IOU.js and remove createDistanceRequest() method and use requestMoneyFromDistance() everywhere
• HOLD Remove ONYXKEYS.IOU
• HOLD Remove EditRequestPage
• HOLD Remove EditSplitBillPage

git diff "tgolen-refactor-request-navigation2@{2023-11-15}..main" src/pages/iou/IOUCurrencySelection.js

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b453df445e7dd962
• Upwork Job ID: 1711432700883152896
• Last Price Increase: 2023-10-09

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b453df445e7dd962

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

[tgolen]

This is still mostly on HOLD while I work on phase 1. I updated this issue yesterday to change the date of the last time I checked the files for change, which I also did yesterday.

[melvin-bot]

This issue has not been updated in over 15 days. @tgolen, @ntdiary eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[pasyukevich]

Hi,
I'm Eugene from Callstack

I will migrate it

Rename MoneyTemporaryForRefactorRequestParticipantsSelector.js to MoneyRequestParticipantsSelector.tsx and migrate to TS

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

Sorry about that. The PR approval automation didn't work as expected

[amyevans]

@s77rt so @francoisl, @chiragsalian, and I should unassign? Just want to double check since I'm unclear where the trigger even came from 😅

[s77rt]

@chiragsalian should stay assigned. You and @francoisl can unassign

PS: The trigger came from PR approval

[DylanDylann]

Weekly Update

Everything in this checklist is done. We are waiting for #41216 to be merged to close this issue. The reason why we need to wait for #41216 to be merged is that besides migrating to typescript we also changed the name of the file, which is part of this issue

[tgolen]

I was able to merge that PR this morning, so I will go ahead and close this issue out. Thanks for all the help with this!!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate MoneyTemporaryForRefactorRequestParticipantsSe… #41216

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment (Needs manual offer from BZ)