[HOLD for payment 2023-10-31][$500] App displays 'Pay with expensify' popup on side and not over the button

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.81.5
Reproducible in staging?: y
Reproducible in production?: no ( send money just implemented)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697010754038929

Action Performed:

1. Open the app
2. Click on green plus and click on send money
3. Select USD, enter any amount and continue
4. Select any user
5. Click on 'Pay with expensify' and observe that popup is displayed offset

Expected Result:

Popup should be displayed above button as we do for change option popup

Actual Result:

Popup is displayed offset from above button for 'pay with expensify'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

mac.chrome.pay.popup.on.side.mov

windows.chrome.offset.pay.with.expensify.popup.mp4

Recording.4951.mp4

MacOS: Desktop

mac.desktop.pay.popup.on.side.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7f1095001e7c867
• Upwork Job ID: 1712131850035339264
• Last Price Increase: 2023-10-11
• Automatic offers:
• Nikhil-Vats | Contributor | 27671898
• dhanashree-sawant | Reporter | 27671899

Issue Owner

Current Issue Owner: @johncschuster

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7f1095001e7c867

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays 'Pay with expensify' popup on side and not over the button

What is the root cause of that problem?

The root cause is we have not sent anchorAlignment prop here

App/src/components/MoneyRequestConfirmationList.js

Lines 452 to 459 in 1157133

	<ButtonWithDropdownMenu
	pressOnEnter
	isDisabled={shouldDisableButton}
	onPress={(_event, value) => confirm(value)}
	options={splitOrRequestOptions}
	buttonSize={CONST.DROPDOWN_BUTTON_SIZE.LARGE}
	style={[styles.mt2]}
	/>

What changes do you think we should make in order to solve the problem?

Just pass this prop as
the solution would look something like this

      anchorAlignment={{
                    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
                    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                }}

Result

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the money send confirmation page position of the "Pay with expensify" popover is incorrect

What is the root cause of that problem?

We are passing incorrect anchor horizontal alignment value in the MoneyRequestConfirmationList. Bcoz RIGHT means the anchor remains on the right side and popover open on the left.

App/src/components/MoneyRequestConfirmationList.js

Line 447 in d59cc1e

horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,

App/src/components/PopoverWithMeasuredContent.js

Lines 94 to 106 in d59cc1e

	let horizontalConstraint;
	switch (props.anchorAlignment.horizontal) {
	case CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT:
	horizontalConstraint = {left: props.anchorPosition.horizontal - popoverWidth};
	break;
	case CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.CENTER:
	horizontalConstraint = {
	left: Math.floor(props.anchorPosition.horizontal - popoverWidth / 2),
	};
	break;
	case CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT:
	default:
	horizontalConstraint = {left: props.anchorPosition.horizontal};

What changes do you think we should make in order to solve the problem?

We should pass the value LEFT to open it on the same left horizontal level of the anchor element.

horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,

I am not sure whether it is considered as a regression from #28744 or not as we missed this instance of popover there.

[aimane-chnaif]

This should not be considered as regression as Send feature was disabled at the time of that PR work. Context: #28321 (comment)
But @Nikhil-Vats will fix this as follow-up since Send feature is enabled again, and I will take this as C+.

[aimane-chnaif]

@Nikhil-Vats will you raise PR soon?

[Pujan92]

Just to inform, in case @Nikhil-Vats isn't available and if the issue is urgent then I can raise a PR quickly if my proposal got selected.

[Nikhil-Vats]

I can work on this, I have started working on the PR.

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @Nikhil-Vats 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[johncschuster]

Looks like the Upwork automation for job invites was never triggered. I've just done that now so we can issue payments.

[Nikhil-Vats]

Thanks @johncschuster . I have accepted the offer.

[aimane-chnaif]

I was C+ in PR

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins, @Nikhil-Vats Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

Just waiting on payment

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins, @Nikhil-Vats Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

@johncschuster could you please assist with payment? thanks!

[melvin-bot]

@johncschuster, @eVoloshchak, @luacmartins, @Nikhil-Vats Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Waiting on payment

[johncschuster]

Payment Summary:
Bug Reporter: @dhanashree-sawant requires payment - $50 via Upwork PAID
Contributor: @Nikhil-Vats requires payment $500 + $250 urgency bonus via Upwork PAID
Reviewer: @aimane-chnaif requires payment of $500 +$250 urgency bonus paid via Upwork (just invited to the job now)

[luacmartins]

Just pending payment to @aimane-chnaif

[johncschuster]

Payment has been issued to @aimane-chnaif! We're good to go!