[CP Staging] Fix send button popover position #29361

Nikhil-Vats · 2023-10-11T18:52:50Z

Details

Fixed Issues

$ #29332
$ #30130
PROPOSAL: #29332 (comment)

Tests

Use 2 of your accounts for testing. Login with account 1, request money in the chat by going to chat with account 2 > click on + button > Request money > Enter details and click on request money button. Afterwards login with account 2 and follow the steps below -
In the chat, click the pay button in Report Preview. The popover should open above the button. Also, click on the caret icon, the popover should open above the button too.

See screenshot to see what it should look like.

Screen.Recording.2023-10-12.at.12.17.19.AM.mov
Now, click on the report preview and in the header try clicking on the caret (dropdown icon) and the main button and make sure both popovers open below the button.

See video to see what it should look like.

Screen.Recording.2023-10-04.at.1.30.43.AM.mov
Now, go to settings > wallet. Click on transfer balance and verify that the popover opens below the transfer balance button.

See video to see what it should look like.

Screen.Recording.2023-10-04.at.1.32.07.AM.mov
Go to a 1:1 chat. Click on "+" button in composer > Send money. Enter an amount and select USD as currency. Click on next. On the final screen, at the botton, there should be a button and a caret icon, popovers for both should open above the button.

See video to see what it should look like.

Screen.Recording.2023-10-12.at.12.19.39.AM.mov

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

29332_android.mp4

Android: mWeb Chrome

29332_mweb_chrome.mp4

29332_mweb_chrome2.mov

iOS: Native

29332_ios.mp4

iOS: mWeb Safari

29332_mweb_safari.mp4

MacOS: Chrome / Safari

29332_web.mp4

MacOS: Desktop

29332_desktop.mp4

melvin-bot · 2023-10-11T18:52:55Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Nikhil-Vats · 2023-10-11T18:54:36Z

src/components/SettlementButton.js

+    kycWallAnchorAlignment: {
+        horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT, // button is at left, so horizontal anchor is at LEFT
+        vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP, // we assume that popover menu opens below the button, anchor is at TOP
+    },
+    paymentMethodDropdownAnchorAlignment: {
+        horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT, // caret for dropdown is at right, so horizontal anchor is at RIGHT 


@aimane-chnaif we need to have different props for both because for dropdown button (payment method options), caret is aligned at right so horizontal anchor should be right.

For button, we need the horizontal anchor alignment to be LEFT as the button is aligned towards left.

Nikhil-Vats · 2023-10-11T18:55:08Z

src/components/MoneyReportHeader.js

-                            anchorAlignment={{
-                                horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
-                                vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
-                            }}


don't need to pass props unnecessarily as the default props are enough here

Nikhil-Vats · 2023-10-11T18:57:09Z

src/components/MoneyRequestConfirmationList.js

+                kycWallAnchorAlignment={{
+                    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
+                    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
+                }}
+                paymentMethodDropdownAnchorAlignment={{
                    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
                    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                }}


this button is at bottom of page so vertical anchor alignment is BOTTOM (popover above button). the horizontal anchor alignment for second one is RIGHT because caret icon is at right

Nikhil-Vats · 2023-10-11T18:57:31Z

src/components/ReportActionItem/ReportPreview.js

+                                kycWallAnchorAlignment={{
                                    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT,
                                    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
                                }}
+                                paymentMethodDropdownAnchorAlignment={{
+                                    horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
+                                    vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
+                                }}


same reason as above

Nikhil-Vats · 2023-10-11T18:57:58Z

src/components/SettlementButton.js

+    kycWallAnchorAlignment,
+    paymentMethodDropdownAnchorAlignment,


@aimane-chnaif if you have any better prop name suggestions, please let me know

Fine with those namings

aimane-chnaif · 2023-10-11T19:04:27Z

Please fix lint and complete author checklist

Nikhil-Vats · 2023-10-11T19:27:29Z

@aimane-chnaif lint error fixed, videos uploaded for all platforms except native apps. It is taking some time to build, will upload shortly.

aimane-chnaif · 2023-10-11T19:28:17Z

Also pull main

Nikhil-Vats · 2023-10-11T19:33:08Z

Can you tell me when should I pull main again into my PR branch even without conflicts? Because I just pulled it before starting this PR (2-3 hours ago) so I want to know the rationale behind it so that I can do it in future PRs as well to avoid regressions.

aimane-chnaif · 2023-10-11T19:34:36Z

The more often pulling main, the less chance of regressions.

Lint error on main was fixed some min ago - #29359

Nikhil-Vats · 2023-10-11T19:35:51Z

ok will do shortly, thanks for the explanation.

Nikhil-Vats · 2023-10-11T21:09:05Z

@aimane-chnaif main was merged and all videos uploaded

Nikhil-Vats · 2023-10-13T17:45:25Z

@aimane-chnaif I have merged main again and tested all popovers. Can you review?

aimane-chnaif · 2023-10-13T17:45:46Z

in an hr

aimane-chnaif · 2023-10-16T09:45:57Z

@Nikhil-Vats please pull main

aimane-chnaif · 2023-10-16T15:12:14Z

@Nikhil-Vats bump, there's conflict

Nikhil-Vats · 2023-10-16T15:18:52Z

@aimane-chnaif done.

aimane-chnaif · 2023-10-16T15:34:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

aimane-chnaif

LGTM 🎉

aimane-chnaif

reapproving to get engineer review

aimane-chnaif · 2023-10-21T21:31:23Z

@Nikhil-Vats conflicts

thienlnam · 2023-10-22T01:23:28Z

Fixing conflicts so we can get this merged

aimane-chnaif · 2023-10-22T02:19:22Z

Just retested, still looks good

melvin-bot · 2023-10-22T02:20:36Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-10-22T02:26:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2023-10-22T03:14:47Z

Tests passed. Not an emergency.

Fix send button popover position (cherry picked from commit 3656ae1)

OSBotify · 2023-10-22T21:29:40Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.88-6 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-23T04:48:42Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix send button popover position

c2283d9

Nikhil-Vats requested a review from a team as a code owner October 11, 2023 18:52

melvin-bot bot requested review from eVoloshchak and removed request for a team October 11, 2023 18:52

Nikhil-Vats commented Oct 11, 2023

View reviewed changes

Fix lint error

9564f49

Merge branch 'main' into 29332_send_payment_popover

dbe041c

Merge branch 'main' into 29332_send_payment_popover

b7fc294

Merge branch 'main' into 29332_send_payment_popover

aaeef6f

aimane-chnaif approved these changes Oct 16, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair October 16, 2023 15:38

Pujan92 mentioned this pull request Oct 21, 2023

[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] IOU - Bank account and Debit card modal appears on the left of Pay with Expensify button #30130

Closed

6 tasks

Merge branch 'main' into pr/29361

a2bdeea

luacmartins approved these changes Oct 22, 2023

View reviewed changes

luacmartins merged commit 3656ae1 into Expensify:main Oct 22, 2023
11 checks passed

melvin-bot bot added the Emergency label Oct 22, 2023

luacmartins removed the Emergency label Oct 22, 2023

mountiny changed the title ~~Fix send button popover position~~ [CP Staging] Fix send button popover position Oct 22, 2023

OSBotify pushed a commit that referenced this pull request Oct 22, 2023

Merge pull request #29361 from Nikhil-Vats/29332_send_payment_popover

d5d7f71

Fix send button popover position (cherry picked from commit 3656ae1)

OSBotify mentioned this pull request Oct 22, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

melvin-bot bot mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-10-31][$500] App displays 'Pay with expensify' popup on side and not over the button #29332

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix send button popover position #29361

[CP Staging] Fix send button popover position #29361

Nikhil-Vats commented Oct 11, 2023 •

edited by luacmartins

Loading

melvin-bot bot commented Oct 11, 2023

Nikhil-Vats Oct 11, 2023

Nikhil-Vats Oct 11, 2023

Nikhil-Vats Oct 11, 2023

Nikhil-Vats Oct 11, 2023

Nikhil-Vats Oct 11, 2023

aimane-chnaif Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

Nikhil-Vats commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

Nikhil-Vats commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023 •

edited

Loading

Nikhil-Vats commented Oct 11, 2023

Nikhil-Vats commented Oct 11, 2023

Nikhil-Vats commented Oct 13, 2023

aimane-chnaif commented Oct 13, 2023

aimane-chnaif commented Oct 16, 2023

aimane-chnaif commented Oct 16, 2023

Nikhil-Vats commented Oct 16, 2023

aimane-chnaif commented Oct 16, 2023

aimane-chnaif left a comment

aimane-chnaif left a comment

aimane-chnaif commented Oct 21, 2023

thienlnam commented Oct 22, 2023

aimane-chnaif commented Oct 22, 2023

melvin-bot bot commented Oct 22, 2023

OSBotify commented Oct 22, 2023

luacmartins commented Oct 22, 2023

OSBotify commented Oct 22, 2023

OSBotify commented Oct 23, 2023

		kycWallAnchorAlignment,
		paymentMethodDropdownAnchorAlignment,

[CP Staging] Fix send button popover position #29361

[CP Staging] Fix send button popover position #29361

Conversation

Nikhil-Vats commented Oct 11, 2023 • edited by luacmartins Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2023

Nikhil-Vats Oct 11, 2023

Choose a reason for hiding this comment

Nikhil-Vats Oct 11, 2023

Choose a reason for hiding this comment

Nikhil-Vats Oct 11, 2023

Choose a reason for hiding this comment

Nikhil-Vats Oct 11, 2023

Choose a reason for hiding this comment

Nikhil-Vats Oct 11, 2023

Choose a reason for hiding this comment

aimane-chnaif Oct 11, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Oct 11, 2023

Nikhil-Vats commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

Nikhil-Vats commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023 • edited Loading

Nikhil-Vats commented Oct 11, 2023

Nikhil-Vats commented Oct 11, 2023

Nikhil-Vats commented Oct 13, 2023

aimane-chnaif commented Oct 13, 2023

aimane-chnaif commented Oct 16, 2023

aimane-chnaif commented Oct 16, 2023

Nikhil-Vats commented Oct 16, 2023

aimane-chnaif commented Oct 16, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Oct 21, 2023

thienlnam commented Oct 22, 2023

aimane-chnaif commented Oct 22, 2023

melvin-bot bot commented Oct 22, 2023

OSBotify commented Oct 22, 2023

luacmartins commented Oct 22, 2023

OSBotify commented Oct 22, 2023

OSBotify commented Oct 23, 2023

Nikhil-Vats commented Oct 11, 2023 •

edited by luacmartins

Loading

aimane-chnaif commented Oct 11, 2023 •

edited

Loading