[CP Staging] Fix couple of bugs in the Send money flow #29358

mountiny · 2023-10-11T18:40:35Z

Details

This is one PR to cover multiple flaws in the Send Money request flow:

We are hiding the Split option in the participants page if we are in send money flow
We are updating the copy in the header title of the money request pages when in send money flow to Send
We are enabling the Enter button on the money request confirmation page in Send money flow
We are hiding the date and merchant fields in the Send money flow as those cannot be edited right now
The IOU report is correctly optimistically created as paid so when you send money offline, and navigate to the request you cannot edit it and it shows as paid

Fixed Issues

$ #29330
$ #29384
$ #29373
$ #29363
PROPOSAL:

Tests

No split for Send money flow

Click Send money
Select amount
Verify you dont see the Split button on the participant rows
Close the flow
Choose Request Money
Add amount
Verify you can see and use the split options here

Optimistically sent money shows as paid and cant be edited

Go offline
Click Send money
Select amount
Select participant
Confirm and send money
Verify you are navigated to the DM and you can see the report Preview wisth correct amount shown as paid
Navigate to the IOU report
Verify the report shows as paid, there is no Payment button
Navigate to the request details
Verify it shows as paid and you cannot edit the properties

No date or merchant

Click Send money
Select amount
Select Participant
On the confirmation page, verify you can only change amount and description
Verify you cannot see any other field

Verify other manual request flows did not change

Request Money
Select amount
Select payer
Verify you can see the Show More button and you can add created or merchant

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Same as web

cloudflare-workers-and-pages · 2023-10-11T21:42:35Z

Deploying with Cloudflare Pages

Latest commit:	`ca067bc`
Status:	✅ Deploy successful!
Preview URL:	https://4f2a8909.helpdot.pages.dev
Branch Preview URL:	https://vit-dontalloweditingdateandm.helpdot.pages.dev

View logs

melvin-bot · 2023-10-11T22:22:10Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jasperhuangg · 2023-10-11T22:53:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-10-11T23:28:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…erchantOnSendMoney [CP Staging] Fix couple of bugs in the Send money flow (cherry picked from commit e3adc6c)

github-actions · 2023-10-12T00:36:36Z

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1214.558 ms → 1289.725 ms (+75.167 ms, +6.2%) 🔴
App start runJsBundle	824.413 ms → 883.533 ms (+59.120 ms, +7.2%) 🔴

Show details

Name	Duration
App start TTI	Baseline Mean: 1214.558 ms Stdev: 53.567 ms (4.4%) Runs: 1081.49093300011 1092.9574879999273 1113.4683940000832 1116.2789570000023 1126.778941999888 1133.2895470000803 1144.6999389999546 1149.9243499999866 1151.8159799999557 1154.7256040000357 1156.500471000094 1156.7745509999804 1160.2308759998996 1160.5867900000885 1165.9029620001093 1166.0388410000596 1167.1834619999863 1167.481095999945 1167.7455110000446 1170.1446320000105 1173.5871250000782 1174.5820919999387 1174.9758220000658 1176.9188409999479 1177.256505999947 1177.4182659999933 1177.6134369999636 1179.9876419999637 1181.0644779999275 1182.6452029999346 1186.0699730000924 1189.6530089997686 1190.0807139999233 1194.365446999902 1196.657952999929 1200.4938050000928 1200.932647000067 1201.6449390000198 1203.324314000085 1204.2117250000592 1204.6922840001062 1204.9727869997732 1205.3982949999627 1208.0120890000835 1208.3476379998028 1212.0909210001118 1214.3649009999353 1216.5654569999315 1217.3406199999154 1217.5754609999713 1221.0179949998856 1221.5733209999744 1221.9937239999417 1222.3601730000228 1223.6774840001017 1224.3362280000001 1224.7220099999104 1227.34541300009 1227.6319149998017 1227.6658950001001 1229.9950959999114 1233.920046000043 1234.0523850000463 1239.0186879998073 1239.0483180000447 1243.5603900002316 1246.512935999781 1248.8917899997905 1250.9799529998563 1251.4712859999854 1252.5461340001784 1256.737683000043 1257.1788670001552 1264.3927390000317 1269.6938550001942 1270.174135999987 1271.7034130000975 1271.7210440000053 1279.8578689999413 1283.0413649999537 1286.6333989999257 1287.0699829999357 1288.4258689999115 1290.354793000035 1295.6982689998113 1299.6326810000464 1301.665190000087 1302.519201000221 1311.8652339999098 1314.7566829998977 1318.1657610000111 1348.904489000095 Current Mean: 1289.725 ms Stdev: 67.880 ms (5.3%) Runs: 1158.8815430002287 1171.0284529998899 1172.7075760001317 1178.2375389998779 1179.2096279999241 1185.4012400000356 1187.6501719998196 1195.869183999952 1196.4146130001172 1197.4942399999127 1200.2691890001297 1203.3376950002275 1211.7204729998484 1212.265211999882 1214.2752140001394 1215.2090790001675 1215.9617269998416 1216.8018510001712 1219.8063429999165 1220.12876399979 1227.7296520001255 1228.8369189999066 1229.7228279998526 1230.6009539999068 1231.081346000079 1233.1860210001469 1233.7956940000877 1241.7161460001953 1241.9705699998885 1249.758890000172 1256.2962079998106 1257.0341099998914 1259.6053289999254 1259.65586599987 1267.7821709997952 1269.6236769999377 1277.0755659998395 1278.452998000197 1279.0773860001937 1279.165343000088 1281.5510570001788 1283.118478000164 1284.0503920000046 1284.4807970002294 1287.60792700015 1291.8669409998693 1292.251858000178 1292.669617000036 1295.6249110000208 1301.0405410001986 1304.9118220000528 1307.7675950000994 1308.1628000000492 1309.9996549999341 1316.277094999794 1319.1590570001863 1319.198514000047 1320.802928000223 1323.5031139999628 1324.877981999889 1324.9928430002183 1333.2794849998318 1341.5154450000264 1341.7792930002324 1342.3420819998719 1343.9962220001034 1345.0804510000162 1345.9702690001577 1347.3438439997844 1347.4017900000326 1349.5060279997997 1350.9717700001784 1351.1424870002083 1353.0513920001686 1353.8886870001443 1357.8180010002106 1362.5758899999782 1363.1665630000643 1364.071169000119 1370.9189059999771 1372.1430339999497 1372.3070550002158 1380.5389629998244 1380.9251399999484 1381.69410300022 1387.5159550001845 1399.0057720001787 1399.162142999936 1406.5272200000472 1412.4874180001207 1448.0905909999274
App start runJsBundle	Baseline Mean: 824.413 ms Stdev: 38.875 ms (4.7%) Runs: 730 734 745 755 763 765 771 773 774 776 777 777 780 781 781 784 785 786 786 790 791 793 795 797 797 799 803 804 806 807 807 808 808 813 814 814 814 816 816 819 819 819 822 822 822 823 827 827 828 831 832 832 834 835 838 838 839 841 842 843 843 844 844 845 846 846 848 849 849 850 850 852 854 860 862 864 865 865 867 868 868 869 870 871 882 883 888 889 899 900 901 907 Current Mean: 883.533 ms Stdev: 47.989 ms (5.4%) Runs: 805 810 811 814 814 815 816 818 819 821 825 826 830 831 833 835 836 838 839 839 842 843 848 848 851 851 852 853 856 859 860 860 861 863 864 865 866 867 868 868 868 869 871 872 875 876 876 877 877 878 878 882 882 883 889 893 894 898 899 900 903 904 905 906 910 914 915 916 919 921 921 922 926 927 928 931 933 935 935 938 939 943 946 953 958 962 968 975 985 991 992 1007

Meaningless Changes To Duration

Show entries

Name	Duration
App start regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +8.1%)
App start nativeLaunch	23.110 ms → 21.713 ms (-1.397 ms, -6.0%)
Open Search Page TTI	625.363 ms → 619.343 ms (-6.020 ms, -1.0%)

Show details

Name	Duration
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (6.7%) Runs: 0.011922999983653426 0.01269600004889071 0.012818000046536326 0.0129399998113513 0.013061000034213066 0.013061000034213066 0.013142999960109591 0.013143000192940235 0.01318400027230382 0.013264999957755208 0.013264999957755208 0.013306000037118793 0.013306000037118793 0.013346000108867884 0.013386999955400825 0.013387999963015318 0.013427000027149916 0.013427999801933765 0.013508999953046441 0.013508999953046441 0.013549999799579382 0.013590000104159117 0.013590000104159117 0.013630999950692058 0.013752999948337674 0.013753999955952168 0.013753999955952168 0.013794000027701259 0.013794000027701259 0.013794000027701259 0.013833999866619706 0.013835000107064843 0.013996999710798264 0.013996999943628907 0.0139979999512434 0.014037999790161848 0.014038000022992492 0.01407799986191094 0.014078000094741583 0.014078999869525433 0.014078999869525433 0.014159999787807465 0.014159999787807465 0.014199999859556556 0.0142000000923872 0.014200999867171049 0.014241000171750784 0.014241000171750784 0.014282000018283725 0.014282000018283725 0.014282000018283725 0.014321999857202172 0.014404000015929341 0.014444999862462282 0.014445000095292926 0.014445000095292926 0.014484999934211373 0.014527000021189451 0.014607999939471483 0.014607999939471483 0.014648000011220574 0.014649000018835068 0.0147299999371171 0.014771000016480684 0.014851999934762716 0.014851999934762716 0.014851999934762716 0.0148930000141263 0.014933999627828598 0.015137000009417534 0.015137000009417534 0.015177000081166625 0.015178000088781118 0.015461999922990799 0.015503000002354383 0.015583999920636415 0.015746999997645617 0.015748000238090754 0.015829000156372786 0.016112999990582466 0.016112999990582466 0.01615400006994605 0.016195000149309635 0.01631700014695525 0.016478999983519316 0.01672299997881055 Current Mean: 0.015 ms Stdev: 0.001 ms (6.6%) Runs: 0.01293900003656745 0.013305999804288149 0.013428000267595053 0.013915999792516232 0.014037999790161848 0.014078999869525433 0.014078999869525433 0.014119999948889017 0.014241999946534634 0.014322999864816666 0.014323000330477953 0.014403999783098698 0.014404000248759985 0.014444999862462282 0.01448499970138073 0.014485999941825867 0.014526000246405602 0.014566999860107899 0.014607999939471483 0.014688999857753515 0.014688999857753515 0.014688999857753515 0.014689000323414803 0.01472900016233325 0.0147299999371171 0.0147299999371171 0.014769999776035547 0.014770000241696835 0.014810999855399132 0.01485099969431758 0.014851999934762716 0.014851999934762716 0.014891999773681164 0.014933999627828598 0.015054999850690365 0.015054999850690365 0.015056000091135502 0.01509599993005395 0.015136000234633684 0.015176999848335981 0.015177999623119831 0.015217999927699566 0.01525900000706315 0.015339999925345182 0.015339999925345182 0.015380000229924917 0.015381000004708767 0.015381000004708767 0.015461999922990799 0.015461999922990799 0.015462999697774649 0.015503000002354383 0.015503000002354383 0.015543000306934118 0.015585000161081553 0.015625 0.015666000079363585 0.015828999690711498 0.015868999995291233 0.015910000074654818 0.015910000074654818 0.01599099999293685 0.01607199991121888 0.01607199991121888 0.01607300015166402 0.016112999990582466 0.016153999604284763 0.01615400006994605 0.016276000067591667 0.016276999842375517 0.01631700014695525 0.01635799976065755 0.01635799976065755 0.016398000065237284 0.016478999983519316 0.016519999597221613 0.0165200000628829 0.016561000142246485 0.016642000060528517 0.016845999751240015 0.016846000216901302 0.016846000216901302 0.01696799974888563 0.01696800021454692 0.017008999828249216 0.017130000051110983 0.01713100029155612 0.01725299982354045 0.01741599990054965 0.018635999877005816
App start nativeLaunch	Baseline Mean: 23.110 ms Stdev: 3.893 ms (16.8%) Runs: 18 18 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 25 25 25 25 25 26 26 26 27 27 27 27 27 28 28 28 28 28 29 29 29 29 30 30 30 31 31 32 32 32 Current Mean: 21.713 ms Stdev: 2.868 ms (13.2%) Runs: 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 24 24 24 25 25 25 26 26 26 27 27 27 28 28 28 29 29 30
Open Search Page TTI	Baseline Mean: 625.363 ms Stdev: 22.619 ms (3.6%) Runs: 593.1236570002511 597.2097579999827 598.1739100003615 598.6941730002873 599.2936200001277 599.7517499998212 599.8209230001085 599.8418379998766 599.8528239997104 600.034953000024 601.2582200001925 604.106485999655 604.6446529999375 604.7077229996212 604.8951829997823 605.1618250003085 605.4835210000165 605.5049649998546 606.0944010000676 606.2427169997245 606.356201000046 606.4949949998409 606.6083990000188 607.1733809998259 607.2390959998593 608.1363929999061 608.4225669996813 608.4336350001395 608.4995940001681 609.0339359999634 609.2067470001057 610.9521899996325 611.378866000101 611.7766929999925 612.0278730001301 612.731648999732 613.5673830001615 614.0040700002573 614.1927490001544 614.5472820000723 615.2534179999493 615.2932540001348 615.5591230001301 615.803549000062 616.278239000123 617.4290370000526 617.7223720001057 617.9018969996832 621.5570479999296 621.9296470000409 622.0984290000051 622.2721770000644 622.3092859997414 622.6621910003014 623.2372240000404 624.4463710002601 626.0952559998259 627.7746590003371 630.4494630000554 630.8334150002338 630.9796139998361 631.8886730000377 632.2014569998719 632.4716389998794 633.3378090001643 634.5465899999253 637.9274909999222 638.5102540003136 639.4586999998428 641.1713050003164 641.3269449998625 646.8673500004224 648.0110280001536 648.2262780000456 650.9428710001521 651.6495369998738 654.4768880000338 654.8050130000338 654.9716400001198 654.9955239999108 655.8760589999147 656.9637859999202 662.4621989997104 664.7814949997701 665.6343180001713 666.0399989997968 666.6410730001517 666.948243000079 670.3789069997147 672.5535890003666 681.7674569999799 682.9524739999324 Current Mean: 619.343 ms Stdev: 13.216 ms (2.1%) Runs: 597.1359860002995 597.6151539999992 599.7438559997827 601.0012619998306 601.4519039997831 603.1351730003953 604.431396999862 605.4619960002601 605.5947679998353 605.8241779999807 605.8500169999897 605.856648999732 605.8585620000958 605.8732099998742 605.9378659999929 606.1299649998546 606.5218919999897 607.191203000024 608.2534999996424 608.3304040003568 609.5733239999972 610.844076000154 611.31197099993 613.5359299997799 613.571858999785 613.8253990001976 613.9092610003427 614.1479899999686 614.5202640001662 614.563192000147 614.690755000338 614.781860999763 614.8046059999615 615.2838950003497 615.4170739999972 615.4293619999662 615.4612630000338 615.8317459998652 615.9950359999202 616.3874519998208 616.5113940001465 616.7144770002924 616.8365889997222 617.3621430001222 617.7203770000488 617.9031989998184 618.025349999778 618.4788820003159 620.326253999956 620.6023360001855 620.6057540001348 620.7001550002024 620.7360840002075 620.8846430000849 621.1175950001925 621.4186200001277 621.8331709997728 622.5234379996546 622.6212570001371 624.0000409996137 625.4244389999658 625.5401200000197 625.5592859997414 626.2092290003784 626.8055420001037 629.2705080001615 629.597250000108 629.8624269999564 630.7974449996836 630.9280600002967 631.2622479996644 631.3332110000774 632.3342289999127 632.7174479998648 633.3891599997878 641.5682779997587 645.4111740002409 645.6643070001155 649.9029950001277 650.4799400004558 650.975179000292 655.9486090000719 656.4582120003179

github-actions · 2023-10-12T00:36:37Z

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

OSBotify · 2023-10-12T00:49:24Z

🚀 Cherry-picked to staging by https://github.com/justinpersaud in version: 1.3.81-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-12T01:38:22Z

🚀 Cherry-picked to staging by https://github.com/justinpersaud in version: 1.3.81-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

techievivek · 2023-10-12T02:50:02Z

Woaahh 🎉 , great work @mountiny, thanks for working on this. 🙇

OSBotify · 2023-10-12T04:48:29Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-13T21:55:23Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:07:26Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:23:40Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:59:04Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Do not allow editing date and merchant of send money

35d5cfa

mountiny self-assigned this Oct 11, 2023

mountiny mentioned this pull request Oct 11, 2023

Send money - Date is not saved when sending money #29381

Closed

6 tasks

Do not show Show more in case of send money request

bea5e63

mountiny added 2 commits October 11, 2023 22:57

Merge branch 'main' into vit-dontAllowEditingDateAndMerchantOnSendMoney

c8e52fd

Couple other send money polishes

9b2f6dd

mountiny marked this pull request as ready for review October 11, 2023 22:22

mountiny requested a review from a team as a code owner October 11, 2023 22:22

melvin-bot bot requested review from parasharrajat and removed request for a team October 11, 2023 22:22

mountiny changed the title ~~Do not allow editing date and merchant of send money~~ [CP Staging] Do not allow editing date and merchant of send money Oct 11, 2023

mountiny mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Enter key does not work in Send money confirmation page #29373

Closed

6 tasks

Add pressOnEnter to the SettlementButton

ca067bc

mountiny mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] Send money - Split bill can be created on Send money page #29363

Closed

6 tasks

jasperhuangg approved these changes Oct 11, 2023

View reviewed changes

tgolen approved these changes Oct 11, 2023

View reviewed changes

mountiny changed the title ~~[CP Staging] Do not allow editing date and merchant of send money~~ [CP Staging] Fix couple of bugs in the Send money flow Oct 11, 2023

jasperhuangg removed the request for review from parasharrajat October 11, 2023 23:22

jasperhuangg merged commit e3adc6c into main Oct 11, 2023
15 of 16 checks passed

jasperhuangg deleted the vit-dontAllowEditingDateAndMerchantOnSendMoney branch October 11, 2023 23:22

OSBotify pushed a commit that referenced this pull request Oct 12, 2023

Merge pull request #29358 from Expensify/vit-dontAllowEditingDateAndM…

f642523

…erchantOnSendMoney [CP Staging] Fix couple of bugs in the Send money flow (cherry picked from commit e3adc6c)

OSBotify mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 12, 2023

OSBotify mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Oct 12, 2023

hoangzinh mentioned this pull request Oct 12, 2023

[$500] Send money - Pay elsewhere appears for second on send money #29311

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix couple of bugs in the Send money flow #29358

[CP Staging] Fix couple of bugs in the Send money flow #29358

mountiny commented Oct 11, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 11, 2023 •

edited

Loading

melvin-bot bot commented Oct 11, 2023

jasperhuangg commented Oct 11, 2023 •

edited

Loading

OSBotify commented Oct 11, 2023

github-actions bot commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 12, 2023

techievivek commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

[CP Staging] Fix couple of bugs in the Send money flow #29358

[CP Staging] Fix couple of bugs in the Send money flow #29358

Conversation

mountiny commented Oct 11, 2023 • edited Loading

Details

Fixed Issues

Tests

No split for Send money flow

Optimistically sent money shows as paid and cant be edited

No date or merchant

Verify other manual request flows did not change

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

cloudflare-workers-and-pages bot commented Oct 11, 2023 • edited Loading

Deploying with Cloudflare Pages

melvin-bot bot commented Oct 11, 2023

jasperhuangg commented Oct 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Oct 11, 2023

github-actions bot commented Oct 12, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Meaningless Changes To Duration

github-actions bot commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 12, 2023

techievivek commented Oct 12, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

mountiny commented Oct 11, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 11, 2023 •

edited

Loading

jasperhuangg commented Oct 11, 2023 •

edited

Loading