[HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a group chat report
3. Tap plus icon and quickly tap the header

Expected Result:

In group details page, plus options like split bill, assign task and add attachment must not be shown

Actual Result:

In group details page, plus options like split bill, assign task and add attachment are shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6233473_1697051252956.double.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016354d05fb227f48d
• Upwork Job ID: 1714386765019463680
• Last Price Increase: 2023-10-24
• Automatic offers:
• ishpaul777 | Contributor | 27498473

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ishpaul777]

Proposal

Problem

When Header is clicked and quickly the plus is clicked the plus option open in report details page

Root Cause

When we click the header there is a naviagtion delay in that moment if user clicks the plus button the popover will open and then navigation happens, there is no code specific root cause just a case not handled.

Changes

We can avoid opening of Plus button options when navigation is in progress. We can use withNavigationFocus HOC to get isFocused prop which tells if screen is not focused(navigating in progress)

https://github.com/Expensify/App/blob/5d9ac2ceda20f487c5b0772d976217525a95d547/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js

ans onPress of plus button we can early return if isFoucused is false, the same ^ needs to be implemented for Emojipicker Popover.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Can we get a video for this one?

[JmillsExpensify]

Regardless, triaging for review and more proposals.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016354d05fb227f48d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[lanitochka17]

@JmillsExpensify Hello

The video is in the Screenshots/Videos tab

[melvin-bot]

@JmillsExpensify, @eVoloshchak Eep! 4 days overdue now. Issues have feelings too...

[keisyrzk]

I checked this with the latest main and I experience two mentioned options presence on all platforms not only those mentioned in the description.

[melvin-bot]

📣 @keisyrzk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[keisyrzk]

Hello!
I'm Krzysztof from Callstack - an expert contributor group and I would like to work on this one.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

The BZ member will need to manually hire keisyrzk for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[eVoloshchak]

Not overdue, @ishpaul777 is working on the follow-up PR

[JmillsExpensify]

Still working on follow-up PR

[JmillsExpensify]

Still waiting on regression fix.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fixes keyboard popup regression #32133

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @keisyrzk does not require payment (Contractor)
• @ishpaul777 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

@eVoloshchak Mind completing the BZ checklist?

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that caused this, this was caused by a race condition and reproducible only as an edge case
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is an edge case and the bug does not prevent users from using the app

Regression Test Proposal

1. Open any chat and upload a file bigger than 24 Mb. Dissmiss the popup error.
2. Tap on the report header, verify the keyboard doesn't pop up
3. Tap on the report header and quickly tap on plus icon, verify popover closes as soon user is navigated to details page
4. Tap on the report header and quickly tap on emoji popover, verify popover closes as soon user is navigated to details page
5. Tap the plus icon and quickly tap the header, verify popover closes as soon user is navigated to details page

Do we agree 👍 or 👎

[JmillsExpensify]

Thank you! Payment summary:

• Issue reporter: QA
• Contributor: $250 @ishpaul777
• Contributor+: $250 @eVoloshchak

[JmillsExpensify]

Contributor paid out and @eVoloshchak is paid via Expensify. Closing this issue!

[eVoloshchak]

@JmillsExpensify, there was a regression, shouldn't the payment be $250?

[JmillsExpensify]

Oh thank you for your honesty! I'll update the payment summary above and request a refund on the contributor payment.

[JmillsExpensify]

$250 payment approved for @eVoloshchak based on summary above.