fixes keyboard popup regression #32133

ishpaul777 · 2023-11-28T15:44:51Z

Details

This PR add changes from https://github.com/Expensify/App/pull/30864/files which was reverted because of regression along with fixing the regression caused.

Fixed Issues

$ #29379
PROPOSAL: #29379 (comment)

Tests

Verify that no errors appear in the JS console
Open any chat and upload a file more than 24mb. Dissmiss the popup error.
Tap on report Header verify the keyboard not pop ups
Tap on report header and quickly on plus icon verify popover not opens in details page
Tap on report header and quickly on emoji popover verify emoji popover not opens in details page
Tap plus icon and quickly tap the header verify popover closes as soon user is navigated to details page

Offline tests

QA Steps

Verify that no errors appear in the JS console
Open any chat and upload a file more than 24mb. Dissmiss the popup error.
Tap on report Header verify the keyboard not pop ups
Tap on report header and quickly on plus icon verify popover not opens in details page
Tap on report header and quickly on emoji popover verify emoji popover not opens in details page
Tap plus icon and quickly tap the header verify popover closes as soon user is navigated to details page

PR Author Checklist

Screenshots/Videos

Android: Native

trim.2C53B954-1217-4913-956F-35DE6DB4CDC3.MOV

Android: mWeb Chrome

trim.AA4F6506-9DA4-451B-AA6C-0668D47ED13B.MOV

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Plus.-.2023-11-28.at.21.33.37.mp4

iOS: mWeb Safari

New.Project.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-24.at.1.22.11.AM.mov

MacOS: Desktop

Screen.Recording.2023-11-08.at.3.55.41.PM.mov

melvin-bot · 2023-12-01T12:59:52Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2023-12-01T13:28:24Z

@eVoloshchak review when you get the chance. Thanks!

eVoloshchak · 2023-12-06T21:23:48Z

The code looks good, but this needs to be tested on physical devices same as previous PR

eVoloshchak

Approving so an internal engineer is assigned

eVoloshchak · 2023-12-06T21:26:23Z

@NikkiWines, same as previous PR, this isn't ready for your review yet, we just need the adHoc builds kicked off for this.
Could you add the "Ready To Build" label and

see https://stackoverflowteams.com/c/expensify/questions/15778/15779
Try https://github.com/Expensify/App/actions/workflows/testBuild.yml > Run workflow

Thanks!

NikkiWines · 2023-12-06T22:32:06Z

Sure thing! https://github.com/Expensify/App/actions/runs/7121081640

OSBotify · 2023-12-06T22:57:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/32133/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/32133/NewExpensify.dmg	https://32133.pr-testing.expensify.com

ishpaul777 · 2023-12-13T09:22:25Z

@eVoloshchak Can you complete checklist when you get the chance, Thanks!

eVoloshchak · 2023-12-14T15:42:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

screen-20231214-184158.mp4

Android: mWeb Chrome

screen-20231214-183955.mp4

iOS: Native

RPReplay_Final1702575161.MP4

iOS: mWeb Safari

RPReplay_Final1702575305.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-12-14.at.18.43.42.mov

MacOS: Desktop

Screen.Recording.2023-12-14.at.18.45.30.mov

eVoloshchak

There are conflicts, so merged this into main manually when testing (except for mWeb), works well
@ishpaul777, could you resolve conflicts please?

NikkiWines

looks good!

OSBotify · 2023-12-19T02:42:51Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:46:12Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-21T05:13:47Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ishpaul777 and others added 6 commits November 24, 2023 01:32

fixes keyboard popup regression

9af11cb

Merge branch 'main' into fix/29379

c921bed

resolve-conflicts

c0dee2d

fix prettier diffs

9c8fd3e

fix keyboard pop on navigation

337709b

revert unnecessary changes

1b7ea4b

ishpaul777 marked this pull request as ready for review December 1, 2023 12:59

ishpaul777 requested a review from a team as a code owner December 1, 2023 12:59

melvin-bot bot requested review from eVoloshchak and removed request for a team December 1, 2023 12:59

eVoloshchak approved these changes Dec 6, 2023

View reviewed changes

melvin-bot bot requested a review from NikkiWines December 6, 2023 21:24

NikkiWines added the Ready To Build label Dec 6, 2023

eVoloshchak approved these changes Dec 14, 2023

View reviewed changes

ishpaul777 and others added 2 commits December 15, 2023 00:22

Merge branch 'main' into fix/29379

0610dc7

fix lint

0b76ffd

ishpaul777 requested a review from eVoloshchak December 14, 2023 19:13

eVoloshchak approved these changes Dec 17, 2023

View reviewed changes

NikkiWines approved these changes Dec 18, 2023

View reviewed changes

NikkiWines merged commit 19ca744 into Expensify:main Dec 18, 2023
16 checks passed

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

melvin-bot bot mentioned this pull request Dec 21, 2023

[HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown #29379

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes keyboard popup regression #32133

fixes keyboard popup regression #32133

ishpaul777 commented Nov 28, 2023 •

edited

Loading

melvin-bot bot commented Dec 1, 2023

ishpaul777 commented Dec 1, 2023 •

edited

Loading

eVoloshchak commented Dec 6, 2023

eVoloshchak left a comment

eVoloshchak commented Dec 6, 2023

NikkiWines commented Dec 6, 2023

OSBotify commented Dec 6, 2023

ishpaul777 commented Dec 13, 2023

eVoloshchak commented Dec 14, 2023 •

edited

Loading

eVoloshchak left a comment

NikkiWines left a comment

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

fixes keyboard popup regression #32133

fixes keyboard popup regression #32133

Conversation

ishpaul777 commented Nov 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 1, 2023

ishpaul777 commented Dec 1, 2023 • edited Loading

eVoloshchak commented Dec 6, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

eVoloshchak commented Dec 6, 2023

NikkiWines commented Dec 6, 2023

OSBotify commented Dec 6, 2023

ishpaul777 commented Dec 13, 2023

eVoloshchak commented Dec 14, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

ishpaul777 commented Nov 28, 2023 •

edited

Loading

ishpaul777 commented Dec 1, 2023 •

edited

Loading

eVoloshchak commented Dec 14, 2023 •

edited

Loading