[HelpDot] article styling improvements #29539

rushatgabhane · 2023-10-13T09:14:26Z

Figma: https://www.figma.com/file/3OndJZZeOv4xqyLYcbY63e/Help-Site?node-id=1545%3A1130&mode=dev
Slack: https://expensify.slack.com/archives/C02QSAC6BJ8/p1697032431920559

cc: @dubielzyk-expensify @roryabraham

Add spacing between elements
Change h2 to have normal font weight
h3 to use font ExpensifyNeue
Make all articles use # for headings

Details

Fixed Issues

$ #29481
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

melvin-bot · 2023-10-13T09:14:32Z

@dubielzyk-expensify @ArekChr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

This reverts commit f1ef701.

dubielzyk-expensify · 2023-10-13T13:01:45Z

Still deciding on final design so I'll hold off approving until we got the final decision :)

rushatgabhane · 2023-10-13T22:10:10Z

docs/Gemfile.lock

@@ -256,6 +256,7 @@ GEM

 PLATFORMS
  arm64-darwin-22
+  arm64-darwin-23


this is to support new macos

rushatgabhane · 2023-10-13T22:10:59Z

@dubielzyk-expensify updated as per discussion on slack

dubielzyk-expensify

Great work!

thienlnam · 2023-10-16T20:40:43Z

docs/articles/expensify-classic/send-payments/Third-Party-Payments.md

+# Overview

 Expensify offers integration with various third party payment providers, making it easy to reimburse employees and manage your expenses seamlessly. Some of the key benefits of using third-party payment options in Expensify include:


I'm noticing just this page seems to have a newline under the header - since all the other files don't have this newline should we remove these in this file?

@thienlnam nice catch! But I don't think that matters

https://help.expensify.com/articles/expensify-classic/send-payments/Third-Party-Payments

Doesn't matter as in with or without it the same amount of spacing is shown?

yes, the same amount of spacing is shown

thienlnam · 2023-10-17T18:32:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thienlnam

Anyways, NAB

OSBotify · 2023-10-17T18:41:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-17T23:56:45Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:54:15Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rushatgabhane added 4 commits October 13, 2023 14:36

work on new macos

c1ed128

add better spacing and hr after every h1 in article

09bb627

trigger build cloudflare

f1ef701

Merge branch 'Expensify:main' into help-dot

cf2de88

rushatgabhane requested a review from a team as a code owner October 13, 2023 09:14

melvin-bot bot requested review from ArekChr and dubielzyk-expensify and removed request for a team October 13, 2023 09:14

rushatgabhane added 2 commits October 13, 2023 14:45

Revert "trigger build cloudflare"

ffe41a0

This reverts commit f1ef701.

fix formatting for old articles

fee57e5

rushatgabhane added 2 commits October 13, 2023 23:59

rm horizontal line and update spacing

341e56b

h2: use normal font weight

1618501

rushatgabhane commented Oct 13, 2023

View reviewed changes

docs/Gemfile.lock

@@ -256,6 +256,7 @@ GEM

PLATFORMS

arm64-darwin-22

arm64-darwin-23

Copy link

Member Author

rushatgabhane Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to support new macos

dubielzyk-expensify previously approved these changes Oct 15, 2023

View reviewed changes

rushatgabhane added 2 commits October 16, 2023 17:29

Merge branch 'Expensify:main' into help-dot

f226445

use h1 as base

be8244b

rushatgabhane dismissed dubielzyk-expensify’s stale review via be8244b October 16, 2023 12:00

thienlnam reviewed Oct 16, 2023

View reviewed changes

rushatgabhane requested a review from thienlnam October 17, 2023 11:17

thienlnam approved these changes Oct 17, 2023

View reviewed changes

thienlnam merged commit b494186 into Expensify:main Oct 17, 2023
13 of 17 checks passed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

melvin-bot bot mentioned this pull request Oct 18, 2023

[HOLD for payment 2023-10-25] Updates to the help site's visual design #29481

Closed

rushatgabhane deleted the help-dot branch December 19, 2023 00:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HelpDot] article styling improvements #29539

[HelpDot] article styling improvements #29539

rushatgabhane commented Oct 13, 2023 •

edited

Loading

melvin-bot bot commented Oct 13, 2023

dubielzyk-expensify commented Oct 13, 2023

rushatgabhane Oct 13, 2023

rushatgabhane commented Oct 13, 2023

dubielzyk-expensify left a comment

thienlnam Oct 16, 2023

rushatgabhane Oct 17, 2023

thienlnam Oct 17, 2023

rushatgabhane Oct 17, 2023 •

edited

Loading

thienlnam commented Oct 17, 2023 •

edited

Loading

thienlnam left a comment

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

		# Overview

		Expensify offers integration with various third party payment providers, making it easy to reimburse employees and manage your expenses seamlessly. Some of the key benefits of using third-party payment options in Expensify include:

[HelpDot] article styling improvements #29539

[HelpDot] article styling improvements #29539

Conversation

rushatgabhane commented Oct 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 13, 2023

dubielzyk-expensify commented Oct 13, 2023

rushatgabhane Oct 13, 2023

Choose a reason for hiding this comment

rushatgabhane commented Oct 13, 2023

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

thienlnam Oct 16, 2023

Choose a reason for hiding this comment

rushatgabhane Oct 17, 2023

Choose a reason for hiding this comment

thienlnam Oct 17, 2023

Choose a reason for hiding this comment

rushatgabhane Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

thienlnam commented Oct 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

thienlnam left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

rushatgabhane commented Oct 13, 2023 •

edited

Loading

rushatgabhane Oct 17, 2023 •

edited

Loading

thienlnam commented Oct 17, 2023 •

edited

Loading