-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab #29807
Comments
Triggered auto assignment to @zanyrenney ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @thienlnam ( |
|
I reverted 28372 on dev and can still reproduce the issue, so I don't think it's that. |
:hmm: If it's not that, it probably is related to some subscriber on the login page that is no longer prompting a refresh. I am looking at changes on that page but not seeing anything obvious |
This issue is originating from this line: App/src/libs/Navigation/AppNavigator/AuthScreens.js Lines 370 to 372 in 0a3ce76
If we remove retrieving demoInfo the issue won't happen. But I couldn't find why this is happening, I thought it was because we are accessing onyx data which is not present, but changing key here to any random string did not produce this issue. So the issue is only happening for demoInfo
Hope it helps |
Yeah thanks. Just finished a cc @Beamanator |
Hmm, we used same patterns for similar temporary flows. Could it be related to this https://github.com/Expensify/App/pull/29288/files#r1358416934? Can you try use cc @alitoshmatov if you are available to test |
cc: @s77rt |
I feel like it's some sort of race condition with updating a key in Onyx? Commenting this line out solves the issue. |
Removing that line looks reasonable and is not effecting expected behavior, and it tests well. |
Alternatively changing it to |
Nice. @thienlnam let's roll with that? |
I fixed my dev environment, sending a PR shortly. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-24. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Oof thanks for fixing, y'all 🙈 |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-25. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Should be all good here as the payment is being handled here, all other assignees here are internal - #29577 ! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.85-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
User should be automatically logged in and able to use the app on the original tab
Actual Result:
User must refresh the page to appear logged in and use the app
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6240754_1697559597054.bandicam_2023-10-16_23-47-40-706.mp4
MacOS: Desktop
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: