[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [CRITICAL] [P2P Activation] Improve KYC delay handling

[kevinksullivan]

Coming from https://expensify.slack.com/archives/C05RECHFBEW/p1697779604794959

Problem

When KYC is delayed during the wallet upgrade flow, a user lands on a loading page without any guidance. This can take a very long time, or potentially forever, if they hit certain errors.

Solution

To start, let's provide better guidance when KYC is delayed. If the wallet is still pending when the user completes KYC:

1. Land them back on the Wallet page
2. Hide the Enable wallet button while KYC is delayed and
3. Show the following message in the wallet tile: We're reviewing your information and will be in touch shortly

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

@kevinksullivan gonna reassign you as BZ since this is for wave8. Feel free to re-assign to whoever you think is best.

[MariaHCD]

BE PR that adds a new prop isPendingOnfidoResult to the wallet information is here: https://github.com/Expensify/Auth/pull/8991

The App will use this new prop to determine if we need to show the We're reviewing your information and will be in touch shortly message

[allroundexperts]

PR created.

[marcaaron]

Coming from #30093

I am wondering if we can combine the changes here with the case where Onfido fails. It might be better to have just one App PR and do a big E2E test to get it all out at once.

[marcaaron]

The App changes are here (not quite finished) but the redirect logic from @allroundexperts' PR is something I think we will also need when the delayed Onfido check comes back and the user can't proceed at all.

[allroundexperts]

I would agree that it makes sense to combine the two.

[MariaHCD]

I'm inclined to merge #30103 first (with No QA). Then we can follow it up with #30114 with a full E2E test. Although I think it's a bit tricky to simulate the different flows with Onfido...

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] feat: Improve KYC error handling #30103

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] feat: Improve KYC error handling #30103

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[marcaaron]

Either work for me. And yeah not really sure how to properly QA this on prod since we need Onfido to fail in two different ways 🙃

[kevinksullivan]

Payment summary:

• @allroundexperts $500

[JmillsExpensify]

$500 payment for @allroundexperts based on comment above.