[HOLD for payment 2023-11-02] [HOLD for payment 2023-11-01] [CRITICAL] [P2P Activation] Improve wallet enablement error handling and allow someone to retry their info once

[kevinksullivan]

context - https://expensify.slack.com/archives/C05RECHFBEW/p1697819082622369?thread_ts=1697779604.794959&cid=C05RECHFBEW

Problem

When a user fails certain checks during the wallet upgrade flow, they can sit on this page forever with no guidance on how to fix it.

Solution

In combination with this , let's improve error handling.

Once KYC is delayed, we will do this #30088

Then, for this GH, lets add:

1. If KYC / enablement is successful - update the Wallet UI to reflect wallet is activated, and send a notification from concierge so they are aware their wallet was activated.

• Copy: `Thanks for your patience! Your wallet has been enabled! You can now send and receive money on Expensify.

2. If KYC or some check fails after KYC was delayed - update the UI to show a non-enabled wallet, and send a notification from concierge that explains it failed but tells them they can try again one time.

• Copy: `There was an error when enabling your Expensify Wallet. You can try again here

3. If they fail KYC twice - hide the Enable wallet button, and add a message to the Wallet tile explaining they cannot move forward.

• Copy: Unfortunately your wallet cannot be enabled at this time. Please chat with Concierge for further assistance.

[marcaaron]

If KYC / enablement is successful - update the Wallet UI to reflect wallet is activated, and send a notification from concierge so they are aware their wallet was activated.

This one is easy.

If KYC or some check fails after KYC was delayed - update the UI to show a non-enabled wallet, and send a notification from concierge that explains it failed but tells them they can try again one time.

This one is less easy 😄

We handle the delayed check that happens here in Web-Secure. There is no error handling at all yet (nbd we can add that). But the catch is that we need to send the error via Pusher. A lot has changed about how we do updates so we will have to hack this together unless we want to move the Onfido webhook out of web-secure (I'd prefer not to do that if we can avoid it).

3. If they fail KYC twice - hide the Enable wallet button, and add a message to the Wallet tile explaining they cannot move forward.

Do we count attempts for this yet? Or is that something we want to add here? I would guess that some user level nvp called onfidoAttemptsCount would work for this.

[MariaHCD]

Do we count attempts for this yet? Or is that something we want to add here? I would guess that some user level nvp called onfidoAttemptsCount would work for this.

We don't count attempts just yet. But we can probably add that field in the wallet's additionalData instead of a user-level NVP?

[marcaaron]

We are down to just one more PR in Web-Secure here to close this one out and an App deploy (hopefully later today).
Web-E PR has been deployed to production and App PR has be CP'd to staging.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Prevent second attempts to activate wallet when Onfido checks fail #30114

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[marcaaron]

We don't count attempts just yet. But we can probably add that field in the wallet's additionalData instead of a user-level NVP?

Oh yeah that could work too! Great idea.

[marcaaron]

Hey @kevinksullivan can we create a new issue for "allow someone to retry their info once". I need an Onfido break 🥺

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Prevent second attempts to activate wallet when Onfido checks fail #30114

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

@marcaaron Huh... This is 4 days overdue. Who can take care of this?

[kevinksullivan]

can we create a new issue for "allow someone to retry their info once". I need an Onfido break 🥺

Will do!