Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash #30140

Closed
6 tasks done
lanitochka17 opened this issue Oct 21, 2023 · 89 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.88-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

  1. Open New Expensify app
  2. Log in with an expensifail account
  3. Create Split Bill with gmail accounts with which there was no conversation history before
  4. In the created group DM with these members, request the Split Bill again

Expected Result:

Re-creating Split Bill with anonymous gmail members should register IOU with no errors for both the re-request and the first

Actual Result:

Re-creating Split Bill with anonymous gmail members causes IOU to crash

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Windows: Chrome
Bug6245877_1697922883003.Recording_1_Desktop.mp4
MacOS: Desktop

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @youssef-lr
Issue OwnerCurrent Issue Owner: @youssef-lr
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pradeepmdk
Copy link
Contributor

pradeepmdk commented Oct 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash

What is the root cause of that problem?

Screenshot 2023-10-22 at 7 53 38 AM Screenshot 2023-10-22 at 7 56 06 AM Screenshot 2023-10-22 at 10 00 22 AM the root cause when we call `SplitBill` its throwing the error

What changes do you think we should make in order to solve the problem?

this is backend issue.
because first time we re calling SplitBillAndOpenReport after that we are personal details with real account id. then we are calling SplitBill with those id when create split from report

onemore issue when we call SplitBillAndOpenReport it will return personal details without login key.

@mountiny mountiny added Daily KSv2 Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 22, 2023
@mountiny
Copy link
Contributor

This is an backend issue so not App deploy blocker technically

@flodnv
Copy link
Contributor

flodnv commented Oct 23, 2023

@luacmartins @mountiny seems like you got this?

@mountiny
Copy link
Contributor

Yes, this PR should fix it https://github.com/Expensify/Web-Expensify/pull/39344

@mountiny
Copy link
Contributor

Or to be clearer this should have fixed it already https://github.com/Expensify/Web-Expensify/pull/39348 and the other pr is more of a clean up

@lanitochka17 @pradeepmdk can you please retest in staging

@pradeepmdk
Copy link
Contributor

@mountiny just now tested still there
Screenshot 2023-10-23 at 7 26 22 PM

@mountiny
Copy link
Contributor

@pradeepmdk do you need ot sign out and sign back in between the splits or you just do the request again right after it?

@pradeepmdk
Copy link
Contributor

@mountiny i just request again

@mountiny
Copy link
Contributor

@youssef-lr was debugging with Youssef and there are some other cases where this can fail due to the optimistic reports/ accountIDs, fix is underway

@flodnv flodnv assigned youssef-lr, luacmartins and mountiny and unassigned flodnv Oct 23, 2023
@youssef-lr
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
@saracouto saracouto added Monthly KSv2 and removed Weekly KSv2 labels Jun 7, 2024
@stephanieelliott stephanieelliott changed the title [HOLD #323235] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash [HOLD #357867] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash Jul 3, 2024
@stephanieelliott
Copy link
Contributor

Held now on https://github.com/Expensify/Expensify/issues/357867. I am going to be OOO til July 10 but not expecting much movement on this so will keep it assigned. If it needs attention in the meantime please reapply the BZ label

@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2024
@stephanieelliott
Copy link
Contributor

@youssef-lr
Copy link
Contributor

Still held

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@youssef-lr
Copy link
Contributor

This is paused

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
@youssef-lr youssef-lr changed the title [HOLD #357867] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash [HOLD] [LOW] [Splits] IOU - Re-creating Split Bill with anonymous gmail members causes IOU to crash Aug 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@stephanieelliott
Copy link
Contributor

@youssef-lr
Copy link
Contributor

Same

@youssef-lr
Copy link
Contributor

Same

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@stephanieelliott
Copy link
Contributor

Still held, looks like the blocking PR is moving though

@cead22
Copy link
Contributor

cead22 commented Nov 19, 2024

@davidcardoza should this be on the #billpay project?

@melvin-bot melvin-bot bot added the Overdue label Nov 22, 2024
@stephanieelliott
Copy link
Contributor

Seems like this has been fixed! Could not repro, split expense worked fine with no error or crash:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2
Projects
Status: Done
Development

No branches or pull requests