[$500] IOS - Request - Camera blinks when switching between tabs

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.90-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Issue found when executing PR #28792

Action Performed:

1. Go to + > Request money
2. Go to Scan and enable camera access if not allowed yet
3. Go to Distance, then Manual a few times
4. Go back to Scan

Expected Result:

The camera should not blink when switching between tabs

Actual Result:

Camera blinks when switching between tabs

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Staging:

Bug6249100_1698167102988.0-02-01-c1ba15d79bd9b53cf3056528c8a8e5eb86b1e7520a79a08e5f979466bc08cde3_4846e703b4ace5fc__1_.mp4

Production:

0-02-01-77ed3d9a6859e1c1b298814e92bf3c0ec9cc073350773a18f2731b529f70c7b5_e98c343e15be4769.1.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e1abb1d81693a85
• Upwork Job ID: 1717191476381212672
• Last Price Increase: 2023-11-01

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

maybe a regression from #28792

[lanitochka17]

@ishpaul777 You are right. Issue was found when executing PR #28792

[ishpaul777]

I can further investigate the root cause, but that would require app to builld on physical device (simulator dont have camera) Is there a resource I can follow to build app on Ios device I tried and failed to build in past, a few times, cc @dangrous

[dangrous]

So you're right on the cause, I'm wondering if it's a bug or just how phone cameras work - it's not actually blinking, it's just - for a second - showing the last image it saw before you navigated away. Like, point it at one thing, switch away, point it at another thing, and then switch back to the camera - you'll see the first thing for a second. I think it might just be the camera initializing again?

But maybe we could send it selectedTab just a second earlier, it looks like it might not be triggered until the tab is fully visible, rather than on press. If we could activate it earlier then maybe it could work.

Also cc @dukenv0307 @mountiny @mananjadhav who worked on that PR because I know very little about cameras.

@ishpaul777 I think you can build for a physical device via XCode? I'm not sure if that requires any special access or anything

[mananjadhav]

This is bit of a bummer because I couldn’t this on iOS physical device myself.

I can see the issue right now, but I am afk and I am not sure if I can confirm the exact behavior as of now.

[dangrous]

Confirmed not a blocker, we should still look into this though! It looks like the new code activates the camera later than it used to - so only when the camera is fully in view, rather than as soon as the button is pressed, or as soon as the scroll begins. So we should figure out a way to get that activated earlier, without undoing the fix made in #28792

[sonialiap]

Sounds like an external issue, adding label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e1abb1d81693a85

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[mountiny]

I agree this is not a blocker, I have seen the blink but I have seen that in previous versions too @dukenv0307 I think this should be handled as a regression from your PR though as it apprently introduced it cc @sonialiap

[sonialiap]

@mountiny we'll want to fix this in #27879 and then pay the reporter, is that correct?

[dangrous]

Yeah I think ideally @dukenv0307 and @mananjadhav would take care of this as a regression (or at least an improvement) from #27879 - let me know if you think differently @mountiny

[mananjadhav]

I agree we can take this as an improvement from the previous PR. But we would still need help to test it on IOS.

@dukenv0307 can we please work on the follow up PR?

[situchan]

I can help testing. I can install app on iOS physical device

[mountiny]

I agree this should be treated as a regression and so we could also close this issue, pay the reporter first but handle this in the original issue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dangrous]

Okay cool, that works for me. Closing! I just commented on the main issue with these details.