IOU - Manual IOU amount doubles after requesting

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.93-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in
3. Click on the FAB button
4. Click on the "Request money" button
5. Click on the "Manual" button
6. Enter any amount
7. Click on the "Next" button
8. Enter an email address
9. Click on it
10. Click on the "Request" button

Expected Result:

The requested amount should be the one I entered

Actual Result:

After half a second, the requested amount doubles

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

Bug6257229_1698692932102.bandicam_2023-10-30_19-36-21-793.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tylerkaraszewski]

I've confirmed this happens.

[tylerkaraszewski]

@s77rt - do you have any insight here?

[cryptosheepself]

I am currently seeing a trail, is there a bounty for this on upwork? I believe I can get this fixed in a few hours.

[melvin-bot]

📣 @cryptosheepself! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[s77rt]

@tylerkaraszewski This may be a backend bug. Is it expected that money requests return both nonReimbursableTotal and total set to the user's requested amount? cc @grgia

[Beamanator]

@cryptosheepself yes, if you help diagnose the problem & suggest a solution that we go with, you will be compensated - but, as normal, if we don't agree with your solution, we may not compensate

@s77rt if you're right, do you see somewhere in App that we're adding the two?

[Beamanator]

It looks like we're purposefully storing total and nonReimbursableTotal in Onyx in this PR (see test steps) so I'd guess yes, we do expect to return both

[s77rt]

@Beamanator Yes and it's expected to add the two based on the linked PR

App/src/libs/ReportUtils.js

Line 1443 in a31933a

const totalDisplaySpend = nonReimbursableSpend + reimbursableSpend;

[Beamanator]

Ya very interesting - lets try to confirm w/ onyx values from a real example

[grgia]

Just to clarify, we only add the two for spend total, not for the reimbursable total that a user would owe.

[Beamanator]

The issue seems to be resolved for me, I'm confident moving forward with the deploy with this fix 👍

Screen.Recording.2023-10-31.at.10.52.01.PM.mov