[Wave 6: Workspace Chats] GBR shown on chats that shouldn't have them

[iwiznia]

Context https://expensify.slack.com/archives/C049HHMV9SM/p1698924304893529

Happening on staging web, but not on prod.
I have 2 chats with GBR and nothing to do on them.
@vitHoracek pointed out it is probably due to this change https://github.com/Expensify/App/pull/30655/files#diff-3258457b3b73b3f6fde322dfd4d925501f57daeee25e2ae30e671a53460aa06cR249 in App, but that the real bug is probably in the backend.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

The PR we could revert is this one #30655 but waiting on @puneetlath to chime in

[puneetlath]

Two problems:

1. We set hasOutstandingChildRequest for IOU reports with a total of $0
2. There exist old IOU reports that don't have a parentReportActionID so they don't show up in the DM even though they exist

[puneetlath]

Both are back-end issues.

[puneetlath]

I'm removing the deploy blocker label since this is actually an Auth issue.

[puneetlath]

https://github.com/Expensify/Auth/pull/9110 is merged. I'll look into the ghost IOUs tomorrow!

[melvin-bot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

Auth PR got deployed. Will look into the orphans next.

[puneetlath]

For the orphan IOUs, I want to first just determine the scale of the problem. Query request here: https://github.com/Expensify/Expensify/issues/333810

[puneetlath]

There are 31,762 distinct reports that have a parentReportID but no parentReportActionID 🤦🏾

[puneetlath]

Ok it seems that we do currently create reports that have a parentReportID an not a parentReportActionID in some flows. I looked at the example here and it seems to be a free plan report created on OldDot.

So we need to decide what to do. Options:

1. Don't set the GBR if there isn't both a parentReportID AND parentReportActionID
2. Update all flows to set both parentReportID AND parentReportActionID and then do some sort of migration for the old ones
3. Something else

[puneetlath]

It doesn't seem like anyone is experiencing this anymore since we made the update to ignore $0 reports. So I think we can close this out. Feel free to reopen if I'm mistaken!