[HOLD for payment 2023-11-13] [$500] LHN - Green dot for money request is still displayed in spite of having deleted the workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.95-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Pre-requisite: user must have created a workspace and have made a money request from another account (account B) to that workspace.

1. Go to Settings.
2. Tap on "Workspaces".
3. Select the workspace where the money request have been made.
4. Tap on the three dots menu.
5. Tap on "Delete workspace" and confirm.
6. Return to LHN.

Expected Result:

The green dot on the workspace chat with account B should disappear.

Actual Result:

The green dot on the workspace chat with account B is still displayed in spite of having deleted the workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6261821_1698993555347.Ndnz7344_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0101e78cc19704d3a6
• Upwork Job ID: 1720360448725458944
• Last Price Increase: 2023-11-03
• Automatic offers:
• tienifr | Contributor | 27502261

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0101e78cc19704d3a6

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - Green dot for money request is still displayed in spite of having deleted the workspace

What is the root cause of that problem?

We enable show green dot in

App/src/components/LHNOptionsList/OptionRowLHN.js

Line 119 in 85aad61

const shouldShowGreenDotIndicator = !hasBrickError && ReportUtils.requiresAttentionFromCurrentUser(optionItem, optionItem.parentReportAction);

but in requiresAttentionFromCurrentUser function we did not check if it's the archived room

What changes do you think we should make in order to solve the problem?

Add these lines to return false if it's the archived room

    if (isArchivedRoom(option)) {
        return false;
    }

below

App/src/libs/ReportUtils.js

Lines 1421 to 1424 in 85aad61

	if (!option) {
	return false;
	}

[s-alves10]

Looks like a regression of this PR
This PR added the following condition

App/src/libs/ReportUtils.js

Lines 1437 to 1440 in 85aad61

	// Has a child report that is awaiting action (e.g. approve, pay, add bank account) from current user
	if (option.hasOutstandingChildRequest) {
	return true;
	}

The function returns true here

I think we need to update

App/src/libs/ReportUtils.js

Lines 1425 to 1427 in 85aad61

	if (isArchivedRoom(getReport(option.parentReportID))) {
	return false;
	}

to

    if (isArchivedRoom(getReport(option.parentReportID)) || isArchivedRoom(getReport(option.reportID))) {
        return false;
    }

[Beamanator]

Thanks for your two very quick proposals! @tienifr since you submitted first, let's go with your fix please - can you please submit a PR & test ASAP? 🙏

[tienifr]

Yes

[tienifr]

@Beamanator Can you pls assign me and I will raise the PR

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Beamanator]

@thesahindia FYI i think this is going to be a small enough PR that we shouldn't need a C+ to review 🙏

[Beamanator]

Fix should be working in staging, NAB

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.95-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: Green dot for money request is still displayed in spite of having deleted the workspace #30830

If no regressions arise, payment will be issued on 2023-11-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cristipaval] The PR that introduced the bug has been identified. Link to the PR:
• [@cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tienifr] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cristipaval]

This was a deploy blocker found by running the regression tests, so there's no need to create/update anything. Melvin already automatically commented on the offending PR.

[cristipaval]

@peterdbarkerUK, the only payment due here is for @tienifr as the contributor who fixed the issue.

[peterdbarkerUK]

Paid and job closed, thanks @tienifr

• Paid @tienifr $500 for contributor role.