fixes the issue #29379 #30864

ishpaul777 · 2023-11-03T17:27:59Z

Details

This PR fixed the opening of Plus option popover in report details page, now opening of Plus button options is ignored when navigation is in progress. We used withNavigationFocus HOC to get isFocused prop which tells if screen is not focused(navigating in progress)
ans onPress of plus button we can early return if isFoucused is false, the same ^ needs to be implemented for Emojipicker Popover.

Same as ^, is implemented for Emoji popover we ignore the press of emojibutton if navigation is progress.

Note: if first emojipopover is opened and then we click of header to navigate(we have to really fast not a case user may face in real use case) to details page it will not close the popover because Emojipicker dont have a navigation context we can't use withNavigationFocus HOC.

Fixed Issues

$ #29379
PROPOSAL: #29379 (comment)

Tests

Verify that no errors appear in the JS console

Open any report.
Tap on report header and quickly on plus icon verify popover not opens in details page
Tap on report header and quickly on emoji popover verify emoji popover not opens in details page
Tap plus icon and quickly tap the header verify popover closes as soon user is navigated to details page

Offline tests

QA Steps

Verify that no errors appear in the JS console

Open any report.
Tap on report header and quickly on plus icon verify popover not opens in details page
Tap on report header and quickly on emoji popover verify emoji popover not opens in details page
Tap plus icon and quickly tap the header verify popover closes as soon user is navigated to details page

PR Author Checklist

Screenshots/Videos

Android: Native

VIDEO-2023-11-08-15-52-19.mp4

Android: mWeb Chrome

VIDEO-2023-11-03-22-29-27.mp4

iOS: Native

Screen.Recording.2023-11-08.at.4.18.14.PM.mov

iOS: mWeb Safari

trim.17C6E0E5-5668-4933-8FEA-5382BFA2F854.MOV

MacOS: Chrome / Safari

Screen.Recording.2023-11-03.at.5.52.29.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-08.at.3.55.41.PM.mov

ishpaul777 · 2023-11-03T17:40:04Z

hii @eVoloshchak , I think we need to kick off adhoc build because its really hard to test changes on simulator and we may not be able test properly issue occurs only 1/10 time using emulator. Wdyt? 👍 or 👎

melvin-bot · 2023-11-03T17:40:20Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js

eVoloshchak · 2023-11-05T15:43:50Z

Works well, there are a couple of small changes needed for the comments and the author checklist isn't finished yet
upd: also take a look at performance test failing

…MenuItems.js Co-authored-by: Eugene Voloshchak <[email protected]>

ishpaul777 · 2023-11-05T16:00:23Z

Performance test failing is unrelated to this pr changes and can be noticed in other PRs - https://expensify.slack.com/archives/C01GTK53T8Q/p1699092552897839

eVoloshchak · 2023-11-05T21:54:53Z

I think we need to kick off adhoc build because its really hard to test changes on simulator and we may not be able test properly issue occurs only 1/10 time using emulator. Wdyt? 👍 or 👎

That is a great idea!
Just add "Ready To Build" label to the PR, it should do the trick

ishpaul777 · 2023-11-06T08:10:13Z

I can't add the label we may need help from internal engineer, Can you approve code changes so a internal engineer is assigned.

eVoloshchak · 2023-11-06T12:58:48Z

@NikkiWines, this isn't ready for your review yet, could you please add "Ready To Build" label to this PR so we can test this on physical devices?

eVoloshchak · 2023-11-07T12:32:51Z

Huh, that didn't work
Based on this discussion

you have to start it manually iirc, see https://stackoverflowteams.com/c/expensify/questions/15778/15779
Try https://github.com/Expensify/App/actions/workflows/testBuild.yml > Run workflow

@NikkiWines, could you see if you can trigger the build process manually? Thanks

NikkiWines · 2023-11-07T21:14:42Z

done! Might take a lil' while to complete

OSBotify · 2023-11-07T21:47:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/30864/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/30864/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/30864/NewExpensify.dmg	https://30864.pr-testing.expensify.com

ishpaul777 · 2023-11-07T22:06:40Z

Getting this error while installing ios app, do i need to follow specific steps?

eVoloshchak · 2023-11-07T22:25:09Z

@ishpaul777, I don't think there is a way for non-internal engineers to run AdHoc builds on iOS (we'd have to add UUID for each device manually)

You can run native iOS on a physical device in dev (or just build it yourself if you have a paid apple dev account), but this allows us to test mWeb on physical devices

ishpaul777 · 2023-11-08T10:44:16Z

@eVoloshchak can you complete checklist when you get chance! Thanks!

eVoloshchak · 2023-11-08T17:03:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

screen-20231108-175510.mp4

Android: mWeb Chrome

screen-20231108-175333.mp4

iOS: Native

RPReplay_Final1699462749.MP4

iOS: mWeb Safari

RPReplay_Final1699462945.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-11-08.at.17.50.43.mov

MacOS: Desktop

Screen.Recording.2023-11-08.at.18.08.00.mov

eVoloshchak

LGTM

ishpaul777 · 2023-11-10T22:55:48Z

@NikkiWines Please review when you get chance Thanks!

NikkiWines

Looks good and tests well - sorry for the delay!

OSBotify · 2023-11-10T23:52:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-14T22:11:09Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:54:25Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T21:09:57Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fixes the issue Expensify#29379

dd435be

ishpaul777 marked this pull request as ready for review November 3, 2023 17:40

ishpaul777 requested a review from a team as a code owner November 3, 2023 17:40

melvin-bot bot requested review from eVoloshchak and removed request for a team November 3, 2023 17:40

eVoloshchak suggested changes Nov 5, 2023

View reviewed changes

ishpaul777 and others added 3 commits November 5, 2023 21:17

Update src/pages/home/report/ReportActionCompose/AttachmentPickerWith…

c063547

…MenuItems.js Co-authored-by: Eugene Voloshchak <[email protected]>

Update src/pages/home/report/ReportActionCompose/AttachmentPickerWith…

461e274

…MenuItems.js Co-authored-by: Eugene Voloshchak <[email protected]>

Update src/pages/home/report/ReportActionCompose/AttachmentPickerWith…

9d959fa

…MenuItems.js Co-authored-by: Eugene Voloshchak <[email protected]>

eVoloshchak approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from NikkiWines November 6, 2023 12:57

NikkiWines added the Ready To Build label Nov 6, 2023

Merge branch 'Expensify:main' into fix/29379

a938f08

ishpaul777 requested a review from eVoloshchak November 8, 2023 10:26

eVoloshchak approved these changes Nov 8, 2023

View reviewed changes

NikkiWines approved these changes Nov 10, 2023

View reviewed changes

NikkiWines merged commit 7a36213 into Expensify:main Nov 10, 2023
18 of 19 checks passed

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

melvin-bot bot mentioned this pull request Nov 15, 2023

[HOLD for payment 2023-12-28] [HOLD for payment regression] [$500] Conversation - In group details page, plus options are shown #29379

Closed

6 tasks

OSBotify mentioned this pull request Nov 15, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

dukenv0307 mentioned this pull request Nov 16, 2023

[HOLD for payment 2023-11-27] [$500] Chat - Keyboard is displayed on header menu screen after sending a file larger than 24 MB #31426

Closed

6 tasks

situchan mentioned this pull request Nov 16, 2023

fix "Chat - Keyboard is displayed on header menu screen after sending a file larger than 24 MB" #31457

Merged

47 tasks

tienifr mentioned this pull request Dec 23, 2023

[Payment due 03-04][$500] Menu - Pin & Delete request appear on Receipt image when quickly tap on receipt and 3-Dot menu #33541

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes the issue #29379 #30864

fixes the issue #29379 #30864

ishpaul777 commented Nov 3, 2023 •

edited

Loading

ishpaul777 commented Nov 3, 2023

melvin-bot bot commented Nov 3, 2023

eVoloshchak commented Nov 5, 2023 •

edited

Loading

ishpaul777 commented Nov 5, 2023

eVoloshchak commented Nov 5, 2023

ishpaul777 commented Nov 6, 2023

eVoloshchak commented Nov 6, 2023

eVoloshchak commented Nov 7, 2023

NikkiWines commented Nov 7, 2023

OSBotify commented Nov 7, 2023

ishpaul777 commented Nov 7, 2023

eVoloshchak commented Nov 7, 2023

ishpaul777 commented Nov 8, 2023

eVoloshchak commented Nov 8, 2023 •

edited

Loading

eVoloshchak left a comment

ishpaul777 commented Nov 10, 2023

NikkiWines left a comment

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 15, 2023

fixes the issue #29379 #30864

fixes the issue #29379 #30864

Conversation

ishpaul777 commented Nov 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ishpaul777 commented Nov 3, 2023

melvin-bot bot commented Nov 3, 2023

eVoloshchak commented Nov 5, 2023 • edited Loading

ishpaul777 commented Nov 5, 2023

eVoloshchak commented Nov 5, 2023

ishpaul777 commented Nov 6, 2023

eVoloshchak commented Nov 6, 2023

eVoloshchak commented Nov 7, 2023

NikkiWines commented Nov 7, 2023

OSBotify commented Nov 7, 2023

ishpaul777 commented Nov 7, 2023

eVoloshchak commented Nov 7, 2023

ishpaul777 commented Nov 8, 2023

eVoloshchak commented Nov 8, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

ishpaul777 commented Nov 10, 2023

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

OSBotify commented Nov 15, 2023

ishpaul777 commented Nov 3, 2023 •

edited

Loading

eVoloshchak commented Nov 5, 2023 •

edited

Loading

eVoloshchak commented Nov 8, 2023 •

edited

Loading