Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] When scrolling backwards the messages with longer chats stuck and need to scroll forward #30895

Closed
1 of 6 tasks
m-natarajan opened this issue Nov 5, 2023 · 20 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.95-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699164509427949

Action Performed:

  1. Open a chat with long chats
  2. Scroll backwards quickly

Expected Result:

Messages should load without stuck

Actual Result:

If I scroll backwards very quickly, it will get "stuck" -- and I need to scroll forward and then backwards again to get it to load the new page. I think it might be that it loads one previous page at a time, and if I scroll quickly enough to get to the top of that page's "skeleton" before it displays, then it doesn't register me being at the top of it. I need to scroll down to the "next" page, and then scroll back to the "previous" before it gets the one before. I would expect it should never get stuck while scrolling backwards.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.202.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc47a9e2814684af
  • Upwork Job ID: 1721284239551279104
  • Last Price Increase: 2023-11-05
  • Automatic offers:
    • jjcoffee | Reviewer | 27539278
@m-natarajan m-natarajan added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 5, 2023
@melvin-bot melvin-bot bot changed the title When scrolling backwards the messages with longer chats stuck and need to scroll forward [$500] When scrolling backwards the messages with longer chats stuck and need to scroll forward Nov 5, 2023
Copy link

melvin-bot bot commented Nov 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01dc47a9e2814684af

Copy link

melvin-bot bot commented Nov 5, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 5, 2023
Copy link

melvin-bot bot commented Nov 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 5, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

Copy link

melvin-bot bot commented Nov 6, 2023

📣 @MADahab! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@MADahab
Copy link

MADahab commented Nov 6, 2023

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01e9559f2b6e4404cf

I had a similar issue but it was related to posts not chats but it might be the same idea if the reason is as u state that it loads one previous page at a time,
I came with a workaround that i had the first page that it is always rendered, and when ever the user scrolls down and load the next posts i add the new posts to the same page that is rendered.
In your case you can make state that has the first page or array of chats (depending on your Implementation) and when ever new chats load add them to this state, so now all chats are cached in the rendered state. and when scrolling back you wont need to reload them.
Hope it helps

Copy link

melvin-bot bot commented Nov 6, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@perunt
Copy link
Contributor

perunt commented Nov 6, 2023

👋🏻

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@mallenexpensify
Copy link
Contributor

As the assigned BZ, I'm going to 'hang tight' as this has been addressed and worked on before. Per the slack chat, @perunt has experience/knowledge here so I'll wait til they post and follow along.

@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

@mallenexpensify, @jjcoffee, @perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
Copy link

melvin-bot bot commented Nov 10, 2023

@mallenexpensify, @jjcoffee, @perunt Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify
Copy link
Contributor

@perunt is there plan here that you'll submit a proposal and @jjcoffee will review, like normal?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 10, 2023
@mallenexpensify
Copy link
Contributor

@perunt , can you provide an update please?

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2023
@perunt
Copy link
Contributor

perunt commented Nov 14, 2023

Hey there! Sorry for getting back to you late.
We've got a PR ready with the fix.
But there's still a bit more to look into, so we're going to keep digging into this.

Copy link

melvin-bot bot commented Nov 21, 2023

@mallenexpensify, @jjcoffee, @perunt Still overdue 6 days?! Let's take care of this!

@jjcoffee
Copy link
Contributor

Unassigning since I don't think I'm needed here!

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2023
@jjcoffee jjcoffee removed their assignment Nov 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
Copy link

melvin-bot bot commented Nov 26, 2023

@mallenexpensify @perunt this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@perunt
Copy link
Contributor

perunt commented Nov 26, 2023

It was resolved with #31288
can we close it?

@melvin-bot melvin-bot bot removed the Overdue label Nov 26, 2023
@mallenexpensify
Copy link
Contributor

I tested, it appears to be resolved. There are times where, when scrolling up fast, it lags for a moment before the chats populate, I think that's expected behaviour. @quinthar if you continue to encounter, please comment and reopen the GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

5 participants