[HOLD for payment 2023-12-01] [$500] Web – Login – New dot opens when navigate to the staging magic link, not abracadabra page.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create new account
3. Copy the Magic link and change it to staging
4. Open a new tab and navigate to the staging magic link

Expected Result:

Verify the abracadabra page is displayed

Actual Result:

New dot opens when navigate to the staging magic link, not abracadabra page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267091_1699351294403.not_abracadabra_page.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01941d72fc174377c3
• Upwork Job ID: 1721864049513623552
• Last Price Increase: 2023-11-07
• Automatic offers:
• tienifr | Contributor | 27561155
• situchan | Contributor | 27561514

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01941d72fc174377c3

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web – Login – New dot opens when navigate to the staging magic link, not abracadabra page

What is the root cause of that problem?

In

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/index.js

Line 71 in b4ee8c4

routes: [...otherRoutes, ...limitedReportRoutes, ...rhpRoutes],

we change the order of routes.

In this case, the original order of state.routes is [Home, CenterPanelNavigator, ValidateLogin], but the routes after this logic is [Home, ValidateLogin, CenterPanelNavigator]

-> The report screen is shown (last item is routes is CenterPanelNavigator)

What changes do you think we should make in order to solve the problem?

We should preserve the order of routes. In order to do that we can change the logic of splitRoutes

to

function splitRoutes(routes) {
    const result = []
    let count = 0;
    routes.forEach((route) => {
        if (route.name === NAVIGATORS.CENTRAL_PANE_NAVIGATOR) {
            if(count<3){
                result.push(route);
                count++;
            }
        } 
     else {
            result.push(route);
        }
    });

    return result
}

and change stateToRender

to

    const stateToRender = useMemo(() => {
        const result = splitRoutes(state.routes);

        return {
            ...state,
            index: result.length - 1,
            routes: [...result],
        };
    }, [state]);

Result

Screen.Recording.2023-11-07.at.21.18.58.mov

[mountiny]

@tienifr @nkuoch that change looks good to me, lets go with it

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@tienifr given this is a deploy blocker, can you please make sure to make a PR quickly

Adding @situchan as you have been a reviewer on the offending PR, thanks!

[tienifr]

The PR is up

[mountiny]

This still needs to be CPed @nkuoch

[melvin-bot]

This issue has not been updated in over 15 days. @nkuoch, @CortneyOfstad, @situchan, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

The automation failed here, @CortneyOfstad can you please pay $500 to @tienifr and @situchan

[CortneyOfstad]

@situchan it is showing in Upwork that it is waiting for you to accept. Please let me know once you complete that — thanks!

[CortneyOfstad]

Alright, both payments are completed! Payment breakdown is below:

Payment Summary

• @tienifr (contributor) — paid $500 via Upwork
• @situchan (reviewer) — paid $500 via Upwork