-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] fix: 30988 New dot opens when navigate to the staging magic link, not abracadabra page #31014
Conversation
… abracadabra page
@@ -60,15 +59,12 @@ function ResponsiveStackNavigator(props) { | |||
}); | |||
|
|||
const stateToRender = useMemo(() => { | |||
const {reportRoutes, rhpRoutes, otherRoutes} = splitRoutes(state.routes); | |||
|
|||
// Remove all report routes except the last 3. This will improve performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep this comment but just move to here
This is specific issue where Test step and QA step cannot be same. Can you update Test step? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2023-11-08.at.12.01.55.AM.movMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/nkuoch in version: 1.3.96-6 🚀
|
fix: 30988 New dot opens when navigate to the staging magic link, not abracadabra page (cherry picked from commit 217b2cf)
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.3.96-10 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀
|
🚀 Deployed to staging by https://github.com/nkuoch in version: 1.3.98-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀
|
Details
Amount not show when split bill in offline mode. This PR fixes that.
Fixed Issues
$ #30988
PROPOSAL: #30988 (comment)
Tests
Offline tests
Same as Tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2023-11-08.at.00.13.57.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-07.at.21.18.58.mov
MacOS: Desktop