Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description #31217

Closed
6 tasks done
kbecciv opened this issue Nov 10, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on fab
  3. Tap assign task
  4. Enter title and tap next
  5. Select share somewhere
  6. Tap confirm task
  7. Tap description
  8. Enter # 456
    fgjjjh
  9. Tap save

Expected Result:

When strikethrough markdown is entered, same strikethrough markdown must be displayed in task description.

Actual Result:

When strikethrough is entered, the markdown is displayed incorrectly in the task description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271903_1699655121670.steike.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 10, 2023
@kbecciv
Copy link
Author

kbecciv commented Nov 10, 2023

Not reproduce in production

VID_20231111_033841.mp4

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aimane-chnaif
Copy link
Contributor

This came from #27414. I think better to revert as it caused couple regressions (this one and #31199)
@chiragsalian do you agree?

@chiragsalian
Copy link
Contributor

thank you for that @aimane-chnaif.
Yeah i think a revert would be nice because i don't want to rush a quick fix and break more things. I'll test and prepare a revert PR.

@aimane-chnaif
Copy link
Contributor

ok, happy to review and test PR

@chiragsalian
Copy link
Contributor

The revert PR to review is here - #31219. I'll clean it up in the meantime.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 13, 2023
@chiragsalian
Copy link
Contributor

oops this is resolved.

@mallenexpensify
Copy link
Contributor

Reopened so I can resolve payment. Give me a min to do so @aimane-chnaif

@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 labels Nov 13, 2023
@mallenexpensify mallenexpensify changed the title Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description Nov 13, 2023
@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Nov 13, 2023
@mallenexpensify
Copy link
Contributor

@aimane-chnaif, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0118c655b415acc399

Pay is $500 for C+ review on deploy blockers
image

@aimane-chnaif
Copy link
Contributor

@mallenexpensify accepted thanks

@mallenexpensify
Copy link
Contributor

Contributor+: @aimane-chnaif paid $500 via Upwork.
Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 14, 2023
@melvin-bot melvin-bot bot changed the title [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description [HOLD for payment 2023-11-21] [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description Nov 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 14, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-21] [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description [HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] [Payment due meow] Task - Description - When strikethrough is entered, the markdown is displayed incorrectly in the task description Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants