-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invisible characters in forms v2 #31259
Handle invisible characters in forms v2 #31259
Conversation
This reverts commit 2045847.
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Please add some more test cases with multiple new lines |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb1.movweb2.movweb3-multiline.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not catching multiline case earlier.
LGTM
Actually, I was pretty sure I'd tested this case, but maybe it stopped working after some changes :( Also sorry for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.99-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.0-0 🚀
|
I wrote this at the start of the Form migration. Now, many of the forms have been already migrated. So I don't think that we have to treat it specially, just cover as many forms as possible. Here is an issue with the currently migrated components and QA tests (in the PRs). |
Details
It is a fixed version of this PR which was reverted.
This PR handles invisible characters in the required fields, to prevent users from creating an i.g. workspace name with only invisible characters.
We:
Fixed Issues
$ #23297
PROPOSAL: #23297 (comment)
Updated version fixes a regression related to new lines:
Tests
isEmptyString
function,removeInvisibleCharacters
function.
Offline tests
N/A
QA Steps
Name
fieldMy workspace 123
)\u200D
), you can use this tool to copy it (paste the character in the JS/Java/C section, click Convert, and then Copy in Characters section)\u200D
) (should be able to save, but the name will be treated as empty)PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-13.at.11.28.28.mov
Android: mWeb Chrome
Screen.Recording.2023-11-13.at.11.29.50.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-13.at.11.25.43.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-13.at.11.27.40.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov