[MEDIUM] VBA Refactor: Update the order of Bank Account flow steps for NewDot flow

[mountiny]

Part of the project

Coming from Update the VBBA setup flow to new design system design doc (parent issue).

Update the BE flow of the bank account flow to support the new order of steps.

The new flow can be visually seen in the design section of the design doc https://docs.google.com/document/d/1t8_Fn93LSSU4gG4z7WRt8IFcpSGK4TIe4QamdcTXjxE/edit#bookmark=id.3slfop5gy3im

Feature Description

The steps are:

1. Connect bank account - BankAccountStep
2. Personal Info step
3. Business info step
4. Onfido verification
5. Beneficial Owner step
6. Complete verification

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0102ed6ddd4ffeda88
• Upwork Job ID: 1724757479449100288
• Last Price Increase: 2023-11-15

Issue Owner

Current Issue Owner: @nkuoch

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0102ed6ddd4ffeda88

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @robertKozik (Internal)

[shubham1206agra]

@mountiny Can you assign me here?

[mountiny]

This will be only backend change I dont think there will be anything requried here, but I will assign you

[adelekennedy]

@nkuoch any updates here?

[nkuoch]

Taking advantage of this issue to also do https://github.com/Expensify/Expensify/issues/336685 at the same time - which requires a big refactor, but is needed anyway, especially now that we're moving the company step as the 3rd step of the flow.
We want to be able to start saving the bank account in db right from the bank account step - we don't want to have to wait the 3rd step to do it.
I expect the 1st auth PR to be ready for review tomorrow.
Related Web and App PRs are in progress. I need at least 1 more week to finish them all.

[nkuoch]

Refactored auth 1:1:1 commands for bankAccount, company and requestor steps (merged). Now adding new auth commands for Onfido and BeneficialOwner steps. Still updating WIP Web and App PRs at the same time to test my changes.

[nkuoch]

Had to focus on KYC docs last week. Working back on vba refactor this week.

[nkuoch]

Still in progress, getting there.
All substeps have been implemented and merged in the feature branch.
All my back end refactoring to allow 1:1:1 architecture and other step ordering and saving in db at each step has been deployed.
Holding on some TS refactoring and then will merge my #33838.

[melvin-bot]

This issue has not been updated in over 15 days. @nkuoch, @shubham1206agra, @adelekennedy eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

I believe this one was done