-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new vbba 111 commands and swap order of company step and requestor steps #33838
Conversation
9f4dad5
to
ff47eb8
Compare
e7955ce
to
03e4b05
Compare
Things I noticed that can be tackled in a follow up PR:
|
262fb57
to
9b7d412
Compare
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@nkuoch Can you change the target branch to https://github.com/barttom/App-expensify/tree/vit-tieredBankAccountFlow? |
@mountiny Do I need to review this now or in the final PR? |
@shubham1206agra lets just merge and then let @barttom sync with the branch |
Fixed Issues
Part of #30442
$ #31357
Attach vbba logic to new 1:1:1 backend with new ordering + some refactoring and bug fixes.
Tests
See comments below. More tests and review will be made in the parent PR.
#33838 (comment)