Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new vbba 111 commands and swap order of company step and requestor steps #33838

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

nkuoch
Copy link
Contributor

@nkuoch nkuoch commented Jan 2, 2024

Fixed Issues

Part of #30442
$ #31357
Attach vbba logic to new 1:1:1 backend with new ordering + some refactoring and bug fixes.

Tests

See comments below. More tests and review will be made in the parent PR.

#33838 (comment)

@nkuoch nkuoch changed the title Use new vbba 111 commands and swap order of company step and requesto… Use new vbba 111 commands and swap order of company step and requestor steps Jan 2, 2024
@nkuoch nkuoch force-pushed the nat-vbba111 branch 2 times, most recently from 9f4dad5 to ff47eb8 Compare January 2, 2024 18:49
@nkuoch nkuoch self-assigned this Jan 9, 2024
@nkuoch nkuoch force-pushed the nat-vbba111 branch 8 times, most recently from e7955ce to 03e4b05 Compare January 11, 2024 17:32
@nkuoch
Copy link
Contributor Author

nkuoch commented Jan 12, 2024

Tested adding a VERIFYING business bank account.

Clicked on workspace > BankAccount.
image

BankAccount step

Via Plaid Chase Checking
image

image

It then displayed the manual form as Plaid Chases returns substitute account numbers. Entered 011401533 and 1111222233330000

image image

Confirmed and reached the requestor step.

Requestor step

Entered by names
image

Entered my dob
image

Entered my SSNLast4
image

Entered my address
image

Doubled checked and confirmed
image

Reached Onfido step.

Onfido step

image

Clicked on Passport and did the flow on my mobile (pic of id and live video)
image

Then submitted the verification and reached Company step

Company step

Entered my company name
image

Entered my tax ID
image

Entered my website
image

Entered my company phone number
image

Entered my company address
image

Entered my company type
image

Entered date
image

Entered state
image

Doubled checked everything and confirmed
image

Reached BeneficialOwners step

BeneficialOwners step

image image

Added a beneficial owner
image

image image image

Double checked

image image image

ACHContract step

image

@nkuoch
Copy link
Contributor Author

nkuoch commented Jan 12, 2024

Things I noticed that can be tackled in a follow up PR:

  • When entering a beneficial owner, reaching the confirm view, reloading page forgets about it and we have to re-enter the info
  • At the end, clicking on "Let's finish in chat" doesn't do anything
  • After connecting via Plaid, we show briefly the previous view before actually showing the "Choose an account" view.
  • Can't edit any info from confirm view once it's been added in db

@nkuoch
Copy link
Contributor Author

nkuoch commented Jan 12, 2024

Tested adding a PENDING business bank account.

Clicked on Connect Manually. Entered 011401533 and 1111222233330000
Name: Alberta Charleson
SSN: 3333

Onfido got skipped because we used test data

Company name: Alberta Bobbeth Charleson
TaxID: 123456789

Made sure I reached the Validate step:
image

@nkuoch
Copy link
Contributor Author

nkuoch commented Jan 12, 2024

Tested adding an OPEN business bank account

Clicked on Connect with Plaid. Used TD Bank, user_good, pass_good, Plaid Saving.

Name: Alberta Charleson
SSN: 3333

Onfido got skipped because we used test data

Company name: Alberta Bobbeth Charleson
TaxID: 123456789

Made sure I reached the validated view
image

(Not sure why we always reach this view though, as my primary email address I used wasn't from a public domain. Same behaviour in prod though I believe)

@nkuoch nkuoch force-pushed the nat-vbba111 branch 3 times, most recently from 262fb57 to 9b7d412 Compare January 12, 2024 11:46
@nkuoch nkuoch marked this pull request as ready for review January 12, 2024 11:50
@nkuoch nkuoch requested a review from a team as a code owner January 12, 2024 11:50
@melvin-bot melvin-bot bot requested review from shubham1206agra and removed request for a team January 12, 2024 11:50
Copy link

melvin-bot bot commented Jan 12, 2024

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Jan 16, 2024

@nkuoch Can you change the target branch to https://github.com/barttom/App-expensify/tree/vit-tieredBankAccountFlow?

@nkuoch
Copy link
Contributor Author

nkuoch commented Jan 16, 2024

I can't because it's a fork.
image
image

@shubham1206agra
Copy link
Contributor

@mountiny Do I need to review this now or in the final PR?

@mountiny
Copy link
Contributor

@shubham1206agra lets just merge and then let @barttom sync with the branch

@mountiny mountiny merged commit 322ed33 into vit-tieredBankAccountFlow Jan 16, 2024
13 of 15 checks passed
@mountiny mountiny deleted the nat-vbba111 branch January 16, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants