[HOLD for payment 2023-12-04] [HOLD for payment 2023-11-30] [$500] iOS - LHN - Skeleton appears instead of LHN if user go offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.1-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Open iOS / iPad App
2. Login with any account
3. Go offline while in LHN and without opening any chats

Expected Result:

LHN is shown correctly if the user goes offline

Actual Result:

Skeleton appears instead of LHN if user go offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native/ iPad Pro 9.7 / 16.6
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6284948_1700536103662.iOS-skeleton-instead-off-lhn-offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ac90ec7e5e193317
• Upwork Job ID: 1726911947115495424
• Last Price Increase: 2023-11-21
• Automatic offers:
• situchan | Contributor | 27815806

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ac90ec7e5e193317

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[izarutskaya]

Not reproduced on production

RPReplay_Final1700534214.MP4

[Julesssss]

I can reproduce on staging v1.4.1-7. Originally I was on the fence about this being a blocker as it only occurs for new sign-ins... but lets see if we can locate the issue before it gets deployed to prod.

iOS-offline.mp4

[Julesssss]

I reviewed the prod...staging diff and recent changes to OptionRowLHN & LHNOptionsList.

This one which migrated LHNOptionsList seems the likely cause as it moved the isLoading condition that wraps OptionsListSkeletonView. Commenting on the issue to see if we can fix or will need to revert.

[TMisiukiewicz]

@Julesssss unfortunately I cannot reproduce it on the simulator, could you provide me the exact steps to follow?

I am not sure if this is related to FlashList migration, since skeleton in SidebarLinks is rendered based on the isLoading value coming from props. There were no changes made to this prop itself.

The styles of displaying the list and skeleton had to change because of the FlashList requirements, but the logic behind displaying the skeleton remained the same. Maybe the bug is in the isLoading logic?
const isLoading = SessionUtils.didUserLogInDuringSession() && isLoadingReportData;

Screen.Recording.2023-11-21.at.15.30.17.mov

[Julesssss]

I was using a physical device and it might be tricky to test on a simulator. But it will also be difficult for you to test the AdHoc version 😕

I'll try building the commit prior to your branch. If the issue exists then we can rule out your changes

[Julesssss]

Hey @TMisiukiewicz, I'm pretty convinced that this PR introduced the bug. As testing/reproducing is difficult I think the best path forward is to revert the PR. Does anyone disagree?

[Julesssss]

@TMisiukiewicz I'm building to a physical device, which is going to be tricky/impossible for you unfortunately

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NO QA] Revert "Migrate LHNOptionsList to Flashlist" #31642

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @getusha requires payment

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] The PR that introduced the bug has been identified. Link to the PR:
• [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@getusha] Determine if we should create a regression test for this bug.
• [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[getusha]

Unsigned myself based on #31711 (comment), @Julesssss lets assign @situchan instead.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [perf] Migrate LHNOptionList to FlashList #31711

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@Julesssss, @kevinksullivan, @situchan Huh... This is 4 days overdue. Who can take care of this?

[situchan]

BZ Checklist:

1. This regression came from FlatList > FlashList migration
2. Migrate LHNOptionsList to Flashlist #31052 (comment)
3. N/A
4. N/A as caught by Applause

[melvin-bot]

@Julesssss, @kevinksullivan, @situchan Huh... This is 4 days overdue. Who can take care of this?

[Julesssss]

Can be paid out tomorrow

[kevinksullivan]

Figure we're close enough given it's nighttime on the west coast. Paid out.