Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LHNOptionsList to Flashlist #31052

Merged

Conversation

TMisiukiewicz
Copy link
Contributor

@TMisiukiewicz TMisiukiewicz commented Nov 8, 2023

Details

Fixed Issues

$ #30910
PROPOSAL:

Tests

  1. Log in into the account (possibly with a lot of chats)
  2. Scroll the LHN list
  3. Verify scrolling goes smoothly
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Log in into the account (possibly with a lot of chats)
  2. Scroll the LHN list
  3. Verify scrolling goes smoothly
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
      • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
ANDROID.mov
Android: mWeb Chrome
ANDROID_WEB.mov
iOS: Native
IOS.mp4
iOS: mWeb Safari
IOS_WEB.mp4
MacOS: Chrome / Safari
WEB.mov
MacOS: Desktop
DESKTOP.mov

Copy link
Contributor

@rezkiy37 rezkiy37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments.

@@ -19,11 +20,10 @@ import OptionRowLHNData from './OptionRowLHNData';
const propTypes = {
/** Wrapper style for the section list */
// eslint-disable-next-line react/forbid-prop-types
style: PropTypes.arrayOf(PropTypes.object),
style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
style: stylePropTypes,


/** Extra styles for the section list container */
// eslint-disable-next-line react/forbid-prop-types
contentContainerStyles: PropTypes.arrayOf(PropTypes.object).isRequired,
contentContainerStyles: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]).isRequired,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contentContainerStyles: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]).isRequired,
contentContainerStyles: stylePropTypes,


/** Extra styles for the section list container */
// eslint-disable-next-line react/forbid-prop-types
contentContainerStyles: PropTypes.arrayOf(PropTypes.object).isRequired,
contentContainerStyles: stylePropTypes,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
contentContainerStyles: stylePropTypes,
contentContainerStyles: stylePropTypes.isRequired,

Copy link
Contributor

@rezkiy37 rezkiy37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one minor comment.

@TMisiukiewicz TMisiukiewicz force-pushed the feat/lhn-flashlist-migration branch from d4b2b23 to 2a51e8b Compare November 8, 2023 10:15
@TMisiukiewicz TMisiukiewicz force-pushed the feat/lhn-flashlist-migration branch from 2a51e8b to 4d228b2 Compare November 8, 2023 11:03
@TMisiukiewicz
Copy link
Contributor Author

Investigating failed tests, once they are fixed it's ready for review. I will be off Thusday and Friday, In case I couldn't fix it today, could you plase take a look on it @adhorodyski ? 🙏

@adhorodyski
Copy link
Contributor

on it!

@TMisiukiewicz TMisiukiewicz force-pushed the feat/lhn-flashlist-migration branch 2 times, most recently from d24eb58 to c7257b3 Compare November 13, 2023 12:49
@TMisiukiewicz
Copy link
Contributor Author

Reduced the amount of failing tests from ~30 to 11 - all in SidebarOrderTest. From my investigation, it seems to happen only in the tests, and while testing on web it works fine. Not sure about what's exactly going on there - when testing displaying LHNOptionList in the correct order, the data prop gets items in the correct order, but renderItem is still called with the previous order. I noticed that if i changed the keyExtractor for index for testing purposes, all the tests went green. Has anyone experienced something like this while working with FlashList? Or maybe there is something I should modify in the tests itself to make it work?

@adhorodyski
Copy link
Contributor

adhorodyski commented Nov 14, 2023

@mountiny unfortunately we can't yet undraft this PR - there are still Reassure tests to be fixed (and they fail locally). Hopefully this can be resolved tomorrow. Unit tests are now passing 🙂

@TMisiukiewicz TMisiukiewicz marked this pull request as ready for review November 15, 2023 09:32
@TMisiukiewicz TMisiukiewicz requested a review from a team as a code owner November 15, 2023 09:32
@melvin-bot melvin-bot bot requested review from ntdiary and removed request for a team November 15, 2023 09:32
Copy link

melvin-bot bot commented Nov 15, 2023

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

@ntdiary could you please start on testing this PR? In the meantime Callstack engineers will look into the failing reassure tests. Thank you!

@ntdiary
Copy link
Contributor

ntdiary commented Nov 15, 2023

@mountiny, my plate is full at the moment, will request another c+. : )

@mountiny mountiny requested review from rushatgabhane and removed request for ntdiary November 15, 2023 13:15
@TMisiukiewicz
Copy link
Contributor Author

Tests are fixed, but we are experiencing increased render count in reassure, for now I'm not sure if it's the way FlashList works - gonna investigate it tomorrow

@roryabraham roryabraham self-requested a review November 15, 2023 16:05
@TMisiukiewicz
Copy link
Contributor Author

Investigated the increased amount of rerenders - according to the FlashList docs:

FlashList doesn't render items in the first cycle. Items are drawn after it measures itself at the end of first render.

I think that's the main reason behind additional renders indicated by Reassure. With this in mind, would it be possible to merge that PR with Reassure GH Action failing? It should set a new baseline on main and any further changes should be compared to this.

@TMisiukiewicz TMisiukiewicz force-pushed the feat/lhn-flashlist-migration branch from cafc4c5 to 3c428c2 Compare November 16, 2023 15:19
@@ -1367,7 +1367,6 @@ const styles = (theme: ThemeColors) =>
},

sidebarListContainer: {
scrollbarWidth: 'none',
Copy link
Member

@rushatgabhane rushatgabhane Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WEB: On staging, we don't have a scroll bar in LHN.
Let's remove the scrollbar.

image

@rushatgabhane
Copy link
Member

Rest looks good!

@TMisiukiewicz
Copy link
Contributor Author

@rushatgabhane thank you for your review, I addressed your comments

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roryabraham
Copy link
Contributor

Merging despite 2 extra re-renders in reassure.

@roryabraham roryabraham merged commit 4df083c into Expensify:main Nov 18, 2023
15 of 16 checks passed
@melvin-bot melvin-bot bot added the Emergency label Nov 18, 2023
Copy link

melvin-bot bot commented Nov 18, 2023

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@roryabraham
Copy link
Contributor

Not an emergency, just establishing a new baseline for renders with a different component

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Julesssss
Copy link
Contributor

Generating an AdHoc build for testing as I'm wondering if this PR introduced this regression. ...

@OSBotify
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/31052/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/31052/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/31052/NewExpensify.dmg https://31052.pr-testing.expensify.com
Desktop Web

@Julesssss
Copy link
Contributor

Yeah, OptionsListSkeletonView modifications seems the likely cause of this regression. This ^ iOS build contains the regression

@TMisiukiewicz are you able to look at this today? If not I can easily revert and we can attempt another PR this week.

53148996-3594-4AB9-9602-E07B0D5A38BA

@situchan
Copy link
Contributor

This maybe caused #31581 as well which was demoted to NAB as it's style issue

@TMisiukiewicz
Copy link
Contributor Author

@Julesssss @situchan taking a look on both issues now

@Julesssss
Copy link
Contributor

Okay, I'm pretty sure now that this PR introduced the issue as the parent commit of your first change doesn't contain the bug:

RPReplay_Final1701186535.MP4

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@JmillsExpensify
Copy link

@roryabraham can I get a payment summary on this PR? @rushatgabhane is requesting payment.

@roryabraham
Copy link
Contributor

Yep, this is just a standard C+ PR review, but it caused a regression. So $250 to @rushatgabhane and that's all here. All other involved parties will invoice separately

@JmillsExpensify
Copy link

Thanks! $250 payment approved for @rushatgabhane based on comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.