[HOLD for payment 2024-01-17] [$500] Threads - When deleting the last unread message, the "New" marker appears for a second

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.1.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open a chat
2. Send two messages
3. Click on "Mark as unread" on the first message
4. Delete the messages one by one

Expected Result:

The new marker disappears with no delay

Actual Result:

The new marker disappears after a delay

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6285667_1700579957504.test5_newMarker.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e466a8c7c7ded031
• Upwork Job ID: 1726989610491375616
• Last Price Increase: 2023-12-04
• Automatic offers:
• s-alves10 | Contributor | 27964548

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e466a8c7c7ded031

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[kbecciv]

This issue fixed here: #21557.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Having multiple unread messages, and removing all of them, the unread line disappears with delay.

What is the root cause of that problem?

We update the unread marker of the last report action only after the action is actually deleted – when the API response comes. But the action gets hidden right after the API call was initiated – when it has reportAction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE.

Therefore, the marker is briefly visible under the "invisible" last removed action while the API request is running.

What changes do you think we should make in order to solve the problem?

We should hide the marker not when the action delete API call was completed, but at the moment it was initiated.

For this, in the shouldDisplayNewMarker function, where we check whether the report action should have the unread marker displayed, we should also return false if the reportAction has pending DELETE action. We also want to check for the network state so that we display the line correctly when offline – because then the messages are not removed, just greyed out:

if (!isOffline && reportAction.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
    return false;
}

App/src/pages/home/report/ReportActionsList.js

Lines 334 to 354 in 8bb02a4

	const shouldDisplayNewMarker = useCallback(
	(reportAction, index) => {
	let shouldDisplay = false;
	if (!currentUnreadMarker) {
	const nextMessage = sortedReportActions[index + 1];
	const isCurrentMessageUnread = isMessageUnread(reportAction, lastReadTimeRef.current);
	shouldDisplay = isCurrentMessageUnread && (!nextMessage || !isMessageUnread(nextMessage, lastReadTimeRef.current));
	if (!messageManuallyMarkedUnread) {
	shouldDisplay = shouldDisplay && reportAction.actorAccountID !== Report.getCurrentUserAccountID();
	}
	if (shouldDisplay) {
	cacheUnreadMarkers.set(report.reportID, reportAction.reportActionID);
	}
	} else {
	shouldDisplay = reportAction.reportActionID === currentUnreadMarker;
	}
	return shouldDisplay;
	},
	[currentUnreadMarker, sortedReportActions, report.reportID, messageManuallyMarkedUnread],
	);

Result:

unread-indicator-compressed.mp4

What alternative solutions did you explore? (Optional)

[s-alves10]

This issue was addressed here #30485 (comment)
I think the suggested solution would solve the issue

[MonilBhavsar]

Self assigning as it is related to marker

[MonilBhavsar]

Dupe of #25606

[zanyrenney]

Closing as this is a dupe!

[MonilBhavsar]

Reopening this issue as another issue was closed and there are some proposals and discussion here

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MonilBhavsar]

@ArekChr any thoughts on the proposals from paultsimura and s-alves10 in another PR

[ArekChr]

As previously discussed, we agreed to address this issue in a separate PR. I've reviewed the solution provided by @s-alves10 in PR #30485 and it solves the bug. Given that @s-alves10 has already developed a working fix, I think we should go ahead with this approach.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @MonilBhavsar is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[MonilBhavsar]

Thanks! Looks good, since we're updating ReportActionsUtils.ts, let's make sure we don't add any regression.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.13-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: hide pending deleted actions #32474

If no regressions arise, payment will be issued on 2023-12-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ArekChr does not require payment (Contractor)
• @s-alves10 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ArekChr / @s-alves10] Determine if we should create a regression test for this bug.
• [@ArekChr / @s-alves10] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MonilBhavsar]

This has caused regression. We're working on a fix

[melvin-bot]

@ArekChr, @MonilBhavsar, @zanyrenney, @s-alves10 Eep! 4 days overdue now. Issues have feelings too...

[MonilBhavsar]

PR is in review

[zanyrenney]

Not paying out yet due to regression.

[zanyrenney]

@MonilBhavsar can you let me know when the regression is resolved for payout please?

[MonilBhavsar]

PR is deployed to production yesterday. I'll add seven days and update the title

[zanyrenney]

not overdue yet, waiting for regression 7 day period.

[zanyrenney]

*Payment summary

@ArekChr does not require payment (Contractor)
@s-alves10 requires payment automatic offer (Contributor) - PAID $500.