[HOLD for payment 2024-01-17] Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Intenral Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any account
3. Navigate to the conversation between user A and B in both devices
4. Send two messages to user B
5. As user A press ArrowUp in the DM. Verify that the last message user A sent in the chat enters edit mode
6. Delete all the text while editing the comment and press Enter
7. Press ArrowUp in the DM

Expected Result:

The first message sent in step 4 enters edit mode

Actual Result:

Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313468_1702579313132.Last_message_edit_mode_doesn_t_open_when_Press_ArrowUp.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

This is regression from #32474
@tylerkaraszewski if we end up reverting approach, feel free to merge #33133 since it's straight revert

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Focus is losted. Nothing happenes. Last message edit mode doesn’t open when Press ArrowUp in the DM if delete the previous message using keyboard

What is the root cause of that problem?

This is regression from this PR #32474 which makes composer doesn't re-focus after deleting the message

What changes do you think we should make in order to solve the problem?

1. Revert this PR fix: hide pending deleted actions #32474

2. To fix the issue of this PR fix: hide pending deleted actions #32474, We should check here if the reportAction is deleted by using isDeletedAction, we will return false because this reportAction still in the list of reportActions with optimistic data but it's invisible in the UI.

if (ReportActionsUtils.isDeletedAction(reportAction) && !isOffline) {
    return false;
}

App/src/pages/home/report/ReportActionsList.js

Line 334 in 3a44f77

let shouldDisplay = false;

What alternative solutions did you explore? (Optional)

[Julesssss]

I can reproduce but this is only occuring on web/desktop and is a minor issue. Removing blocker label

[situchan]

@s-alves10 can you please handle this as regression?

[s-alves10]

@situchan Yes, I'll

[MonilBhavsar]

@s-alves10 thanks! If you don't mind, should I assign this issue to you?

[s-alves10]

yes

[s-alves10]

@dukenv0307

This is regression from this PR #32474 which makes composer doesn't re-focus after deleting the message

What do you think is the root cause of not-focusing? Can you make it more clear?

[s-alves10]

@MonilBhavsar

PR is ready for review #33162

[melvin-bot]

This issue has not been updated in over 15 days. @tylerkaraszewski, @s-alves10 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: hide new marker for pending deleted action in online mode #33162

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @s-alves10 requires payment (Needs manual offer from BZ)

[situchan]

Please assign me here for PR review

[MonilBhavsar]

There was a suspicion that PR linked to this issue has caused a regression #34419
@s-alves10 @situchan anyone of you can please confirm, thank you!

[situchan]

There was a suspicion that PR linked to this issue has caused a regression #34419 @s-alves10 @situchan anyone of you can please confirm, thank you!

Straight revert failing so not able to confirm. But I don't think so as this (still reproducible after reverting this change) was the actual fix and other codes are just revert of previous PR.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @jliexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @s-alves10 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

@MonilBhavsar @tylerkaraszewski just to confirm, there's no regression here right?

Here's a payment summary for everyone's review:

• C+: @situchan

Upworks Job

[situchan]

are you meant to be hired or are you just reviewing the PR?

This is follow-up (regression) of #31637.
The work is done already and I reviewed 2nd PR. (I was not involved in first PR which caused this regression)
@s-alves10's was already fully paid here for the work of first PR.

[jliexpensify]

Oh hmm...so to clarify: I don't need to pay anyone?

[situchan]

I am still eligible based on I was not involved in first PR which caused this regression

[jliexpensify]

Thanks for clearing this up, I will withdraw the offer for Sangar and hire you @situchan

[jliexpensify]

Paid and job closed.