-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-06] [$500] Web - Login - App crashes when login to HT account #31803
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
📣 @github-actions[bot]! 📣
|
Triggered auto assignment to @aldo-expensify ( |
@kbecciv do you have any crash log or console error? |
I suspect it might be coming from this PR - #31711. Gonna try to help @aldo-expensify reproduce this issue first |
Seems to come from this line App/src/libs/OptionsListUtils.js Line 396 in 1163dc3
|
#31061 is candidate |
Yea, I'm trying to reproduce in dev |
For this to happen, we would need to fail to find the IOU here App/src/libs/OptionsListUtils.js Lines 425 to 431 in 36105a3
|
Reproduced:
Going to check if this happens in production |
hmm I have been only able to reproduce in dev, but not ~staging/~production Reproduced in staging. |
hmm, pusher events are not working anymore in my env... |
I have a fix for it here - https://github.com/Expensify/Web-Expensify/pull/39825 |
This is the pusher events that cause the things to explode:
We can see here:
I think the problem is that the |
Sounds good, wanna work on a fix? |
@luacmartins what are your thoughts on: #31806 🙏 |
hmm but in the log I linked above iouReport is defined, we just don't have any reportAction for it in Onyx |
I think there is no payment to be issues here, I'll just close this since the offending PR was reverted. |
Hi @aldo-expensify! I reviewed #31817 and my payment is still pending. Can you please write a payment summary? Thanks |
Triggered auto assignment to @muttmuure ( |
Bug0 Triage Checklist (Main S/O)
|
@muttmuure added This issue is about a regression caused by PR: #31061 |
Thanks @aldo-expensify. Can you please write a payment summary? |
|
Job added to Upwork: https://www.upwork.com/jobs/~01eec53be34df7522e |
Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new. |
Contributor+: @allroundexperts owed $500 via NewDot |
@allroundexperts can you complete the BZ checklist? Thx |
Checklist
|
$500 payment approved for @allroundexperts based on summary above. |
@allroundexperts, @muttmuure, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@allroundexperts did you receive your payment? |
This should all be wrapped up, so closing. Reply if you disagree! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Verify the UI has a loading "skeleton" state (offline avatar and placeholder lines) and loads after a few moments and the loading state is not visible anymore
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6288979_1700775441466.Recording__256.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: