[HOLD for payment 2024-01-22] [$250] [TS migration] Migrate 'ConfirmedRoute.js' component to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/components/ConfirmedRoute.js	17

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c96241cabe044a43
• Upwork Job ID: 1736777355454537728
• Last Price Increase: 2023-12-18
• Automatic offers:
• rayane-djouah | Contributor | 28067009

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c96241cabe044a43

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

Upwork job price has been updated to $250

[neonbhai]

Would love to work on this!

[nikos-amofa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

TypeScript migration

What is the root cause of that problem?

I'd like to work on this project.

[MahmudjonToraqulov]

I would like to work on this

[rayane-djouah]

I would like to work on this issue

[yh-0218]

I would like to work on this issue

[djabdou]

I would like to work on this

[annscode]

I would like to work on this issue

[expertscoders]

I'm available to work on this

[ghost]

Dibs

[Tony-MK]

Could I work on this issue? 😄

[ntsagar9]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/jobs/~01c96241cabe044a43

Proposal

Migrate JS to TS steps need to follow

• Dependence of local file of JS that also need to update
• If third party dependence don't have Types then need to install in dev-dependence like react-native-onyx, lodash
• In-depended code of this file need to write Types of variable and function - Update file extension
• For map box function parameters need to defined types

Please let me know. So, will apply on upwork.

[melvin-bot]

📣 @ntsagar9! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[allroundexperts]

Since @neonbhai is already assigned a migration, we can go with @nikosamofa's proposal since they were the first.

We should go with @rayane-djouah since the rest are already assigned a migration.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rayane-djouah]

PR ready for review

[rayane-djouah]

@allroundexperts could you please update on the PR review? Thank you!

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'ConfirmedRoute.js' component to TypeScript #33529

If no regressions arise, payment will be issued on 2024-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @rayane-djouah requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[sonialiap]

@allroundexperts $250 - please request through NewDot
@rayane-djouah $250 - paid ✔️

[JmillsExpensify]

$250 approved for @allroundexperts based on comment above.