[HOLD for payment 2023-12-07] [HOLD for payment 2023-12-06] IOU - Clicking on card and amount does not cause any action

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on 1:1 report
3. Tap plus icon near compose
4. Tap request money
5. Enter an amount
6. Tap next
7. Tap show more and note "card" option is not displayed
8. Tap request
9. Tap on manual request created to open iou detail page
10. Tap card option

Expected Result:

Tapping on card must trigger an action or card option should not be displayed

Actual Result:

In manual request IOU detail page, tapping on "card" does not trigger any action

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6292395_1701121963215.oip.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Tap show more and note "card" option is not displayed

Was this a new feature? What is the "card" option?

[marcaaron]

Tapping on card must trigger an action or card option should not be displayed

also, what is "action"?

[marcaaron]

Ohhh you are saying that this should not be here? Got it.

I'd probably phrase this like:

"Card" option row appears in request detail for regular non-Card expense

[marcaaron]

Ah we are returning the cash card for the cardID. We will want to make sure that gets omitted and never returned with the report's transactions maybe?

[marcaaron]

cc @luacmartins I think probably we want to check if the card is "cash" in Auth at some point

We can revert @grgia's PR here for now to fix the blocker.

Unless there are any other ideas?

[luacmartins]

This is a new feature, so I think it'd be ok to demote that to NAB since it doesn't really break any functionality (the option just shouldn't be there) and we can work on an Auth PR to filter those cards out. What do you think?

[marcaaron]

It's a core flow so I'll raise a PR to hide the row for everyone temporarily. My preference would be to avoid shipping the broken code.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[grgia]

I think we can use this method instead - #32097 we can just check the cardID exists in the cardList.

[luacmartins]

Removing blocker label since we CPed a fix and it tests well in staging.

[marcaaron]

Nice! Great solution @grgia. I doubt we would ever return the "cash cards" in that list for any reason (🤞 😂 )

[melvin-bot]

@grgia, @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

[alitoshmatov]

Looks like this is ready for payment

[melvin-bot]

@grgia, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@grgia, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[grgia]

@anmurali could you help with $500 C+ review payment to @alitoshmatov

[melvin-bot]

@anmurali, @grgia, @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali, @grgia, @alitoshmatov Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@anmurali, @grgia, @alitoshmatov 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@anmurali, @grgia, @alitoshmatov 10 days overdue. I'm getting more depressed than Marvin.

[grgia]

@anmurali this one's ready for payment- let me know if you need anything else from me!

[grgia]

bump @anmurali

[melvin-bot]

@anmurali, @grgia, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[anmurali]

Offer is https://www.upwork.com/nx/wm/offer/100368742
Pls let me know if the amount is right.

[alitoshmatov]

Can't access upwork job

[anmurali]

Try - https://www.upwork.com/nx/wm/offer/100382852

[anmurali]

Paid!