Temporarily return false for `isCardTransaction()` as all transactions are treated as card #32081

marcaaron · 2023-11-28T00:43:14Z

Details

The cardID in the commented out code can be a "cash" card. Which leads to bugs and must be fixed in Auth.

cc @luacmartins @grgia

Fixed Issues

$ #32077

Tests

Create a manual request
Navigate to the request details
Verify the "Card" row doesn't appear

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…eated as card transactions

melvin-bot · 2023-11-28T00:43:20Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-11-28T00:53:05Z

src/libs/TransactionUtils.ts

-    return (transaction?.cardID ?? 0) > 0;
+    // We are returning cash cardID via the API. We can undo this after it is fixed in Auth.
+    // return (transaction?.cardID ?? 0) > 0;
+    return false;


I think this might introduce another issue. We use this logic to decide if transactions are editable, so always returning false means users might see card transactions as editable in the UI. Can we check if the card is a CASH card instead?

Can we check if the card is a CASH card instead?

Yes, that would be the "real" fix. Or are you saying we are returning that somewhere already?

We can maybe fix it in the PHP layer and CP that... ?

Hmm I think not - it is still missing some things to determine if it is the cash card. Like - bank, managedCard etc

https://github.com/Expensify/Web-Expensify/blob/51a427f541a8b38843bed21d65ac97c4b6c7f93f/lib/Transaction.php#L1519-L1535

WRT to editing card transactions. Do we prevent that in the API? Them being editable might be weird, but I'd take that bug over this one.

It's also... what we have on production already? 😄

I don't think this is a problem with what we're sending- let's just filter out cash cards in this function?

@grgia I like the solution you came up with to fix the Deploy Blocker.

In web-expensify it looks like we download all cards and then check to see if the card is cash by looking at the cardName, bank etc. Having something like isCashCard returned from Auth and attached to the transaction might be more direct.

Return false for isCardTransaction() as all transactions are being tr…

7590a5c

…eated as card transactions

marcaaron self-assigned this Nov 28, 2023

marcaaron requested a review from a team as a code owner November 28, 2023 00:43

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team November 28, 2023 00:43

luacmartins requested changes Nov 28, 2023

View reviewed changes

marcaaron closed this Nov 28, 2023

marcaaron deleted the marcaaron-fixCardRow branch November 28, 2023 20:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Temporarily return false for `isCardTransaction()` as all transactions are treated as card #32081

Temporarily return false for `isCardTransaction()` as all transactions are treated as card #32081

marcaaron commented Nov 28, 2023 •

edited

Loading

melvin-bot bot commented Nov 28, 2023

luacmartins Nov 28, 2023 •

edited

Loading

marcaaron Nov 28, 2023

marcaaron Nov 28, 2023

marcaaron Nov 28, 2023

marcaaron Nov 28, 2023

marcaaron Nov 28, 2023

grgia Nov 28, 2023

marcaaron Nov 28, 2023

Temporarily return false for isCardTransaction() as all transactions are treated as card #32081

Temporarily return false for isCardTransaction() as all transactions are treated as card #32081

Conversation

marcaaron commented Nov 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 28, 2023

luacmartins Nov 28, 2023 • edited Loading

Choose a reason for hiding this comment

marcaaron Nov 28, 2023

Choose a reason for hiding this comment

marcaaron Nov 28, 2023

Choose a reason for hiding this comment

marcaaron Nov 28, 2023

Choose a reason for hiding this comment

marcaaron Nov 28, 2023

Choose a reason for hiding this comment

marcaaron Nov 28, 2023

Choose a reason for hiding this comment

grgia Nov 28, 2023

Choose a reason for hiding this comment

marcaaron Nov 28, 2023

Choose a reason for hiding this comment

Temporarily return false for `isCardTransaction()` as all transactions are treated as card #32081

Temporarily return false for `isCardTransaction()` as all transactions are treated as card #32081

marcaaron commented Nov 28, 2023 •

edited

Loading

luacmartins Nov 28, 2023 •

edited

Loading