[HOLD for payment 2023-12-15] hold for #31134 [$500] mWeb - Request Money - After increasing the font size, the screen does not re-size correctly

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.7-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: user must be logged in

1. Open any chat
2. Initiate a manual money request
3. On the amount page, increase the font size in-browser

Expected Result:

The screen should re-size correctly, the user should be able to scroll down if needed

Actual Result:

The screen re-sizes but it's not completely visible and the user is not able to scroll down
Even if the user change the font size to the original value, the screen does not re-size as initially

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6297760_1701457690855.Gtkj0995_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179c955490129e536
• Upwork Job ID: 1730705738910212096
• Last Price Increase: 2023-12-01

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0179c955490129e536

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[barros001]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request Money screen does not respond well to font size increases, keypad will go off the screen and scrolling is not allowed.

What is the root cause of that problem?

This is a regression from #30065

The PR will set the minimum height of the screen to be the initial screen size in an effort to prevent the native keyboard from compressing the screen when navigating back. The issue is that setting a minHeight will allow for the container to expand if the content expands. This will prevent mobile web from scrolling as the ScrollView component will expand together with the content which defeats its purpose. All parent containers have height:100% and are non-scrollable so the content go off screen and we are not able to scroll it.

Another side effect of the content expanding is that the area where the amount is displayed will not shrink to make more room for the keypad making the experience even worse.

What changes do you think we should make in order to solve the problem?

The goal of the PR that caused the regression was to ensure the keypad wouldn't push the content up. We can accomplish the same goal while preventing the content from expanding the container by using height instead of minHeight.

On these places:

App/src/components/ScreenWrapper/index.js

Line 28 in 1682be4

shouldEnableMinHeight,

App/src/components/ScreenWrapper/index.js

Line 54 in 1682be4

const minHeight = shouldEnableMinHeight ? initialHeight : undefined;

App/src/components/ScreenWrapper/index.js

Line 131 in 1682be4

style={[styles.flex1, {minHeight}]}

App/src/components/ScreenWrapper/propTypes.js

Lines 40 to 41 in 1682be4

	/** Whether to use the minHeight. Use true for screens where the window height are changing because of Virtual Keyboard */
	shouldEnableMinHeight: PropTypes.bool,

• We rename shouldEnableMinHeight to shouldEnableInitialHeight
• We use height instead of minHeight when setting the style on the wrapper container.

We also update the prop name on these two places:

App/src/pages/EditRequestAmountPage.js

Line 47 in 1682be4

shouldEnableMinHeight={DeviceCapabilities.canUseTouchScreen()}

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 96 in 1682be4

shouldEnableMinHeight={DeviceCapabilities.canUseTouchScreen()}

RPReplay_Final1701521724.MP4

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[laurenreidexpensify]

@luacmartins @fedirjh - is this a regression from #30065?

[fedirjh]

@laurenreidexpensify Yes, I think this should be put on hold for #31134, I believe fixing the other bug will cover this bug as well.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] - Disable ScreenWrapper minHeight for safari browser #32460

If no regressions arise, payment will be issued on 2023-12-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

### Payment Summary
[Upwork Job](https://www.upwork.com/jobs/~0179c955490129e536)
- <Role>: @c3024 paid $(<amount>) via Upwork (<Replace with offer link>)

#### BugZero Checklist (@laurenreidexpensify)
- [ ] I have verified the correct assignees and roles are listed above
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork (https://www.upwork.com/ab/applicants/1730705738910212096/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct

[melvin-bot]

@laurenreidexpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[laurenreidexpensify]

@fedirjh can you confirm - we fixed this in #31134 right so this can be closed?

[fedirjh]

@laurenreidexpensify It was fixed with #32460 , this can be closed.

[c3024]

I reviewed that PR. I think this is the only issue that is still open and payment for the review can be processed here.

[laurenreidexpensify]

@luacmartins can you confirm ^^

[luacmartins]

Yes, we fixed this issue with #32460 and @c3024 reviewed that PR.

[melvin-bot]

@luacmartins, @laurenreidexpensify, @c3024 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@luacmartins, @laurenreidexpensify, @c3024 Still overdue 6 days?! Let's take care of this!

[laurenreidexpensify]

@c3024 it doesn't look like you've been compensated in the other associated issues for #32460, so please apply in Upwork https://www.upwork.com/jobs/~0179c955490129e536 for review payment for this thanks

[c3024]

Applied for the job. Thanks.

[melvin-bot]

@luacmartins, @laurenreidexpensify, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@luacmartins, @laurenreidexpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[laurenreidexpensify]

Apols @c3024 that upwork job is now closed, can you apply here instead - Job added to Upwork: upwork.com/jobs/~0187189d12226d3dda Thanks

[laurenreidexpensify]

(not overdue)

[c3024]

Applied, thanks.

[laurenreidexpensify]

Offer sent in Upwork 👍

[c3024]

Accepted

[laurenreidexpensify]

Payment Summary

C+ Review @c3024 - paid in Upwork $500