Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-15] [HOLD for payment 2023-11-13] [$4000] mWeb - Request/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard flashes #17866

Closed
2 of 6 tasks
kbecciv opened this issue Apr 23, 2023 · 286 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Apr 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  • Access staging.new.expensify.com on Android
  • Log in
  • Tap + > Send Money or Request Money
  • Tap on the Currency Sign
  • The Keybard should open (if not open it clicking on the input)
  • Choose a currency and enter an amount
  • Tap "Next" button
  • Tap back arrow

Expected Result:

When returning to the previous screen, the keyboard flashes

Actual Result:

After pressing the back arrow to the "Send money" or "Request money" screen, the keyboard flashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.4.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6028353_Screen_Recording_20230422_230654_Chrome.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c69f6c8136159450
  • Upwork Job ID: 1653068116835205120
  • Last Price Increase: 2023-10-17
  • Automatic offers:
    • fedirjh | Reviewer | 27281218
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 23, 2023
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Christinadobrzyn
Copy link
Contributor

I think this is a dupe of #17805

@parasharrajat or @dangrous would you be able to confirm?

@parasharrajat
Copy link
Member

I don't think it is a duplicate. Here we are saying that Numberpad on the Amount page is pushed up due to the keyboard while going back.

@s77rt
Copy link
Contributor

s77rt commented Apr 24, 2023

This is a dupe of #15270
We have a PR #16443 that is merged but didn't really fix that instance

@s77rt s77rt mentioned this issue Apr 24, 2023
55 tasks
@Christinadobrzyn
Copy link
Contributor

Thanks @parasharrajat and @s77rt - will we try to fix this in #16443 or should we open this up as a new job?

@parasharrajat
Copy link
Member

That depends on whether this will be solved on #16443 or not.

@s77rt
Copy link
Contributor

s77rt commented Apr 24, 2023

Given that the exact instance was highlighted in the video below (from linked issue) I think it should be fixed on that PR

Bug5942090_Viewport___buttons_are_moving_when_navigating_the_menu.mp4

@s77rt
Copy link
Contributor

s77rt commented Apr 24, 2023

Actually the behaviour is slightly different. It looks better than it used to be, so I don't know for sure. It may be best to hear from PR reviewers/assignees.

@Christinadobrzyn
Copy link
Contributor

Checking on a regression here #16443 (comment) - if not a regression we'll continue with this as a separate job

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Apr 28, 2023

Sounds like this isn't a regression from the other fix but I'm not able to reproduce this.

Steps:

  • Access staging.new.expensify.com on Android
  • Log in
  • Open Send Money or Request Money screen
  • Tap on the Currency Sign
  • The Keybard should open (if not open it clicking on the input)
  • Choose a currency and enter an amount
  • Tap "Next" button
  • Tap back arrow

The keyboard loads at the bottom of the screen as expected. I'll see if anyone else can reproduce this. https://expensify.slack.com/archives/C9YU7BX5M/p1682716124592779

@kbecciv
Copy link
Author

kbecciv commented Apr 28, 2023

@Christinadobrzyn I am able to reproduce on SG21/Chrome with build 1.3.8.5

Screen_Recording_20230428_171802_Chrome.mp4

@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@Christinadobrzyn Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label May 1, 2023
@melvin-bot melvin-bot bot changed the title mWeb - Reuest/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard jumps [$1000] mWeb - Reuest/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard jumps May 1, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01c69f6c8136159450

@MelvinBot
Copy link

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@Christinadobrzyn
Copy link
Contributor

I'm able to reproduce it! Adding external

@melvin-bot melvin-bot bot added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Overdue labels May 1, 2023
@MelvinBot
Copy link

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 8, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-11-13] [$4000] mWeb - Request/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard flashes [HOLD for payment 2023-12-15] [HOLD for payment 2023-11-13] [$4000] mWeb - Request/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard flashes Dec 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 8, 2023
Copy link

melvin-bot bot commented Dec 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 8, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
  • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@fedirjh] Determine if we should create a regression test for this bug.
  • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Dec 12, 2023

Preparing for payment - here is the previous payment summary before the latest regression - #17866 (comment)

Payouts due:

Issue Reporter: NA
Contributor: $1000 @sarious (50% regression from the last payment summary) paid in upwork
Contributor+: $1000 @fedirjh ([50% regression from the last payment summary) Paid in upwork

Eligible for 50% #urgency bonus? N

Upwork job is here.

@sarious
Copy link
Contributor

sarious commented Dec 19, 2023

@Christinadobrzyn I can't still apply for this job, because "Only invited users can find, view and apply to the job".

@Christinadobrzyn
Copy link
Contributor

Ah sorry @sarious I just adjusted the visibility for the Upwork job - let me know if that helps! https://www.upwork.com/ab/applicants/1734722622674395136/job-details

@sarious
Copy link
Contributor

sarious commented Dec 27, 2023

Ah sorry @sarious I just adjusted the visibility for the Upwork job - let me know if that helps! https://www.upwork.com/ab/applicants/1734722622674395136/job-details

Well, but now I see another problem "Sorry, we can't let you in"

@Christinadobrzyn
Copy link
Contributor

@sarious can you send me a link to your upwork profile?

@sarious
Copy link
Contributor

sarious commented Jan 4, 2024

@sarious can you send me a link to your upwork profile?

It's my upwork profile link.

@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Jan 15, 2024

cc @Christinadobrzyn is this ready for payment?

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
@sarious
Copy link
Contributor

sarious commented Jan 21, 2024

cc @Christinadobrzyn is this ready for payment?

@fedirjh @Christinadobrzyn sorry, but I haven't got a payment yet.

@fedirjh
Copy link
Contributor

fedirjh commented Jan 23, 2024

@sarious It seems @Christinadobrzyn is currently OOO.

@Christinadobrzyn
Copy link
Contributor

Sorry I'm back, @sarious I created a new job in Upwork because the other closed.

I sent an offer to you for the job so hopefully you can accept it?

here's the job https://www.upwork.com/jobs/~01cee72a36de20c18b

@Christinadobrzyn Christinadobrzyn added Daily KSv2 and removed Weekly KSv2 labels Jan 23, 2024
@webstar027
Copy link

webstar027 commented Jan 24, 2024

Hi, I think it's just a CSS issue and I can fix it in a short time.
I am available to fix it now.

Thanks

Copy link

melvin-bot bot commented Jan 24, 2024

📣 @webstar027! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@webstar027
Copy link

webstar027 commented Jan 24, 2024

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01344e2372c21c730f

@sarious
Copy link
Contributor

sarious commented Jan 24, 2024

Nice, thanks! I've applied to the job by this link.

@Christinadobrzyn
Copy link
Contributor

hey @webstar027 - we've already completed this job, it's just waiting to be paid out so no need to work on this. Feel free to check out any other jobs here - https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22+label%3AExternal

@Christinadobrzyn
Copy link
Contributor

Awesome! Paid @sarious through Upwork based on this payment summary

closing this out! Let me know if you need anything!

@fedirjh
Copy link
Contributor

fedirjh commented Jan 26, 2024

@Christinadobrzyn Could you please process the payment for me as well ? https://www.upwork.com/nx/wm/workroom/35322243/overview

@Christinadobrzyn
Copy link
Contributor

Ah sorry, @fedirjh I thought you were paid through a different Upwork job profile.

I just paid you through this Upwork job based on this payment summary. Let me know if you need anything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests