[HOLD for payment 2024-01-11] [$500] Member - Gmail account cannot invite members to WS

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.9.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Prerequisites: Use [email protected]
account or other gmail account with existing WS

1. Open New Expensify app
2. Navigate to the settings of the existing WS
3. Invite any member

Expected Result:

The Gmail account should be able to invite members to any WS that exist in your account

Actual Result:

Gmail account cannot invite users to existing WS

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6304573_1701962022360.Recording__857.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c3f67ec9f72b91ef
• Upwork Job ID: 1732794719410888704
• Last Price Increase: 2023-12-28
• Automatic offers:
• bernhardoj | Contributor | 28071914

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c3f67ec9f72b91ef

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[Pujan92]

Seems a backend issue where for Focus priority mode, workspace announce reports are not fetched in OpenApp api report_ response. It is general and not specifically related to gmail account.

[ikevin127]

I cannot reproduce it on my end but based on the console error from the video looks like for whoever can reproduce it this.props.route.params.policyID seems to be undefined.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 127 in 8fa65ec

Policy.addMembersToWorkspace(this.props.invitedEmailsToAccountIDsDraft, this.state.welcomeNote, this.props.route.params.policyID);

I was able to reproduce it by setting this.props.route.params.policyID to undefined from within the codebase.

[parasharrajat]

@puneetlath Let's take this internal and assign an Engineer. Thanks.

[parasharrajat]

Let me know if you need C+ help here. For now, I unassigned as I think you won't.

[puneetlath]

I was able to reproduce it by:

1. Logging into an account
2. Creating a workspace
3. Logging out and back in
4. Attempting to invite someone

[puneetlath]

Adding to wave8.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[bernhardoj]

Copying my proposal from #33185.

They have different console errors, but the same issue, and because it's marked as a dupe, I am posting my proposal here.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app throws an error if we change the priority mode to #focus, re-login, and trying to invite or remove a member from a workspace.

What is the root cause of that problem?

The error comes from this LOC where the app fails to find the announce report of the workspace.

App/src/libs/actions/Policy.js

Line 304 in c53eca9

const remainUsers = _.difference(announceReport.participantAccountIDs, accountIDs);

It's because when we use a #focus mode, it will only load some required reports that will be shown on the LHN. When we update it back to Most recent, the app will trigger OpenApp request which will then fetch all report.

App/src/libs/actions/App.ts

Lines 54 to 63 in c53eca9

	Onyx.connect({
	key: ONYXKEYS.NVP_PRIORITY_MODE,
	callback: (nextPriorityMode) => {
	// When someone switches their priority mode we need to fetch all their chats because only #focus mode works with a subset of a user's chats. This is only possible via the OpenApp command.
	if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) {
	// eslint-disable-next-line @typescript-eslint/no-use-before-define
	openApp();
	}
	priorityMode = nextPriorityMode;
	},

What changes do you think we should make in order to solve the problem?

If we can't find the announce report, that means nothing to update optimistically, so we can just return early.

App/src/libs/actions/Policy.js

Lines 297 to 303 in c53eca9

	function removeOptimisticAnnounceRoomMembers(policyID, accountIDs) {
	const announceReport = ReportUtils.getRoom(CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE, policyID);
	const announceRoomMembers = {
	onyxOptimisticData: [],
	onyxFailureData: [],
	};

if (!announceReport) return announceRoomMembers

(we need to apply the same fix to buildAnnounceRoomMembersOnyxData)

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[deetergp]

@bernhardoj's proposal sounds good. Let's go with it!

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @parasharrajat

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.21-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't add member if login while focus mode is on #33742

If no regressions arise, payment will be issued on 2024-01-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@parasharrajat friendly reminder about the checklist so that we can pay in a couple of days.

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Fix: invite and remove member when offline in workspace #30627
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30627/files#r1445749560
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed.
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Go to Preferences > Priority Mode and change it to "focus"
2. Create a workspace if you don't have any.
3. Make sure the workspace #announce room isn't unread.
4. Sign out and sign in back.
5. Open the workspace member page
6. Add any new member and verify it works.
7. Remove any member and verify it works.

Do you agree 👍 or 👎 ?

[puneetlath]

Payment summary:
$500 - @bernhardoj - paid via upwork
$500 - @parasharrajat - to be paid via NewDot (please request)

Thanks everyone!

[parasharrajat]

Payment requested as per #32682 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat