Fix: invite and remove member when offline in workspace #30627

dukenv0307 · 2023-10-31T11:32:20Z

Details

Fix: invite and remove member when offline in workspace

Fixed Issues

$ #30496
PROPOSAL: #30496 (comment)

Tests

Invite users

Go offline
Create new WS
Click on Member, add any number of users
Go to announce room of that WS
Verify that the announce room displayx the correct list of users

Remove users

Go offline
Go to any WS ( should have at least 2 users )
Click on Member, remove any number of users
Go to the announce room of that WS
Verify that the announce room displays the correct list of users

Verify that no errors appear in the JS console

Offline tests

QA Steps

Invite users

Go offline
Create new WS
Click on Member, add any number of users
Go to announce room of that WS
Verify that the announce room displayx the correct list of users

Remove users

Go offline
Go to any WS ( should have at least 2 users )
Click on Member, remove any number of users
Go to the announce room of that WS
Verify that the announce room displays the correct list of users

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mov

Android: mWeb Chrome

chrome-resize.mov

iOS: Native

ios-resize.mov

iOS: mWeb Safari

safari-resize.mov

MacOS: Chrome / Safari

web-resize.mov

MacOS: Desktop

desktop-resize.mov

melvin-bot · 2023-10-31T15:36:30Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini

Looks great thank you. I have some small suggestions. Also, maybe we should show the added members in the room as pending while offline, as they are shown on the members page.

src/libs/actions/Policy.js

dukenv0307 · 2023-11-01T08:01:43Z

@neil-marcellini

Also, maybe we should show the added members in the room as pending while offline, as they are shown on the members page.

In policy chat, a newly added member is not shown as pending, therefore, I think we don't need that logic here
Or maybe a new issue to handle this separately

bug-resize.mov

neil-marcellini · 2023-11-01T18:10:01Z

In policy chat, a newly added member is not shown as pending, therefore, I think we don't need that logic here
Or maybe a new issue to handle this separately

Ok yeah we could create a new issue for it. But also maybe no one else cares 🤷‍♂️, so no need to worry about it here.

neil-marcellini

Thanks for the updates! The code looks great, the comments need some tweaks.

src/libs/actions/Policy.js

neil-marcellini

Looks great. There are some conflicts.

dukenv0307 · 2023-11-03T03:06:45Z

@neil-marcellini Conflict resolved

neil-marcellini · 2023-11-03T17:31:32Z

@dukenv0307 Looks like there are more conflicts 😢

dukenv0307 · 2023-11-06T03:59:15Z

@neil-marcellini @allroundexperts All conflicts are resolved. Please help review the PR again once you have time

allroundexperts · 2023-11-06T08:46:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-06.at.1.37.54.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-06.at.1.27.23.PM.mov

iOS: Native

Screen.Recording.2023-11-06.at.1.25.19.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-06.at.1.23.20.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-06.at.1.19.52.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-06.at.1.34.44.PM.mov

allroundexperts · 2023-11-06T08:48:22Z

This is working well. However, on Android, when you remove the members (while being offline), there is no strike through over the removed member. This also seems to happen on dev so we might want to create a follow up issue for this @neil-marcellini.

allroundexperts

Looks good!

cristipaval · 2023-11-06T12:52:27Z

Removing myself as it seems that @neil-marcellini has already context on this one.

neil-marcellini · 2023-11-06T19:51:52Z

However, on Android, when you remove the members (while being offline), there is no strike through over the removed member. This also seems to happen on dev so we might want to create a follow up issue for this @neil-marcellini.

I think we have bigger priorities right now so I'm not going to bother to report that bug.

OSBotify · 2023-11-06T19:59:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:29:58Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:47:31Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:44:03Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2024-01-09T08:08:58Z

src/libs/actions/Policy.js

+ * @returns {Object}
+ */
+function removeOptimisticAnnounceRoomMembers(policyID, accountIDs) {
+    const announceReport = ReportUtils.getRoom(CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE, policyID);


announceReport can be undefined when focus mode is active which will crash the app at line 287 causing #32682

dukenv0307 added 2 commits October 31, 2023 18:31

fix: invite and remove member when offline in workspace

0cabc49

fix: add comments for functions in policy

227ce6f

dukenv0307 marked this pull request as ready for review October 31, 2023 15:36

dukenv0307 requested a review from a team as a code owner October 31, 2023 15:36

melvin-bot bot requested review from allroundexperts and removed request for a team October 31, 2023 15:36

neil-marcellini previously approved these changes Oct 31, 2023

View reviewed changes

src/libs/actions/Policy.js Outdated Show resolved Hide resolved

src/libs/actions/Policy.js Outdated Show resolved Hide resolved

fix: comments

920f002

dukenv0307 dismissed neil-marcellini’s stale review via 920f002 November 1, 2023 07:15

neil-marcellini requested changes Nov 1, 2023

View reviewed changes

src/libs/actions/Policy.js Outdated Show resolved Hide resolved

src/libs/actions/Policy.js Outdated Show resolved Hide resolved

dukenv0307 added 2 commits November 2, 2023 09:14

update comments

20ca6e9

update comments for policy function

a27d594

neil-marcellini previously approved these changes Nov 2, 2023

View reviewed changes

resolve conflict

6f7d4cc

dukenv0307 dismissed neil-marcellini’s stale review via 6f7d4cc November 3, 2023 02:49

dukenv0307 added 2 commits November 6, 2023 10:21

fix merge conflict

fa56f82

fix lint issue

8d5241d

allroundexperts approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from cristipaval November 6, 2023 08:51

cristipaval removed their request for review November 6, 2023 12:51

neil-marcellini approved these changes Nov 6, 2023

View reviewed changes

neil-marcellini merged commit b0ca383 into Expensify:main Nov 6, 2023
13 checks passed

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

parasharrajat reviewed Jan 9, 2024

View reviewed changes

parasharrajat mentioned this pull request Jan 9, 2024

[HOLD for payment 2024-01-11] [$500] Member - Gmail account cannot invite members to WS #32682

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: invite and remove member when offline in workspace #30627

Fix: invite and remove member when offline in workspace #30627

dukenv0307 commented Oct 31, 2023 •

edited

Loading

melvin-bot bot commented Oct 31, 2023

neil-marcellini left a comment

dukenv0307 commented Nov 1, 2023

neil-marcellini commented Nov 1, 2023

neil-marcellini left a comment

neil-marcellini left a comment

dukenv0307 commented Nov 3, 2023

neil-marcellini commented Nov 3, 2023

dukenv0307 commented Nov 6, 2023

allroundexperts commented Nov 6, 2023

allroundexperts commented Nov 6, 2023

allroundexperts left a comment

cristipaval commented Nov 6, 2023

neil-marcellini commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

parasharrajat Jan 9, 2024

Fix: invite and remove member when offline in workspace #30627

Fix: invite and remove member when offline in workspace #30627

Conversation

dukenv0307 commented Oct 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Invite users

Remove users

Offline tests

QA Steps

Invite users

Remove users

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 31, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

dukenv0307 commented Nov 1, 2023

neil-marcellini commented Nov 1, 2023

neil-marcellini left a comment

Choose a reason for hiding this comment

neil-marcellini left a comment

Choose a reason for hiding this comment

dukenv0307 commented Nov 3, 2023

neil-marcellini commented Nov 3, 2023

dukenv0307 commented Nov 6, 2023

allroundexperts commented Nov 6, 2023

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Nov 6, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

cristipaval commented Nov 6, 2023

neil-marcellini commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

parasharrajat Jan 9, 2024

Choose a reason for hiding this comment

dukenv0307 commented Oct 31, 2023 •

edited

Loading