Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-20] Android - IOU - Unable to capture receipt photo, the camera error displayed #32836

Closed
2 of 6 tasks
kbecciv opened this issue Dec 11, 2023 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #28618

Action Performed:

Precondition: user should be Signed In

  1. Open app
  2. Tap on FAB
  3. Select Scan tab
  4. Tap on Continue button and grant the camera permission
  5. Tap on shot camera button

Expected Result:

Receipt photo should be captured and user should be navigated on the attendee screen

Actual Result:

Camera error displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309313_1702313741861.screen-20231211-185142.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mkhutornyi
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - Unable to capture receipt photo, the camera error displayed

What is the root cause of that problem?


Here, passing wrong cameraTabIndex as pageIndex is no longer used and undefined

What changes do you think we should make in order to solve the problem?

pass cameraTabIndex={1} similar to web:

@francoisl
Copy link
Contributor

@mkhutornyi do you know what PR caused this regression? Looks like this part of the code didn't change recently.

@mkhutornyi
Copy link
Contributor

The offending PR is huge and these kinds of minor regressions were expected
https://expensify.slack.com/archives/C01GTK53T8Q/p1702303752079129

@francoisl
Copy link
Contributor

Ah ok got it, thanks. Still trying to confirm your solution but I'm getting an (unrelated) error trying to build android at the moment, looking into it.

@ishpaul777
Copy link
Contributor

ishpaul777 commented Dec 11, 2023

@mkhutornyi solution works here is demo 👇

VIDEO-2023-12-11-23-50-19.mp4

not sure if the rounded border styles and padding from the edge is removed intentionally or by mistake

@mkhutornyi
Copy link
Contributor

@francoisl this also happens on iOS as well. If you have iPhone, you can also test with it

@francoisl
Copy link
Contributor

Ah ok great. Let's go with your solution then @mkhutornyi!

@mkhutornyi
Copy link
Contributor

mkhutornyi commented Dec 11, 2023

PR is ready

@mkhutornyi
Copy link
Contributor

@francoisl the fix also applies to iOS but unfortunately not able to test because it requires real device (iOS simulator doesn't have camera feature). Btw android works well

@situchan
Copy link
Contributor

I can help with iOS testing. Confirmed fix on my iPhone

ios.MP4

@francoisl francoisl added Bug Something is broken. Auto assigns a BugZero manager. and removed DeployBlockerCash This issue or pull request should block deployment labels Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 11, 2023
Copy link

melvin-bot bot commented Dec 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@francoisl
Copy link
Contributor

francoisl commented Dec 11, 2023

Assigning a CME to handle payment to @mkhutornyi.

@Expensify Expensify deleted a comment from melvin-bot bot Dec 12, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 13, 2023
@melvin-bot melvin-bot bot changed the title Android - IOU - Unable to capture receipt photo, the camera error displayed [HOLD for payment 2023-12-20] Android - IOU - Unable to capture receipt photo, the camera error displayed Dec 13, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2023
Copy link

melvin-bot bot commented Dec 13, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @mkhutornyi requires payment (Needs manual offer from BZ)

This comment was marked as off-topic.

@puneetlath
Copy link
Contributor

@mkhutornyi can you send me your Upwork profile and I'll send you an offer?

@mkhutornyi
Copy link
Contributor

mkhutornyi commented Dec 14, 2023

@puneetlath
Copy link
Contributor

Offer sent. Will play on Dec 20.

https://www.upwork.com/nx/wm/offer/28060876

@puneetlath
Copy link
Contributor

Paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants