[HOLD for payment 2024-01-02] [$500] App unusable on Safari 16.3

[Julesssss]

CC @rojiphil @jjcoffee

---

Version Number: ?
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1702869444870729

Action Performed:

• Open app
• Should not see error
  

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b9ae6039965bf1b0
• Upwork Job ID: 1736762561116237824
• Last Price Increase: 2023-12-18
• Automatic offers:
• rojiphil | Contributor | 28064568
• situchan | Contributor | 28065190

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

@anmurali we might already know the fix. Let's not make it external just yet.

[jjcoffee]

@anyongjitiger Tagging you in here as you worked on the PR that (probably) caused this.

[Julesssss]

Not going to count this as a regression, as it's impossible to test old safari versions... so we'll treat it as a new issue, with a regular bounty

[Julesssss]

@rojiphil are you interested in working on this bug?

[rojiphil]

@rojiphil are you interested in working on this bug?

@Julesssss
Yes. Would be interested.
I think we can do this using capture groups
Let me look at the issue.
Will get back within an hour.

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In older versions of Safari (i.e. 16.3) , the app does not load.

What is the root cause of that problem?

Older versions of Safari do not support lookbehind regex. So, here, the regex uses lookbehind regex. This is the root cause.

What changes do you think we should make in order to solve the problem?

We can solve the problem using capture groups as follows here

    const match = avatarURL.match(/(default-avatar_)(\d+)(?=\.)/);
    const lastDigit = match && parseInt(match[2], 10);

What alternative solutions did you explore? (Optional)

[rojiphil]

@Julesssss
Have sent a proposal.
I can raise a PR immediately.

[Julesssss]

Thank you, I'll assign a C+ for the PR review.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b9ae6039965bf1b0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[situchan]

I have very old macOS 12.6 (Safari 16.0) so if assigned C+ is not able to test (because they don't have old version), I can help

[rojiphil]

The PR is ready for review.

[situchan]

I can review but giving priority to assigned reviewers first

[Julesssss]

Bumping @Santhosh-Sellavel, which Safari version are you running?

[Santhosh-Sellavel]

I'm on 17.1.2

[Santhosh-Sellavel]

Feel free to review this one @situchan, I'm not sure how to test this one!

cc: @Julesssss

[situchan]

Just to rephrase this issue:

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Julesssss]

PR merged awaiting deployment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix older safari launch app issue #33238

If no regressions arise, payment will be issued on 2024-01-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Contributor)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rojiphil]

If no regressions arise, payment will be issued on 2024-01-02.

@anmurali
Gentle bump on processing payment here

[melvin-bot]

@rojiphil, @Julesssss, @anmurali, @situchan Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Paid. I don't think we would add any regression tests for this.