fix older safari launch app issue #33238

rojiphil · 2023-12-18T15:15:29Z

Details

This PR uses capture groups instead of lookbehind to support older safari versions (v 16.3) for avatar URL so that the app can launch successfully.

Declaration: I could not test on Android Native due to the pending issue as per slack thread here.
Since this issue has to do with web/mWeb Safari platform, this may not be an issue here.

Fixed Issues

$ #33215
PROPOSAL: #33215 (comment)

Tests

Steps
Precondition: Safari version: 16.3

Reload the App when the user has already signed in

Expected Result: The App should load correctly and the avatars should be displayed.

Verify that no errors appear in the JS console

Offline tests

Same as the Steps for Tests Section.

QA Steps

Same as the Steps for Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web - Safari

33215-web-safari-2.mp4

Mobile Web - Safari

33215-mweb-safari.mp4

Desktop

33215-desktop.mp4

iOS

33215-ios-native.mp4

Android

Not done due to the pending issue as per slack thread here.
Plus since this issue has to do with web/mWeb Safari platform, this may not be a matter of concern here.

Mobile Web - Chrome

33215-mweb-chrome.mp4

melvin-bot · 2023-12-18T16:45:56Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-12-19T05:07:03Z

src/libs/UserUtils.ts

@@ -105,8 +105,8 @@ function getDefaultAvatar(accountID = -1, avatarURL?: string): React.FC<SvgProps
    // But the avatar link still corresponds to the original ID-generated link. So we extract the SVG image number from the backend's link instead of using the user ID directly
    let accountIDHashBucket: AvatarRange;
    if (avatarURL) {
-        const match = avatarURL.match(/(?<=default-avatar_)\d+(?=\.)/);
-        const lastDigit = match && parseInt(match[0], 10);
+        const match = avatarURL.match(/(default-avatar_)(\d+)(?=\.)/);


can we add unit test? I think this can be easily broken in the future
btw, not blocker

Good point, I agree. Would you mind doing that @rojiphil?

Sure. Let me check.

Added unit test

situchan · 2023-12-19T06:11:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan

Tests well!

situchan · 2023-12-19T06:38:53Z

@Julesssss #32090 was deployed to staging and app doesn't load on safari.
Not sure if this PR needs to be CPed based on how much % of users are using old safari.

Julesssss

Code is looking good, but I agree it would be great to add a unit test to avoid regressions.

rojiphil · 2023-12-19T12:12:22Z

Code is looking good, but I agree it would be great to add a unit test to avoid regressions.

@Julesssss @situchan
I have added a unit test to check if getDefaultAvatar returns correctly on passing avatar URL.
Trust this is good enough here.

situchan · 2023-12-19T12:37:27Z

tests/unit/UserUtilsTest.js

+    it('should return the default avatar from the avatar url', () => {
+        const avatarURL = 'https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_7.png';
+        const defaultAvatar = UserUtils.getDefaultAvatar(1, avatarURL);
+        expect(typeof defaultAvatar).toBe('function');


This is useless. I was expecting accountIDHashBucket to be returned. Also add some more cases including invalid ones.

This is useless. I was expecting accountIDHashBucket to be returned.

@situchan
Not sure if I understood your expectation correctly here as the function getDefaultAvatar does not return accountIDHashBucket.
Can you please explain more about your expectation? Maybe, pointing to an existing unit test case of a similar kind can also help. Maybe I am missing something simple here.

Also add some more cases including invalid ones.

When the regex fails, the function will return undefined. I can add a case for the invalid one.

I was thinking the purpose of this test was to evaluate regex.
But you reused this function (getDefaultAvatar) which doesn't detect regex is right or not.
If no other way, better to remove this redundant test

Also, since our issue here was due to lack of lookbehind support in older safari versions, I am wondering how a unit test case will detect this.
I am not sure if the test cases are run against specific versions of browser.
I would like to know your thoughts on this.

Similar concern: #25742 (comment)

Maybe create lint rule something like https://eslint.org/docs/latest/rules/no-useless-backreference but out of scope for this PR.
I am fine to merge as is for now.
cc: @Julesssss

Maybe create lint rule something like https://eslint.org/docs/latest/rules/no-useless-backreference but out of scope for this PR.

I think this is an interesting approach and worth considering.
But yes, I also think this is out of scope for this PR.

Julesssss · 2023-12-21T15:38:57Z

The checklist has changed. I'm skipping this

OSBotify · 2023-12-21T15:43:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2023-12-22T20:32:58Z

@rojiphil @Julesssss our QA team does not have Mac Safari 16.3 version. Could you validate this internally?

rojiphil · 2023-12-23T03:36:01Z

@rojiphil @Julesssss our QA team does not have Mac Safari 16.3 version. Could you validate this internally?

@kavimuru
Attaching a test video from the latest main on Safari 16.3 for validation:

33215-issue-verification.mp4

kavimuru · 2023-12-23T09:32:45Z

@rojiphil can I check it off the list? One of our tester has 15.x version. Can we validate with 15.x Safari version?

rojiphil · 2023-12-23T09:37:54Z

One of our tester has 15.x version. Can we validate with 15.x Safari version?

@kavimuru
Yes. You can validate this issue against 15.x version as well.
This issue occurs on Safari with v16.3 or below as shown here.

OSBotify · 2023-12-26T00:14:40Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.16-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

use capture groups for regex

6fc83d5

rojiphil marked this pull request as ready for review December 18, 2023 16:45

rojiphil requested a review from a team as a code owner December 18, 2023 16:45

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team December 18, 2023 16:45

rojiphil mentioned this pull request Dec 18, 2023

[HOLD for payment 2024-01-02] [$500] App unusable on Safari 16.3 #33215

Closed

6 tasks

Julesssss assigned rojiphil Dec 18, 2023

situchan reviewed Dec 19, 2023

View reviewed changes

situchan approved these changes Dec 19, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss December 19, 2023 06:16

Julesssss removed the request for review from Santhosh-Sellavel December 19, 2023 09:46

Julesssss reviewed Dec 19, 2023

View reviewed changes

unit test for default avatar based on url

7043a17

situchan reviewed Dec 19, 2023

View reviewed changes

Julesssss approved these changes Dec 21, 2023

View reviewed changes

Julesssss merged commit 8970aa3 into Expensify:main Dec 21, 2023
23 of 24 checks passed

rojiphil deleted the 33215-app-unusable-older-safari branch December 21, 2023 15:58

github-actions bot mentioned this pull request Dec 22, 2023

Deploy Checklist: New Expensify 2023-12-22 #33480

Closed

32 tasks

lanitochka17 mentioned this pull request Dec 23, 2023

[$500] Mac/Safari - Login - App crashed when login to App #33551

Closed

6 tasks

rojiphil removed their assignment Apr 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix older safari launch app issue #33238

fix older safari launch app issue #33238

rojiphil commented Dec 18, 2023 •

edited

Loading

melvin-bot bot commented Dec 18, 2023

situchan Dec 19, 2023 •

edited

Loading

Julesssss Dec 19, 2023

rojiphil Dec 19, 2023

rojiphil Dec 19, 2023

situchan commented Dec 19, 2023

situchan left a comment

situchan commented Dec 19, 2023

Julesssss left a comment

rojiphil commented Dec 19, 2023

situchan Dec 19, 2023

rojiphil Dec 19, 2023 •

edited

Loading

situchan Dec 19, 2023

rojiphil Dec 19, 2023

situchan Dec 19, 2023

situchan Dec 19, 2023

rojiphil Dec 19, 2023

Julesssss commented Dec 21, 2023

OSBotify commented Dec 21, 2023

kavimuru commented Dec 22, 2023

rojiphil commented Dec 23, 2023

kavimuru commented Dec 23, 2023

rojiphil commented Dec 23, 2023

OSBotify commented Dec 26, 2023

fix older safari launch app issue #33238

fix older safari launch app issue #33238

Conversation

rojiphil commented Dec 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 18, 2023

situchan Dec 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

situchan commented Dec 19, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

situchan commented Dec 19, 2023

Julesssss left a comment

Choose a reason for hiding this comment

rojiphil commented Dec 19, 2023

Choose a reason for hiding this comment

rojiphil Dec 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julesssss commented Dec 21, 2023

OSBotify commented Dec 21, 2023

kavimuru commented Dec 22, 2023

rojiphil commented Dec 23, 2023

kavimuru commented Dec 23, 2023

rojiphil commented Dec 23, 2023

OSBotify commented Dec 26, 2023

rojiphil commented Dec 18, 2023 •

edited

Loading

situchan Dec 19, 2023 •

edited

Loading

rojiphil Dec 19, 2023 •

edited

Loading