[HOLD for payment 2024-01-25] [HOLD for payment 2024-01-03] Expense - Expense preview with a manual and ongoing scan does not show "x request, y scanning"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.16-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a new workspace
2. Go to workspace chat
3. Create a manual request
4. Create a scan request

Expected Result:

The expense preview in the workspace chat will show "x request, y scanning

Actual Result:

The expense preview in the workspace chat just shows "Receipt", as if the receipt in the Scan request is part of the manual expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324154_1703264366246.bandicam_2023-12-22_21-52-25-983__2_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[rlinoz]

This is a regression from #32469

[rlinoz]

Opened a PR to fix it

[mountiny]

PR is up and merged, but I dont think this needs to be CPed its a minor change so demoting this to not a blocker

[mountiny]

Per this comment #33576 (comment) this is still failing on some platforms cc @kbecciv do you have more details?

[kbecciv]

It failed on mWeb, Desktop and IOS app

RPReplay_Final1703593634.mp4

[mountiny]

So the numbers are not correct but the text pattern is fine I think.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix preview for report with manual and smartscan expense at the same time #33516

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[rlinoz]

@vitHoracek you mean it should be 2 requests, 1 scanning?

[rlinoz]

Working on a PR, should be up tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix x requests, y scanning count in ReportPreview  #34191

If no regressions arise, payment will be issued on 2024-01-25. 🎊

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[rlinoz]

@allroundexperts is due payment for reviewing the PR

[twisterdotcom]

This would be on Jan 25 right? The automation should send offers to you both. But I will handle it then if not.

[rlinoz]

Moving to weekly since it is on hold for payment.

[twisterdotcom]

Okay, so I think the payment summary is just:

• @allroundexperts to be paid $500 via NewDot Manual Requests (C+)

[JmillsExpensify]

$500 payment approved for @allroundexperts based on comment above.