[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment-Add receipt and Delete request options are present after canceling Send money payment

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.16-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to 1:1 DM > + > Send money
2. Send the money
3. Click on the IOU preview in the main chat
4. Click 3-dot menu > Cancel payment > Cancel payment
5. Click on the IOU preview to open IOU details page
6. Click 3-dot menu
7. Click Add receipt
8. Click Delete request

Expected Result:

"Add receipt" and "Delete request" options should not be present for Send money request

Actual Result:

"Add receipt" and "Delete request" options are present for Send money request
"Add receipt" button does nothing
"Delete request" results in the IOU preview to become skeleton placeholder in IOU report and TBD in the main chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6324213_1703269667288.bandicam_2023-12-23_01-10-17-738.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After canceling the "Send Money" request, it starts to behave as a regular Manual request.

What is the root cause of that problem?

This is because we do not differentiate between a Manual and "Send" requests. We've always been checking for the request to be settled, like for the header here – we show the "editing" items in the 3-dots menu based on this condition:

App/src/components/MoneyRequestHeader.js

Line 88 in addfa88

const canModifyRequest = isActionOwner && !isSettled && !isApproved && !ReportActionsUtils.isDeletedAction(parentReportAction);

And after canceling, the "Send" request becomes unsettled.

What changes do you think we should make in order to solve the problem?

I think it's important to differentiate all the IOU requests by populating their transaction or the Money Request Report with an iouType (and maybe the requestType) when placing the request:

App/src/CONST.ts

Lines 1172 to 1181 in d912bf1

	TYPE: {
	SEND: 'send',
	SPLIT: 'split',
	REQUEST: 'request',
	},
	REQUEST_TYPE: {
	DISTANCE: 'distance',
	MANUAL: 'manual',
	SCAN: 'scan',
	},

And we should change the logic in places where we differentiated requests only by the isSettled status to check the iouType as well.

Otherwise, not only the unwanted items appear in the 3-dots menu but also the canceled "Send" IOU behaves as "Owes":

What alternative solutions did you explore? (Optional)

[mountiny]

Reverting the original PR because it has caused numerous deploy blockers and the author is ooo

[mountiny]

PR reverted, Assigning @Gonals so you can track this issue and fix it in next iteration

[Gonals]

Setting it as monthly, as this is no longer happening (but I want it open to keep track)

[Gonals]

The root of this is that we shouldn't really allow Cancel Payment for IOUs, just for expenses 😁, and there is no "Send money" for expenses

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Cancel Payment command (again) #33836

If no regressions arise, payment will be issued on 2024-01-25. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Cancel Payment command (again) #33836

If no regressions arise, payment will be issued on 2024-01-26. 🎊

[melvin-bot]

This issue has not been updated in over 15 days. @Gonals eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@Gonals, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.