Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel payment - "Auth CancelReimbursement" error shows up when cancelling payment with Expensify #33540

Closed
6 tasks done
izarutskaya opened this issue Dec 23, 2023 · 20 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@izarutskaya
Copy link

izarutskaya commented Dec 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Found when executing PR: #32674

Version Number: v1.4.16-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Precondition:

  • User A (Admin)- have Fidelity verified business bank account set up on Old Dot.
  • User B (Workspace member) - have Chase deposit bank account set up on Old Dot.
  1. [Member] Request money from the workspace chat.
  2. [Admin] Open the expense report and click Pay with Expensify.
  3. [Admin] Click 3-dot menu > Cancel payment > Cancel payment.

Expected Result:

Payment cancellation is successful.

Actual Result:

Cancellation for payment with Expensify fails as "Auth CancelReimbursement returned an error" shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6324642_1703301911102.bandicam_2023-12-23_01-49-48-792.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d0f4ed22cb60b3ca
  • Upwork Job ID: 1738517016348860416
  • Last Price Increase: 2023-12-23
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 23, 2023
@melvin-bot melvin-bot bot changed the title Cancel payment - "Auth CancelReimbursement" error shows up when cancelling payment with Expensify [$500] Cancel payment - "Auth CancelReimbursement" error shows up when cancelling payment with Expensify Dec 23, 2023
Copy link

melvin-bot bot commented Dec 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01d0f4ed22cb60b3ca

Copy link

melvin-bot bot commented Dec 23, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 23, 2023
Copy link

melvin-bot bot commented Dec 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 23, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 23, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 23, 2023

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Dec 25, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 Overdue labels Dec 25, 2023
@mountiny mountiny removed Reviewing Has a PR in review External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 25, 2023
@mountiny
Copy link
Contributor

mountiny commented Dec 25, 2023

Reverting the original PR because it has caused numerous deploy blockers and the author is ooo

@mountiny mountiny removed their assignment Dec 25, 2023
@mountiny
Copy link
Contributor

PR reverted, Assigning @Gonals so you can track this issue and fix it in next iteration

@Gonals
Copy link
Contributor

Gonals commented Dec 27, 2023

Setting it as monthly, as this is no longer happening (but I want it to keep track)

@Gonals Gonals added Monthly KSv2 and removed Weekly KSv2 labels Dec 27, 2023
@Gonals
Copy link
Contributor

Gonals commented Jan 2, 2024

@izarutskaya, were these real accounts? The test bank accounts don't work for reimbursement cancellation

Copy link

melvin-bot bot commented Jan 6, 2024

@Gonals @rushatgabhane @bfitzexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jan 6, 2024
@bfitzexpensify
Copy link
Contributor

@izarutskaya bump on #33540 (comment).

Switching this back to monthly based on @Gonals comment here

@bfitzexpensify bfitzexpensify added Monthly KSv2 and removed Daily KSv2 labels Jan 8, 2024
Copy link

melvin-bot bot commented Jan 13, 2024

@Gonals @rushatgabhane @bfitzexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jan 13, 2024
@Gonals
Copy link
Contributor

Gonals commented Jan 15, 2024

We are fine. PR should be merging soon (today?)

@melvin-bot melvin-bot bot added the Overdue label Jan 17, 2024
@Gonals
Copy link
Contributor

Gonals commented Jan 18, 2024

Closing this, as it got reverted

@Gonals Gonals closed this as completed Jan 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2024
@kavimuru
Copy link

@Gonals Our QA team is still able to reproduce when validating this PR #34719. So reopening the issue.

Record_2024-02-16-15-47-53.mp4

@kavimuru kavimuru reopened this Feb 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2024
@Gonals
Copy link
Contributor

Gonals commented Feb 16, 2024

@Gonals Our QA team is still able to reproduce when validating this PR #34719. So reopening the issue.

Record_2024-02-16-15-47-53.mp4

Can you confirm you are using real bank accounts and NOT the test ones? This fails with test bank accounts 😅

@Gonals
Copy link
Contributor

Gonals commented Feb 16, 2024

@Gonals Our QA team is still able to reproduce when validating this PR #34719. So reopening the issue.
Record_2024-02-16-15-47-53.mp4

Can you confirm you are using real bank accounts and NOT the test ones? This fails with test bank accounts 😅

Logs:

855e27c8bc8471e5-JHB | db1.sjc | 2024-02-15 14:14:07 640 | [email protected] | Cannot reimburse from Plaid test bank account
-- | -- | -- | -- | --

Basically, we don't really pay anyone with a test bank account, so we can't really cancel the payment

@bfitzexpensify
Copy link
Contributor

Sounds like we're good to re-close this @Gonals?

@Gonals
Copy link
Contributor

Gonals commented Feb 19, 2024

I think so

@Gonals Gonals closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants