Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] mWeb/Safari - Workspace - Expensify site is visible while doing the Plaid bank account steps #33556

Closed
1 of 6 tasks
lanitochka17 opened this issue Dec 23, 2023 · 17 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Dec 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.16.3
Reproducible in staging?: Y
Reproducible in production?: Unable to check the Plaid connection in prod
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with an expensifail account
  3. Create a workspace
  4. Start adding a bank account (Connect with Plaid)

Expected Result:

It shouldn't be visible until the Plaid process is finished

Actual Result:

Expensify site is visible for a short time while doing the Plaid bank account steps

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6325109_1703361730508.RPReplay_Final1703341076.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dd088023ec934a0c
  • Upwork Job ID: 1738686198818414592
  • Last Price Increase: 2024-01-06
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 23, 2023
@melvin-bot melvin-bot bot changed the title mWeb/Safari - Workspace - Expensify site is visible while doing the Plaid bank account steps [$500] mWeb/Safari - Workspace - Expensify site is visible while doing the Plaid bank account steps Dec 23, 2023
Copy link

melvin-bot bot commented Dec 23, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01dd088023ec934a0c

Copy link

melvin-bot bot commented Dec 23, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 23, 2023
Copy link

melvin-bot bot commented Dec 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 23, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Dec 23, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 23, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 23, 2023

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 25, 2023
Copy link

melvin-bot bot commented Dec 25, 2023

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

@mountiny
Copy link
Contributor

I dont think this is a deploy blocker but leaving this open to check into the root cause

@hoangzinh
Copy link
Contributor

I think this issue is not a bug, but it's how an integration works. Same as when a user sign in with Google, after clicking the "Sign in with Google" button => it will navigate to Google to authenticate => and then redirect back to our Expensify App to process sign in/up.

@s77rt
Copy link
Contributor

s77rt commented Dec 26, 2023

This seems to be dependent on the selected bank. I tried to reproduce this but it worked just fine. Either way I think we should close this.

Screen.Recording.2023-12-26.at.6.28.36.PM.mov

@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
@s77rt
Copy link
Contributor

s77rt commented Dec 29, 2023

Not overdue. To be closed

@melvin-bot melvin-bot bot removed the Overdue label Dec 29, 2023
Copy link

melvin-bot bot commented Dec 30, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
@s77rt
Copy link
Contributor

s77rt commented Jan 1, 2024

Same ^

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 1, 2024
@s77rt
Copy link
Contributor

s77rt commented Jan 3, 2024

Same ^ To be closed

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
Copy link

melvin-bot bot commented Jan 6, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2024
@s77rt
Copy link
Contributor

s77rt commented Jan 6, 2024

@anmurali or @hayata-suenaga Can you please close this? (not a bug)

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2024
@hayata-suenaga
Copy link
Contributor

sorry I have been OOO. Yes I agree we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants