New Feature: Create the UI for Actionable Mention Whispers #33665

ishpaul777 · 2023-12-27T20:43:51Z

Details

Fixed Issues

Tests

Verify that no errors appear in the JS console

Make sure you have a DM already between userA and userB and userC. This way their mentions will get autofilled.
Create a workspace as userA.
Create a room on that workspace with any visibility as userA.
As userA, mention userB and userC in a message sent in that room. This should trigger an actionable mention whisper to
be sent to userA (see mockup below).

5. userA can click "Invite them" or "Do nothing". In both these cases, the actionable mention whisper should disappear after a choice is selected. - If "Invite them" was clicked, both userB and userC should have been invited to the room. - If "Do nothing" was clicked, nothing happens.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Make sure you have a DM already between userA and userB and userC. This way their mentions will get autofilled.
Create a workspace as userA.
Create a room on that workspace with any visibility as userA.
As userA, mention userB and userC in a message sent in that room. This should trigger an actionable mention whisper to
be sent to userA (see mockup below).

5. userA can click "Invite them" or "Do nothing". In both these cases, the actionable mention whisper should disappear after a choice is selected. - If "Invite them" was clicked, both userB and userC should have been invited to the room. - If "Do nothing" was clicked, nothing happens.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-02.at.3.18.44.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-02.at.2.08.26.PM.mov

iOS: Native

Screen.Recording.2024-01-02.at.1.12.15.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-02.at.1.17.47.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-21.at.4.30.35.AM-1.mov

MacOS: Desktop

melvin-bot · 2023-12-27T20:43:56Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jasperhuangg

Thanks so much for getting this up! Just did a first pass review and everything looks pretty good other than some minor changes.

src/CONST.ts

src/components/ReportActionItem/ActionItemButttons.tsx

src/pages/home/report/ReportActionItem.js

src/types/onyx/OriginalMessage.ts

ishpaul777 · 2024-01-02T03:38:03Z

Thanks for your time reviewing changes, I'll resolve in few hours 🫡

jasperhuangg

Thanks for taking a look! Just a few other things that I think we should fix that I didn't catch earlier.

src/CONST.ts

src/components/ReportActionItem/ActionItemButtons.tsx

src/libs/actions/Report.ts

src/pages/home/report/ReportActionItem.js

…paul777/App into new-feat/actionable-whispers

jasperhuangg

All yours @rushatgabhane, thanks!

jasperhuangg · 2024-01-05T06:20:12Z

@ishpaul777 lint failures:

/home/runner/work/App/App/src/components/ReportActionItem/ActionableItemButtons.tsx
Error:   4:1  error  Import "WithLocalizeProps" is only used as types                          @typescript-eslint/consistent-type-imports
Error:   6:1  error  All imports in the declaration are only used as types. Use `import type`  @typescript-eslint/consistent-type-imports

jasperhuangg · 2024-01-08T03:53:47Z

@rushatgabhane friendly bump on this review

rushatgabhane · 2024-01-08T13:19:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

i give up :(
3 hour build time only to show this error.

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-01-08.at.19.23.31.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-08.at.18.59.09.mov

Screen.Recording.2024-01-08.at.18.56.02.mov

MacOS: Desktop

rushatgabhane · 2024-01-08T13:59:07Z

Bug: the whisper of another user is shown, and it can't be dismissed.

Steps:

On web, create workspace as user A.
Invite user B
As user B, mention user C and invite them.
Open iOS app as user A.

Expected: whispers of user B aren't shown to user A.
Actual: whispers of user B can be seen by user A. And they cannot be dismissed

Screen.Recording.2024-01-08.at.19.27.05.mov

jasperhuangg · 2024-01-09T03:18:20Z

@rushatgabhane strange, that seems like a back-end issue. I'm looking into it.

github-actions · 2024-01-09T04:19:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/33665/NewExpensify.dmg	https://33665.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jasperhuangg · 2024-01-09T04:35:46Z

I'm unable to load the App on Android/iOS locally, and it seems our workflows for AdHoc builds are currently broken.

@rushatgabhane Is there any chance you could insert some logs for userA in your testing steps to see what the reportAction looks like? Also, let me know the time stamps when you're running the tests so I can look into logs. Thanks!

rushatgabhane · 2024-01-09T04:37:16Z

Yeah sure! gimme a moment

rushatgabhane · 2024-01-09T04:49:07Z

Timestamp - Tue, 09 Jan 2024 04:47:18 GMT

Logging reportAction for userA that is passed to resolveActionableMentionWhisper().
Let me know if I should log anything else

{
  "reportAction": {
    "actionName": "ACTIONABLEMENTIONWHISPER",
    "actorAccountID": 8392101,
    "automatic": false,
    "avatar": "https://d1wpcgnaa73g0y.cloudfront.net/894b50e60056c966d12216005fbcacec8ce5a2c0.png",
    "created": "2024-01-08 13:29:02.318",
    "isAttachment": false,
    "lastModified": "2024-01-08 13:29:02.318",
    "message": [
      {
        "html": "Heads up, <mention-user accountID=10199254></mention-user> isn't a member of this room.",
        "isDeletedParentAction": false,
        "isEdited": false,
        "text": "Heads up,  isn't a member of this room.",
        "type": "COMMENT",
        "whisperedTo": [
          10199263
        ]
      }
    ],
    "originalMessage": {
      "inviteeAccountIDs": [
        10199254
      ],
      "inviteeEmails": [
        "[email protected]"
      ],
      "lastModified": "2024-01-08 13:29:02.318",
      "reportID": 1049615772452361,
      "whisperedTo": [
        10199263
      ]
    },
    "person": [
      {
        "style": "strong",
        "text": "[email protected]",
        "type": "TEXT"
      }
    ],
    "previousReportActionID": "5717327559065192094",
    "reportActionID": "2037044882738399089",
    "reportActionTimestamp": 1704720542318,
    "shouldShow": true,
    "timestamp": 1704720542,
    "whisperedToAccountIDs": [
      10199263
    ]
  }
}

jasperhuangg · 2024-01-09T05:49:51Z

Interesting, it looks like the accountID of userA is 14762124, and the actionable mention whisper was only whispered to accountID 10199263, but userA still receives the actionable mention whisper. That seems like a back-end issue that I can look into–I've found the logs where it happens.

Regardless, it doesn't seem like we should block this PR on that, since it isn't related to the changes.

Logs of the report action being sent out for posterity

jasperhuangg · 2024-01-09T09:10:15Z

@rushatgabhane @ishpaul777 I'm CPing a fix to staging that should solve that issue that was pointed out here, we can retest once it's been deployed, I'll let you know.

rushatgabhane

@jasperhuangg LGTM!

bug #33665 (comment) not reproducible anymore

quinthar · 2024-01-10T23:58:44Z

What's the next step on this; who is it waiting on, and when will it happen?

ishpaul777 · 2024-01-11T09:08:13Z

What's the next step on this; who is it waiting on, and when will it happen?

we are awaiting for final review from @jasperhuangg

jasperhuangg

woohoo!

OSBotify · 2024-01-13T05:36:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-15T11:57:17Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-17T01:15:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

jasperhuangg · 2024-01-19T15:06:29Z

@ishpaul777 I think I missed this when testing, but the actionable mention whispers are still displaying even after being resolved. I see that the Onyx data is correct, can we update the front-end to filter out resolved actionable mention whispers? Sorry I missed this before!

ishpaul777 · 2024-01-19T15:31:25Z

Sure, I fixed the case in #34560 can you review changes, i didn't realize this was a requirement else i should have fixed in this PR, Sorry!

WIP v1

06043e1

ishpaul777 requested a review from a team as a code owner December 27, 2023 20:43

melvin-bot bot requested review from rushatgabhane and removed request for a team December 27, 2023 20:43

lint error fix

1ee0a4d

ishpaul777 changed the title ~~WIP v1~~ New Feature: Create the UI for Actionable Mention Whispers Dec 27, 2023

ishpaul777 mentioned this pull request Dec 27, 2023

[PAID] [$500] New Feature: Create the UI for Actionable Mention Whispers #32741

Closed

jasperhuangg self-requested a review January 2, 2024 03:21

jasperhuangg requested changes Jan 2, 2024

View reviewed changes

ishpaul777 and others added 4 commits January 2, 2024 12:35

clean up

dfc4437

lint fix

241b0fb

prettier diffs

8366b87

Merge branch 'Expensify:main' into new-feat/actionable-whispers

b49732a

jasperhuangg requested changes Jan 2, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

src/components/ReportActionItem/ActionItemButtons.tsx Outdated Show resolved Hide resolved

src/libs/actions/Report.ts Show resolved Hide resolved

src/pages/home/report/ReportActionItem.js Outdated Show resolved Hide resolved

ishpaul777 and others added 7 commits January 2, 2024 19:13

added requested changes

94c5a61

clean up

0c931c3

lint fix remove unused imports

8bfe553

prettier diffs

017b4fa

Merge branch 'main' into new-feat/actionable-whispers

24717c3

added requested changes

f057dbe

Merge branch 'new-feat/actionable-whispers' of https://github.com/ish…

308221f

…paul777/App into new-feat/actionable-whispers

jasperhuangg previously approved these changes Jan 5, 2024

View reviewed changes

fix lint

2d75fb8

ishpaul777 dismissed jasperhuangg’s stale review via 2d75fb8 January 6, 2024 04:30

ishpaul777 added 2 commits January 6, 2024 10:03

fix lint

9856e91

fix lint

5d42ef7

jasperhuangg added the Ready To Build label Jan 9, 2024

rushatgabhane approved these changes Jan 9, 2024

View reviewed changes

melvin-bot bot requested a review from jasperhuangg January 9, 2024 23:23

jasperhuangg approved these changes Jan 13, 2024

View reviewed changes

jasperhuangg merged commit 753ce92 into Expensify:main Jan 13, 2024
18 checks passed

github-actions bot mentioned this pull request Jan 15, 2024

Deploy Checklist: New Expensify 2024-01-15 #34493

Closed

83 tasks

situchan mentioned this pull request Jan 15, 2024

[HOLD for payment 2024-02-26] Room - Email in Concierge message is not copied when copied to clipboard #34504

Closed

6 tasks

This was referenced Jan 22, 2024

[$500] The whisper to invite someone to a room is persistent #34868

Closed

fixes : copy to clipboard mention whisper message and hide mention whisper on any action #34560

Merged

VickyStash mentioned this pull request Apr 10, 2024

Room - When you assign tasks for member outside private room, we should show a popup inviting them #39799

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Feature: Create the UI for Actionable Mention Whispers #33665

New Feature: Create the UI for Actionable Mention Whispers #33665

ishpaul777 commented Dec 27, 2023 •

edited

Loading

melvin-bot bot commented Dec 27, 2023

jasperhuangg left a comment

ishpaul777 commented Jan 2, 2024

jasperhuangg left a comment

jasperhuangg left a comment

jasperhuangg commented Jan 5, 2024

jasperhuangg commented Jan 8, 2024

rushatgabhane commented Jan 8, 2024 •

edited

Loading

rushatgabhane commented Jan 8, 2024

jasperhuangg commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

jasperhuangg commented Jan 9, 2024

rushatgabhane commented Jan 9, 2024

rushatgabhane commented Jan 9, 2024 •

edited

Loading

jasperhuangg commented Jan 9, 2024 •

edited

Loading

jasperhuangg commented Jan 9, 2024

rushatgabhane left a comment •

edited

Loading

quinthar commented Jan 10, 2024

ishpaul777 commented Jan 11, 2024

jasperhuangg left a comment

OSBotify commented Jan 13, 2024

OSBotify commented Jan 15, 2024

OSBotify commented Jan 17, 2024

jasperhuangg commented Jan 19, 2024

ishpaul777 commented Jan 19, 2024

New Feature: Create the UI for Actionable Mention Whispers #33665

New Feature: Create the UI for Actionable Mention Whispers #33665

Conversation

ishpaul777 commented Dec 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 27, 2023

jasperhuangg left a comment

Choose a reason for hiding this comment

ishpaul777 commented Jan 2, 2024

jasperhuangg left a comment

Choose a reason for hiding this comment

jasperhuangg left a comment

Choose a reason for hiding this comment

jasperhuangg commented Jan 5, 2024

jasperhuangg commented Jan 8, 2024

rushatgabhane commented Jan 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Jan 8, 2024

jasperhuangg commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

jasperhuangg commented Jan 9, 2024

rushatgabhane commented Jan 9, 2024

rushatgabhane commented Jan 9, 2024 • edited Loading

jasperhuangg commented Jan 9, 2024 • edited Loading

jasperhuangg commented Jan 9, 2024

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

quinthar commented Jan 10, 2024

ishpaul777 commented Jan 11, 2024

jasperhuangg left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 13, 2024

OSBotify commented Jan 15, 2024

OSBotify commented Jan 17, 2024

jasperhuangg commented Jan 19, 2024

ishpaul777 commented Jan 19, 2024

ishpaul777 commented Dec 27, 2023 •

edited

Loading

rushatgabhane commented Jan 8, 2024 •

edited

Loading

rushatgabhane commented Jan 9, 2024 •

edited

Loading

jasperhuangg commented Jan 9, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading