Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-05] [HOLD for payment 2024-01-04] Android - Chat - User suggestions list is not displayed when entering @ in compose #33675

Closed
1 of 6 tasks
kbecciv opened this issue Dec 27, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Dec 27, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.18-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Open a group chat
  3. Enter @

Expected Result:

When user enters @, user suggestion list must be displayed.

Actual Result:

When user enters @, user suggestion list is not displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327075_1703711922661.group_at.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Dec 27, 2023
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Dec 27, 2023

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Dec 27, 2023

Issue is not reproducible in production

Screen_Recording_20231228_045240_New.Expensify.mp4

@neil-marcellini
Copy link
Contributor

I'll check if I can reproduce on Android staging, and then look into the root cause.

@situchan
Copy link
Contributor

Confirmed that #32297 caused regression

@neil-marcellini
Copy link
Contributor

Ok great thanks, I'll put up a revert PR.

@neil-marcellini
Copy link
Contributor

@situchan would you please post a video proving that it's fixed on native android?

@neil-marcellini
Copy link
Contributor

PR is merged and I have a CP request here, so all done for now.

@neil-marcellini
Copy link
Contributor

The PR was CPed so it's fixed and I think I can close this

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Dec 28, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 28, 2023
@melvin-bot melvin-bot bot changed the title Android - Chat - User suggestions list is not displayed when entering @ in compose [HOLD for payment 2024-01-04] Android - Chat - User suggestions list is not displayed when entering @ in compose Dec 28, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 28, 2023
Copy link

melvin-bot bot commented Dec 28, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 28, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 29, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-01-04] Android - Chat - User suggestions list is not displayed when entering @ in compose [HOLD for payment 2024-01-05] [HOLD for payment 2024-01-04] Android - Chat - User suggestions list is not displayed when entering @ in compose Dec 29, 2023
Copy link

melvin-bot bot commented Dec 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@situchan
Copy link
Contributor

situchan commented Jan 4, 2024

C+ review payment is pending here

@situchan
Copy link
Contributor

@neil-marcellini can you please check ^?

@AndrewGable AndrewGable added the Bug Something is broken. Auto assigns a BugZero manager. label Mar 22, 2024
Copy link

melvin-bot bot commented Mar 22, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 22, 2024
@AndrewGable
Copy link
Contributor

@trjExpensify - Can you pay this one out? Thanks

@trjExpensify
Copy link
Contributor

Can confirm payment summary as follows:

@situchan I've sent you an offer on Upwork.

@trjExpensify
Copy link
Contributor

Reopening until this is confirmed paid.

@trjExpensify trjExpensify reopened this Mar 25, 2024
@trjExpensify
Copy link
Contributor

Paid, @situchan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants