-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP staging] Revert "Fixed Android - Chat - Message gets displayed from right to left" #33677
[CP staging] Revert "Fixed Android - Chat - Message gets displayed from right to left" #33677
Conversation
testing... |
Reviewer Checklist
Screenshots/VideosAndroid: NativeBefore revert: before.movAfter revert: after.movAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: DesktopThere's another bug (user avatar is broken). Being handled in #33657 so out of scope |
Thanks @situchan! I'll ask for an internal engineer to get this approved and merged. |
Okay, merging because C+ verified the fix. No need for the full checklist on a straight revert. |
@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…splayed_right_to_left_30584 [CP staging] Revert "Fixed Android - Chat - Message gets displayed from right to left" (cherry picked from commit 80ebfdd)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.18-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀
|
Reverts #32297
Fixed Issues
$ #33675
Tests
Android native only