[HOLD for payment 2024-02-01] [$500] Pay button is shown briefly after approval when the policy has auto-reimbursement enabled

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.17.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Create a collect policy in OldDot with direct reimbursement
2. Execute the following JS snippet in the OldDot policy to enable workspace chats creation:
   if (Url.getCurrentPageName()!="policy" ){ alert('Only run this snippet from a policy editor!'); } else { var p = Policy.getCurrent(); p.policy.isPolicyExpenseChatEnabled = "true"; p.save().done(function(){$.jGrowl('Workspace chat creation enabled!')}); }
3. Add a member and an approver (the approver can be the policy owner too)
4. Login in one session as a member and in another session as the approver
5. As member, create a money request and submit it in the workspace chat
6. Verify the money request appears in the approver's workspace chat
7. Approve the report

Expected Result:

Should see the text " waiting for your admin to pay these expenses" in the header as a approver

Actual Result:

Approver is able to pay the request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6321973_1703114385175.Recording__343.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eef76618a7ab320c
• Upwork Job ID: 1740413058975150080
• Last Price Increase: 2023-12-28

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01eef76618a7ab320c

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[shubham1206agra]

@marcochavezf Didn't we fix this in the approve flow? I remember we fixed this

[shubham1206agra]

I am unable to repro this

Ideal behaviour reference

#28976 (comment)

[marcochavezf]

Didn't we fix this in the approve flow? I remember we fixed this

Ah the issue here is that when a policy has auto-reimbursement enabled, we're showing briefly the Pay button after approval, which shouldn't be the case since the backend will pay automatically once the request for approval has been processed.

[marcochavezf]

I will assign myself to work on it. I think we'd need to send from the backend the reimbursement data through Onyx to avoid showing the Pay button after approval if auto-reimbursement is enabled.

[melvin-bot]

@marcochavezf, @bfitzexpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcochavezf]

No update, but it's on my priorities

[trjExpensify]

Ah the issue here is that when a policy has auto-reimbursement enabled, we're showing briefly the Pay button after approval, which shouldn't be the case since the backend will pay automatically once the request for approval has been processed.

Can we update the OP of this issue and the title to reflect the problem at hand here?

[marcochavezf]

Sure, updating it

[marcochavezf]

Changing it to internal since it requires a backend change.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[marcochavezf]

PRs up

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.31-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide pay button when auto reimbursement enabled #33987

If no regressions arise, payment will be issued on 2024-02-01. 🎊

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @aimane-chnaif paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1740413058975150080/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[aimane-chnaif]

No regression. I don't think any previous PR break this behavior which used to work before.
As reported by QA team, we can skip regression test.

[melvin-bot]

@marcochavezf, @bfitzexpensify, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[marcochavezf]

Not overdue, waiting for payment

[bfitzexpensify]

Offer sent @aimane-chnaif

[bfitzexpensify]

Payment complete