-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide pay button when auto reimbursement enabled #33987
Hide pay button when auto reimbursement enabled #33987
Conversation
…er component to hide Pay button
… type declaration in ReportUtils.ts
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
On hold for backend changes but the code can be reviewed |
Hi @aimane-chnaif, the backend changes were deployed to production so the PR is ready for review. Can you provide me with some emails so I can add you to a policy with auto reimbursement enabled for testing? |
Friendly bump @aimane-chnaif |
review & testing is in progress. expecting completion on Monday |
Hi @aimane-chnaif, let me know if you run into any issues during testing, happy to help if something wasn't clear in the instructions or didn't result as expected during the testing :) |
Please resolve conflict |
I am not seeing |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
type CurrencyType = (typeof CONST.DIRECT_REIMBURSEMENT_CURRENCIES)[number]; | ||
const reimbursableTotal = getMoneyRequestReimbursableTotal(report); | ||
const autoReimbursementLimit = policy.autoReimbursementLimit ?? 0; | ||
const isAutoReimbursable = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB Unnecessary variable
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.31-7 🚀
|
On hold for https://github.com/Expensify/Web-Expensify/pull/40396Details
This PR hides the
Pay
button after approval for group policies only if the auto-reimbursement limit is greater than or equal to the reimbursable total and if the reimbursement is enabled at the policy level.Fixed Issues
$ #33716
Tests
Manual reimbursement
to a big numberPay
button is not shownPay
is not shown after approvalScreen.Recording.2024-01-04.at.6.36.24.p.m.mov
Offline tests
N/A
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop