[$500] Task – Reply remains under the task after deleting the subtask

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any account.
3. Create a task in 1:1 DM
4. Open the task details page and create a subtask assigned to yourself
5. Go back to the 1:1 DM and verify that Reply appears under the task.
6. Click on Reply link and open Subtask details page
7. Cancel the subtask
8. Go back to the 1:1 DM

Expected Result:

Reply disappears under the task after deleting the subtask

Actual Result:

Reply remains under the task after deleting the subtask

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6327943_1703804815259.Reply_remains_after_deleting_the_subtask.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f66de9449a2f9b75
• Upwork Job ID: 1740530326136565760
• Last Price Increase: 2024-03-21

Issue Owner

Current Issue Owner: @neil-marcellini

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f66de9449a2f9b75

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[jliexpensify]

Tagged DB in #vip-vsb here

[rushatgabhane]

bumped it on slack. the fix should be simple
https://expensify.slack.com/archives/C01GTK53T8Q/p1703814046408069

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reply remains under the task after deleting the subtask

What is the root cause of that problem?

We're not reducing the childVisibleActionCount of the parentReportAction of the parent task when deleting a subtask.

So the reply will still show.

What changes do you think we should make in order to solve the problem?

If the subtask has no child visible report action (by checking its childVisibleActionCount), reduce the childVisibleActionCount of the parentReportAction of the parent task when deleting a subtask, this needs to be done both optimistically (so it works in offline mode), and also in the back-end.

We're already doing the same when deleting comment here (works well for deleting comment in the task thread), so can just apply similar logic for deleting sub task.

What alternative solutions did you explore? (Optional)

Optionally reduce the childCommenterCount as well

I don't think so, but if this is the correct expectation, then we should not reduce the subtask childVisibleActionCount and childCommenterCount to 0 after it's deleted (likely the system message should be considered a visible report action), then the sub task will not be hidden after it's deleted.

[rushatgabhane]

@dukenv0307 the proposal looks like a workaround to me.
When a task is deleted, it has a system message. I believe that the task shouldn't be hidden in the first place

[dukenv0307]

When a task is deleted, it has a system message. I believe that the task shouldn't be hidden in the first place

@rushatgabhane the system message is only in the subtask's thread itself. In the parent task thread, the subtask will completely disappear (same behavior as when we delete a task inside a chat thread, that task will also disappear).

So to parent task, there will be no trace of the subtask (nor system message) so I think it makes sense to not show "Reply" under the parent task.

The deleted task will only show in its parent report if it has visible report action (like comments, another tasks, ... system message is not considered visible report action). This is the same behavior for money request as well so I don't think we should change it.

[rojiphil]

@rushatgabhane
I think this issue will get addressed in PR here.
Can we put this issue on hold till then?

[melvin-bot]

@rushatgabhane, @jliexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@rushatgabhane, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jliexpensify]

Thanks @rojiphil , can you let us know once that PR is sorted? Cheers.

[jliexpensify]

PR was deployed to prod already

[jliexpensify]

I believe this is now fixed on Chrome (Mac), the task gets deleted on v1.4.24-3.

However, on Android native v1.4.24-7 (Pixel 3a) and Android Chrome, I get the Missing transalation error when trying to assign a task to myself.

@lanitochka17 @rushatgabhane - can you both confirm? Thanks!

[melvin-bot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[neil-marcellini]

I will get to this eventually, seems low priority

[jliexpensify]

TYSM @strepanier03 - I am back now so unassigning you!

[jliexpensify]

@neil-marcellini if this is low priority, want to make it a Monthly?

[neil-marcellini]

Oh yeah Monthly aka the garbage can? Sure. 😂 🗑️

[jliexpensify]

Moreso we're not pinged every week lol

[neil-marcellini]

I've hadn't had time or thought about this for a while, but maybe I'll take a shot at it when I have some spare time.

[jliexpensify]

Not overdue.

[neil-marcellini]

Too much on my plate still, pushing this off again.

[jliexpensify]

Not overdue

[neil-marcellini]

I'm going to close this because it's #vip-vsb related and that's on pause.