[HOLD for payment 2024-02-07] Fix version mismatch for Notification Service Extension

[arosiclair]

cc @Expensify/mobile-deployers

Version Number: v1.4.21-0
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C07J32337/p1704304425942669

Action Performed:

Deployed to App Store

Expected Result:

No issues

Actual Result:

We're getting warnings about version mismatches between our main bundle and the Notification Service Extension:

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01625140e14e2c9d88
• Upwork Job ID: 1742939755659780096
• Last Price Increase: 2024-01-04

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01625140e14e2c9d88

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

[arosiclair]

I've also noticed comms notifications have stopped working (no avatars) for me in v1.4.21-4. This might be the reason.

Can't jump on this right now. If anybody wants to take a stab, go for it! otherwise I'll try checking it out tomorrow

[AndrewGable]

FYI you might need to change the version in the CI/CD build

[melvin-bot]

@puneetlath, @arosiclair, @s77rt Eep! 4 days overdue now. Issues have feelings too...

[arosiclair]

I think this just needs an extra step here. Gonna post a PR in a sec

[AndrewGable]

Agree

[arosiclair]

No C+ needed since this is just a deploy change. PR is out for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.24-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Bump NotificationServiceExtension version on deploy #34170

If no regressions arise, payment will be issued on 2024-01-18. 🎊

[arosiclair]

Version changes are working now! Already did the checklist above so this is all set

[AndrewGable]

As mentioned on Slack, fix didn't seem to work:

[arosiclair]

Okay I can actually reproduce this error in Xcode. It doesn't look like removing the Project Version and Marketing Version from the NSE target settings will fix it. The version just evaluates to (null):

[arosiclair]

This seems to be the root cause. The project is auto-generating and replacing our info.plist

[arosiclair]

PR is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix overriden CFBundleVersion and CFBundleShortVersionString #34760

If no regressions arise, payment will be issued on 2024-02-07. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR:
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@arosiclair] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[arosiclair]

This should be all done