[HOLD for payment 2024-03-13] Incorrect spacing and border radius on receipt thumbnail

[m-natarajan]

---

DESIGN UPDATES

---

So this is what I'm thinking we should do for the preview cards. As an outline, here is what we have (Figma file so you can inspect):

I'm thinking of this preview component as two parts:

• upper receipt area
• lower information area

When a receipt is present, I have it so that the upper receipt area and the lower info area overlap by -4px, which basically accounts for that inner border stroke (4px) of the receipt area not adding to the height of the lower info area.

The upper receipt area has a border radius of 16px:

And that means the inner receipt area there has a border radius of 12px (16px minus the 4px border):

For the bottom info area, the whole thing has a padding of 16px (vertically and horizontally):

The eyebrow part (XXXX owes:) should use our label font size, with a line height of 16px. It's in our text supporting color.

The amount is good as it is, which is our h2 size. The merchant/description line below should use our normal text size and use our text supporting color. It should have a line height of 20px.

In terms of spacing, I'm thinking it goes:

• Eyebrow/top line
• 8px gap
• Amount
• 4px gap
• Merchant/description
• 16px gap
• Button

---

ORIGINAL ISSUE

---

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.22-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704274831152639

Action Performed:

Create a receipt request in a workspace

Expected Result:

The receipt image in the request preview should have a border radius that is exactly 4px less than the outer border radius of the request preview card

Actual Result:

It looks like the receipt has the same border radius as the outer preview card.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0175c678ba62df22b2
• Upwork Job ID: 1743007697809223680
• Last Price Increase: 2024-01-04

Issue Owner

Current Issue Owner: @grgia

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect border radius on receipt thumbnail

What is the root cause of that problem?

There's 4px margin so if inner (ReportActionItemImages) border radius and outer (ReportPreview or MoneyRequestPreview) border radius are same, it doesn't look good

App/src/styles/index.ts

Lines 3812 to 3818 in 5b0ceb2

	reportActionItemImages: {
	flexDirection: 'row',
	margin: 4,
	borderRadius: variables.componentBorderRadiusLarge,
	overflow: 'hidden',
	height: variables.reportActionImagesSingleImageHeight,
	},

What changes do you think we should make in order to solve the problem?

reduce inner border radius to 12px (16-4)

App/src/styles/index.ts

Line 3815 in 5b0ceb2

borderRadius: variables.componentBorderRadiusLarge,

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0175c678ba62df22b2

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

[shawnborton]

So this is what I'm thinking we should do for the preview cards. As an outline, here is what we have (Figma file so you can inspect):

I'm thinking of this preview component as two parts:

• upper receipt area
• lower information area

When a receipt is present, I have it so that the upper receipt area and the lower info area overlap by -4px, which basically accounts for that inner border stroke (4px) of the receipt area not adding to the height of the lower info area.

The upper receipt area has a border radius of 16px:

And that means the inner receipt area there has a border radius of 12px (16px minus the 4px border):

For the bottom info area, the whole thing has a padding of 16px (vertically and horizontally):

The eyebrow part (XXXX owes:) should use our label font size, with a line height of 16px. It's in our text supporting color.

The amount is good as it is, which is our h2 size. The merchant/description line below should use our normal text size and use our text supporting color. It should have a line height of 20px.

In terms of spacing, I'm thinking it goes:

• Eyebrow/top line
• 8px gap
• Amount
• 4px gap
• Merchant/description
• 16px gap
• Button

Let me know how all of that sounds! cc @Expensify/design for eyes too.

[dannymcclain]

@shawnborton if you haven't already, can you please put these screens someplace where we can reference them when building out the legit preview component? I don't want these details to get lost in the void! 💚

[grgia]

We've combined #33980 into this issue! Taking internally

[dubielzyk-expensify]

can you please put these screens someplace where we can reference them when building out the legit preview component? I don't want these details to get lost in the void!

This is brilliant. I'll use this for my Preview Card Figma component.

[shawnborton]

@dannymcclain totally! I put the Figma link at the very beginning of my comment here

[melvin-bot]

@abekkala, @grgia, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

@shawnborton fantastic write up! I should be able to get to this one this week

[grgia]

Looking at this, I was trying to see if there's an easy way to get this component in storybook without tons of fake onyx data so we can prevent future regressions as well

[melvin-bot]

@abekkala, @grgia, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

I have a draft for this

[melvin-bot]

@abekkala @grgia @situchan this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[grgia]

PR in progress!

[melvin-bot]

@abekkala, @grgia, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@abekkala, @grgia, @situchan Huh... This is 4 days overdue. Who can take care of this?

[abekkala]

@grgia do you want to link the PR to this?

[grgia]

@abekkala I was working on a wave-related doc, but that's done so I'll get the PR merged and ready for final review before EOW!

[abekkala]

@grgia ah ok! I misinterpreted your post above! sorry about that.

[grgia]

Updating PR now

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Styling fixes for ReportPreview/MoneyRequestPreview #36278

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

PAYMENT SUMMARY FOR MAR 13

• Fix: Internal
• PR Review: @situchan [$500] Offer Link
  please complete checklist above

[situchan]

No regression. This is design inconsistency fix. I don't think regression test is needed here.

[abekkala]

@situchan can you accept the offer in Upwork so I can release payment today? thanks!

[situchan]

sorry I thought I accepted offer. Just did now

[abekkala]

@situchan payment sent and contract ended - thank you! 🎉